AdguardTeam / AdGuardSDNSFilter

AdGuard DNS filter
https://adguard-dns.io/
GNU General Public License v3.0
697 stars 125 forks source link

Duplicates Caused by third-party list #1650

Closed KnightmareVIIVIIXC closed 2 months ago

KnightmareVIIVIIXC commented 2 months ago

Prerequisites

What DNS server do you use?

AdGuard private DNS

Version

NA

What DNS upstream(s) do you use in AdGuard apps or AdGuard Home?

NA

What DNS filters do you have enabled?

NA

What browser or app do you use?

Microsoft Edge

Which device type do you use?

Desktop

What type of problem have you encountered?

Missed analytics or tracker

Where did you encounter the problem?

In the list

Add your comment and screenshots

So far I've just noticed it with two but the two duplicates came from the same list:

Because these entries are in another list without the $third-party modifier, the entries show up like this:

||allmt.com ||allmt.com^ ||afdads.com ||afdads.com^

This is the third party list with the modifiers that are causing the issue for the entries that I found: https://raw.githubusercontent.com/AdguardTeam/AdguardFilters/master/CyrillicFilters/common-sections/adservers.txt I'm assuming that most of the entries in there are going to be duplicated this way throughout the list. Maybe adding a compress transformation would fix it?

Privacy

Alex-302 commented 2 months ago

||example.com is not a duplicate for ||example.com^ ||example.com^ is a redundant, because ||example.com will block also example.com.tr. But it is impossible to say exactly for what purpose the separator ^ was not added. This can be either a typo or a correct rule.