search

AdguardTeam / AdguardAssistant

Adguard Assistant userscript
GNU General Public License v3.0
148 stars 19 forks source link

Allow AdGuard Browser Assistant to read and change all your data on websites that you visit #340

Closed ghost closed 3 years ago

ghost commented 3 years ago

Issue Details

AdGuard Browser Assistant constantly asking for site access. Even when you allow access, it requests it again on all sites ongoing.

Screenshot: Screen Shot 2020-11-14 at 13 11 06

It should allow the user the choice to give access to read all data on all websites.

HTTPS Everywhere Site Access vs AdGuard Site Access

Screenshot: HTTPS Everywhere Site Access settings Screen Shot 2020-11-14 at 13 11 41 AdGuard Site Access settings Screen Shot 2020-11-14 at 13 11 54
ameshkov commented 3 years ago

Hm, it seems like a Chrome UI inconsistency.

AdGuard Browser Assistant does not actually "ask" for additional access. It uses "activeTab" permission that means that the access is granted only when you click on its icon.

It should allow the user the choice to give access to read all data on all websites.

The only option here would be to actually request access to all websites. Currently, we just don't need that level of access.

ghost commented 3 years ago

I did wonder whether it was intentional or not. It's strange that it constantly says it's requesting access, but I suppose that's just one of the quirks of Chrome for now.

As my issue is no longer an issue, consider it closed.