AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.15k stars 335 forks source link

AdGuard 2.10.8 extension for Edge blocks Spotify web player song play #1090

Closed veronikasav closed 5 years ago

veronikasav commented 6 years ago

Steps to reproduce

  1. Go to https://open.spotify.com/
  2. Try to play any album.
  3. "Play" button is blocked.
  4. The album icon in the left-down corner is missing.

Whitelisting the website doesn't work. If I disabled AdGuard, the album icon is back, songs can be played, no problem at all.

Actual behavior

Screenshot: ![inkedscreenshot_1_li](https://user-images.githubusercontent.com/27292111/45000731-22667b00-afd0-11e8-85ca-2b041bd4b81e.jpg)
Screenshot of the browser console: ![inkedscreenshot_2_li](https://user-images.githubusercontent.com/27292111/45000741-36aa7800-afd0-11e8-98e4-38ffa2ab2513.jpg)

Your environment

ameshkov commented 6 years ago

@maximtop the issue is likely to be caused by the WebRTC/WebSocket overriding code.

karina-archazh commented 6 years ago

Checked

viniciusvillas commented 6 years ago

AdGuard is also blocking the XProtect Web Client (Milestone) video feed via WebSockets on MS Edge. I believe it's the exact same issue. Whitelisting the site doesn't work. Disabling the extension works. The fixing of issue #1014 is probably the culprit.

ameshkov commented 6 years ago

@viniciusvillas yep, that must be it, thank you for chiming in!

ameshkov commented 6 years ago

It seems that the only viable way is to simply rollback #1014 :(

Edge behaves unpredictably when we override WebSocket.