AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.11k stars 331 forks source link

Allow whitelist self-destruct cookies in invisible mode #1640

Open Bruce-Bane opened 4 years ago

Bruce-Bane commented 4 years ago

Problem Description

Currently running invisible mode with 3th part cookies auto destruction doesn't allow whitelist which cookies you want to keep, avoiding self destruction. This is very important cause some sites use 3th party cookies for important features, like remembering login sessions. That's the case of gmail and facebook for example. With the auto-destrou 3th party cookies enabled for 1 min (just for testing purpose), and letting facebook and gmail without access for some time, makes me loose the "remember signin" option. So i have to reenter login and password from time to time.

Proposed Solution

Create a list that shows all 3th party cookies sources domains and main domains currently in the browser. Allow the selection of those you want to keep out of the self-destruction rule

slavaleleka commented 4 years ago

there is no way to disable Stealth Mode options one-by-one now, only the whole Stealth Mode at once. but we can try to whitelist specific request for specific domain to avoid re-signing in

could you please specify the website where you need it?

Bruce-Bane commented 4 years ago

I noticed facebook and gmail started to logout after i enabled the 3th party self destruction cookies (only the 3th party!). I made i few tests to check if adguard was the responsible and it seems so. The test consisted of letting the self-destruction time around 1 min, closing facebook/gmail and waiting (usually more than a few minutes). After that, gmail and facebook are logged out. When I increase the self-destruction time to something like 4 days or more, it doesn't happen immediately, but after some days, eventually both are logged out. Besides that, this problem started to happen after i enabled adguard extension with invisible mode activated.

Furthermore I could solve the facebook problem by addding:

@@||facebook.com$cookie=c_user @@||facebook.com$cookie=xs

to my rules. Those are the cookies responsible of keeping the facebook session. After adding those rules and repeat the tests, only gmail logged out.

ameshkov commented 4 years ago

in invisible mode

What do you mean by invisible mode?

Create a list that shows all 3th party cookies sources domains and main domains currently in the browser. Allow the selection of those you want to keep out of the self-destruction rule

Hm, I think this is a good idea. Quite complicated to implement, but anyway, I like it.

Bruce-Bane commented 4 years ago

in invisible mode

What do you mean by invisible mode?

Sorry, invisible mode is the literal translation from my language to the translated "Stealth Mode". I just change adguard to English version now, and realized the name of the function was different. So i meant Stealth Mode.

Hm, I think this is a good idea. Quite complicated to implement, but anyway, I like it.

It would be awesome. I think Adguard is one of the best extensions now, but there is still a lot of opportunities to improvement. BTW, webrtc and hyperlink auditing block options would be some great features too. (i made an specific feature request for that)