Open Alex-302 opened 1 year ago
We can turn off this shortcut for the filtering log if users prefer to use native search.
Just pop up a small black or white (theme awareness) semi-transparent notification (custom toast notification … or native one if supported/enabled by the user) at bottom right for a few seconds after the user presses Ctrl+F
to inform him like so: "Use F3
instead for native search."
Possibly display this notification only once per "session" (versus at each Ctrl+F
).
F3
is OK at least on Firefox and Edge browsers on Windows 10."Use
F3
instead for native search."
It is obvious:) I just forgot about that.
We can turn off this shortcut for the filtering log
Ok.
:relaxed:
We can turn off this shortcut for the filtering log
Ok.
Personally, I find it convenient.
:smile: for :zero: — :tada: for :one:
:confused: for :two: — :heart: for :three:
:rocket: for :four: — :eyes: for :five:
:thumbsdown: for … suppression of this Ctrl+F
keyboard shortcut — in the Filtering log
window — without any replacement.
Note: To facilitate the vote click, counter already initialized by default to one for each.
:x: UPD: My main solution, while "OK" on Edge (and probably on any Chromium-based browsers), is problematic on Firefox (regarding its F3
behavior).
v4.1.1
:tada:)@Alex-302 By the way …
If possible, open browser's search by double Ctrl-F(or suggest another solution).
can be interpreted in two ways:
- _or suggest another solution_ … to the user if he presses `Ctrl+F` twice, like to use `F3` instead (in which case, my main suggestion is very similar to yours, except pressing `Ctrl+F` one time suffices for me to inform the user + I specify the method, i.e. via a toast notification — appearing only once maximum per "session");
- _or suggest another solution_ … directed to the people / devs who read your issue — in the sense of "if you have any idea …" / "if you have a better idea …".
:arrow_right: I must say that I understood the second possibility. :relaxed:
@contribucious
- or suggest another solution … directed to the people / devs who read your issue
This)
The public vote is now open! (Edit: For real now, voting system in place. :smile:) (@Alex-302 Any preference? :relaxed:)
Seems like F3
isn't working on macos.
cmd + f + f
- not sure if extension can retransmite cmd-f shortcut to the native system
3, 4 - does the issue happens only when preview window is open?
I prefer cmd/ctrl + shift + f
for focusing search field. This option looks valid for me.
ctrl + shift + f
This hotkey is inconvenient to press with one hand.
Seems like
F3
isn't working on macos.
So, one less option. I kinda suspected that when I saw this later — the isWindowsOs
part — (taken from this commit).
:arrow_right: A variant could however be the opposite: Leave Ctrl+F
natively and intercept F3
for AdGuard search (if this is not problematic on macOS either). But people may want a "next result" hotkey, therefore not an ideal choice. Another free F[1-12]
key perhaps? (Often used by various apps globally on the system though. Not ideal either, consequently.)
I prefer
cmd/ctrl + shift + f
for focusing search field. This option looks valid for me.
I like this option too. One that came to me among the quickest by the way and quite naturally.
:bulb: Cmd+Shift+F
(for macOS users) seems less easy than Ctrl+Shift+F
though. Maybe Ctrl+Shift+F
for all? (A bit less natural / macOS-style for them though.)
:eyes: Note that, in all cases, some users (both PC and MAC) have the FN key below SHIFT, instead of CTRL. Not my case but indeed, less practical then.
3, 4 - does the issue happens only when preview window is open?
Not sure I fully understand but here is the problem in a nutshell (Steps to reproduce).
open browser's search by double Ctrl-F
For example, Slack on the first Shift-Esc
suggests to clear unread messages, but if you press the hotkey twice - it opens browser's task manager(in Chrome).
Seems like
F3
isn't working on macos.
:bulb: After research, the non OS-specific version of this keyboard shortcut (used by all major browsers for Find next
) is:
Ctrl+G
(Windows/Linux) / Command-G
(macOS) — Vote post adequately updated.
I prefer
cmd/ctrl + shift + f
for focusing search field. This option looks valid for me.
I note an advantage to this light/quick solution:
you can keep all native stuff with Ctrl + [key]
and set AdGuard specific stuff with Ctrl + Shift + [key]
.
For example (flexible solution that can even be extended in the future):
Another variant https://beautifier.io/ - on the first press opens the search in the edit box, on the secont - browser's search.
Issue Details
Actual Behavior
Cannot use Ctrl-F to search a text on the filtering log page. We use it to search a specific text in the lines, that displayed by the search, and on details panel.
Expected Behavior
If possible, open browser's search by double Ctrl-F(or suggest another solution).