AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.03k stars 326 forks source link

Add a dedicated link/icon to the filter URL #2335

Open contribucious opened 1 year ago

contribucious commented 1 year ago
💻 AdGuard AdBlocker Beta (Standalone) 4.1.55 on Firefox 112.0.1 — Win 10 Pro 22H2

Hi there! As a user of both AG for Windows (on my Windows) and AG Browser extension (on my Linux traditionally, except when testing like here), I spotted an annoying difference.  

🔍 Issue Details

🪟 ᴀᴅɢᴜᴀʀᴅ ᴀᴘᴘ

! Homepage: URL is found in a given filter?       ↬  Copy homepage link will appear in the context menu  —  ᴀꜱ ᴇxᴘᴇᴄᴛᴇᴅ. ✔️

…Not found?       ↬  Nothing will appear in the context menu  —  ᴀꜱ ᴇxᴘᴇᴄᴛᴇᴅ. ✔️

🧩 ᴀᴅɢᴜᴀʀᴅ ᴇxᴛᴇɴꜱɪᴏɴ

! Homepage: URL is found in a given filter?       ↬  Go to homepage link will use this URL  —  ᴀꜱ ᴇxᴘᴇᴄᴛᴇᴅ. ✔️

…Not found?       ↬  Go to homepage link will use the filter URL instead (as a fallback)  —  ʜᴍ …… 💭

 

💡 Proposed solution

🧩 ᴀᴅɢᴜᴀʀᴅ ᴇxᴛᴇɴꜱɪᴏɴ

… ↷

🪟 ᴀᴅɢᴜᴀʀᴅ ᴀᴘᴘ

Either:

That is to say, an enhancement of this issue — but I will open a dedicated issue linked to mine on this repo if you like my idea. ✔️

 

📷 Screenshots

Reveal …   ![AGExt_FROM](https://user-images.githubusercontent.com/4764956/233126002-8719e79e-3603-4592-afee-13fb30f639ff.png) ↪️ From the current situation … ![AGExt_TO-MAINVER-ORIG-TRASH-ICON](https://user-images.githubusercontent.com/4764956/233126195-250ce8cc-0938-4e37-83e1-8de9b8a76214.png) ↪️ To this situation (with the _current_ trash icon preserved) … ![AGExt_TO-ALTVER-CUSTOM-TRASH-ICON](https://user-images.githubusercontent.com/4764956/233126309-7188f5c0-af20-4eff-895b-27b1f941b829.png) ↪️ Or this **variant** situation (with the trash icon from _Fork Awesome_, just like the other two — all available [here](https://forkaweso.me/Fork-Awesome/icon/trash-o/), [here](https://forkaweso.me/Fork-Awesome/icon/home/) and [there](https://forkaweso.me/Fork-Awesome/icon/file-code-o/) and set to 80% opacity) … ![AGExt_TO-MAINVER-ALTVER-COMPARISON_animated](https://user-images.githubusercontent.com/4764956/233152510-39bbd61a-fe1c-47ef-ae51-b2fcb7a47ad3.gif) ↪️ **BONUS:** Animated version for comparison between the two versions …
contribucious commented 1 year ago

Remark

Because of the complexity of my issue relating to formatting for clarity, I tested replacing this link by this one — that is, no template applied (performed myself very closely) but the label(s) still applied.

↪️ However, the https://github.com/AdguardTeam/AdguardBrowserExtension/labels/Feature%20Request label does not seem to have applied (due to no template set visibly). Sorry for that. ☺️

tumatanquang commented 1 year ago

I feel it is not too useful, having too many symbols, images,... Only makes the layout confused, reduces performance and consumes more capacity and memory. 😕

contribucious commented 1 year ago

@tumatanquang Hi! 🙂

Note that 3 icons will only appear in the "Custom" section. Only two otherwise (because the trash can icon does not appear elsewhere); … in fact, probably one only (as the Source icon pointing to the filter URL is slightly less useful for built-in filters).

However, as an alternative, we can also imagine a "three dots" menu including Homepage and Source. To keep a layout more similar to the current one. And then having the same — or very similar — consistent access to that in the desktop AdGuard app too, but there, via the right-click context menu on a given filter.