AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.13k stars 334 forks source link

Sites loading-slowly in Firefox 118 when AdGuard extension is enabled #2524

Open dftf-stu opened 1 year ago

dftf-stu commented 1 year ago

AdGuard Extension version

AdGuard Browser Extension v4.2.168

Browser version

Firefox (x64), v118.0.1 + Microsoft Edge (x64), v117.0.2045.55

OS version

Windows 10 Home 22H2 (x64) Build 19045.3448

What filters do you have enabled?

AdGuard Base filter, AdGuard Mobile Ads filter, Filter unblocking search ads and self-promotion, Online Malicious URL Blocklist, NoCoin Filter List

What Stealth Mode options do you have enabled?

No response

Issue Details

I've noticed in the last couple of weeks or so that sites are taking a lot-longer to load in Firefox than they used to.

So as a test: I have a bookmarks folder called "News", which opens eight (8) websites when I middle-click it. I started a stopwatch on my phone when I middle-clicked it (which causes all of the sites to load at-once, in their own tab), and pressed "stop" when all sites had loaded (defined as "the favicon for each site has appeared in their respective tab").

In Firefox (118.0.1):

In Microsoft Edge (117.0.2045.55):

I have tried fully uninstalling Firefox, deleting my local profile folders (from AppData\Local\Mozilla and AppData\Roaming\Mozilla), then re-importing my bookmarks back into the new profile, but it makes no-difference.

Is there any other troubleshooting I can do here, or is there some-conflict between a recent update to the AdGuard Browser Extension and the recent Firefox 118 release that is causing this issue?

Expected Behavior

For websites to load quicker in Firefox 118, as they did until around a couple of weeks ago

Screenshots

Screenshot 1:

Additional Information

OS: Windows 10 Home (x64) 22H2 Build 19045.3448 AdGuard: Browser Extension v4.2.168 (same version in both browsers) DNS: https://dns.adguard-dns.com/dns-query

dftf-stu commented 1 year ago

UPDATE: I've just tried installing a rival ad-block extension into Firefox (whose name sounds-like "blue-jock, horror-tin") and that one has absolutely no-issues in my Firefox -- all eight sites loaded in 9-10 seconds! (So as-fast as when no extension is used! 😲)

Not-sure what's suddenly causing AdGuard to be so-slow in Firefox, but hopefully they can fix it? πŸ™πŸ»

ks1322 commented 1 year ago

Probably related to https://github.com/AdguardTeam/AdguardBrowserExtension/issues/2508

dftf-stu commented 1 year ago

@ks1322: interesting, so you first-noticed the issue back in Firefox 117, and you're using a Linux-based OS. Whereas I am using Firefox 118.0.1, and Windows 10.

I did a search on here for any existing open-tickets (e.g. for terms like "firefox", "slow", "delay", "hang", "freeze") before logging mine, and I did see yours, but as it only mentioned Yandex Maps in the title (a site I never use) I didn't think it would be relevant.

Do you use any Chromium-based browsers on your distro (e.g. Chromium, Brave, Opera, Vivaldi) and do you see the same CPU issues in them, with AdGuard added? On my Windows 10 system, I am not getting major-delays in loading sites in Microsoft Edge, only in Firefox.

It's to the point of being unusable for me currently: if I have some websites open, and then open a few more (for example, I middle-click on a few articles on a news website) then it literally causes all my other sites to either freeze, or load slowly. Images in articles don't load as I scroll down the pages, or YouTube videos stutter, or take 10-15 seconds if I skip-forward to resume playback. I have to wait until all sites are fully-loaded before I can do anything in any of them. πŸ˜•

dftf-stu commented 1 year ago

@ks1322: within the reviews for the extension on the Firefox Add-Ons site, I found this one which says:

"Doesn't work anymore. Since two days keeps crashing Firefox, slows it down and raise CPU utilisation up to 100% for almost all time. I had reset and reinstalled addon but doesn't help. On MS Edge there is no problem."

ks1322 commented 1 year ago

@dftf-stu I do use Chromium sometimes, but without AdGuard installed. So I can't say for sure about major-delays in Chromium.

dftf-stu commented 1 year ago

@ks1322: I've just-tested the five most-popular ad-blocker extensions, as listed in the Firefox Add Ons website:

AdBlocker-Firefox-Testing-5Oct2023

As you can see, something is definitely wrong at the moment with AdGuard in Firefox as it takes significantly-longer to finish loading my eight test websites than any of the other four leading-rivals (and uses the most RAM, too!)

dftf-stu commented 1 year ago

UPDATE: I did the same testing in Microsoft Edge and... AdGuard was also the slowest-performing for me there, too 😭

AdBlocker-FirefoxEdge-Testing-5Oct2023

I'd be happy to help the developers with any testing -- but I'm honestly just wondering about moving to one of their rivals instead, given they are faster and generally use less RAM. Is there any benefit to sticking with AdGuard? Have any third-parties tested the various ad-blockers and confirmed it does the best job, for example? πŸ€”

kodiakhub commented 1 year ago

@dftf-stu Hi! just saw your issue and can you please check this url for test too? With Firefox and AdGuard Turkish filter. Just wondering how it results on your end. πŸ‘‰ https://www.izle7.com/kanal7/kategori/emanet To see the result, all you have to do is scroll the page up and down continuously. πŸ‘

Warning: this test may cause huge memory usage and keep goes. See:

Screenshot

![image](https://github.com/AdguardTeam/AdguardBrowserExtension/assets/56846906/f7c715bc-3e04-4d29-8f80-8e8b3a81a2d4)

I can't be the only one who sees this weirdness, right? πŸ˜„

shape55 commented 1 year ago

I was just going to post a report on this same issue! This started happening sometime within the past couple weeks, and I'm also using Firefox 118.0.1 w/ the latest AdGuard v4.2.168 add-on on macOS Catalina. AG is causing webpages to load about 10x slower than in Safari (using AG for Safari), when Firefox webpages used to be significantly faster than Safari.

Even if I turn off every single toggle setting in every category of Firefox AdGuard so that nothing is enabled, I still don't notice any improvement in speed. If I disable the add-on in the Add-ons Manager though, webpages then load instantaneously. I also tried removing and re-adding the add-on, but this didn't help. I've been using AG in Firefox for many years and never seen this happen before.

maximtop commented 1 year ago

Hi, thank you for opening this issue. I attempted to reproduce the issue by adding some news websites but was unable to do so.

So as a test: I have a bookmarks folder called "News", which opens eight (8) websites when I middle-click it. I started a stopwatch on my phone when I middle-clicked it (which causes all of the sites to load at once, in their own tab), and pressed "stop" when all sites had loaded (defined as "the favicon for each site has appeared in their respective tab").

Could you please share the list of websites in your "News" folder and the settings of your AdGuard extension? You can do this via an export of your settings. If the settings contain sensitive information, you can email them to devteam@adguard.com with a reference to this issue and the browser extension you are using.

dftf-stu commented 1 year ago

Hi @maximtop

maximtop commented 1 year ago

Hi @maximtop

  • The extension I was using is called "AdGuard AdBlocker" which I installed from here in the Firefox Add-Ons store
  • The eight websites I visited in my test are: Ars Technica β€’ BleepingComputer β€’ Guido Fawkes β€’ MoneySavingExpert β€’ Spiked Online β€’ Sky News UK β€’ The Register β€’ Thurrott
  • Please find the exported settings attached (which I have renamed from JSON to TXT, as GitHub blocks JSON file-uploads) 20231009_140828_adg_ext_settings_4.2.168.txt
  • After re-installing AdGuard to test for you just now (and export the settings you requested) I opened all eight-sites in Firefox 118.0.1 and it took 59 seconds. I then tested in the most-popular rival to you, and it took just-over 9 seconds. I would be surprised if your team are unable to replicate this, given in this ticket there are reports from users on both macOS and Linux who have experienced the issue in both Firefox 117 and 118 versions

Please, try to disable this setting

image

and check if if it helped to reduce time

dftf-stu commented 1 year ago

Hi @maximtop : yes, disabling that took the total-time down from 59 seconds, to just-over 21 seconds.

That is the same-speed I get in Microsoft Edge to load all eight websites (though in Edge, I did have that setting enabled, but didn't experience the slowdown. So odd why having it enabled has only-recently started to affect just Firefox?) πŸ€·πŸ»β€β™‚οΈ

maximtop commented 1 year ago

Hi @maximtop : yes, disabling that took the total-time down from 59 seconds, to just-over 21 seconds.

That is the same-speed I get in Microsoft Edge to load all eight websites (though in Edge, I did have that setting enabled, but didn't experience the slowdown. So odd why having it enabled has only-recently started to affect just Firefox?) πŸ€·πŸ»β€β™‚οΈ

We will check it. Thank you.

dftf-stu commented 1 year ago

Hi @ks1322 , @kodiakhub , @shape55

Please follow these steps and see if it improves the speed loading your sites:

(1) Click the AdGuard icon (2) Click the cog icon (βš™) to go into the settings AdGuard-TurnOffStatSend-01

(3) Click "Additional Settings" in the left-hand list AdGuard-TurnOffStatSend-02

(4) If "Help with the development of AdGuard filters" is turned on, turn it off AdGuard-TurnOffStatSend-03

(5) Fully close Firefox (all open tabs and windows), wait 10-15 seconds, then load-up Firefox again. Then try going to your usual sites and see if they load faster

ks1322 commented 1 year ago

I can confirm that disabling "Send anonymous statistics of ad filters usage that will help us improve and optimize them" option improves Firefox performance in my test on https://yandex.ru/maps/.

dftf-stu commented 1 year ago

(@maximtop: this is unrelated, but seeing as you've replied here I thought I'd ask: where are we supposed to go to report issues with websites when the AdGuard DNS service is used? There isn't a GitHub here for it, and the online report tool doesn't have an option in the dropdown for the DNS product. I e-mailed your team, but last I heard-anything was three-weeks ago. Is there a site we're supposed to use for this? Thanks)

maximtop commented 1 year ago

(@maximtop: this is unrelated, but seeing as you've replied here I thought I'd ask: where are we supposed to go to report issues with websites when the AdGuard DNS service is used? There isn't a GitHub here for it, and the online report tool doesn't have an option in the dropdown for the DNS product. I e-mailed your team, but last I heard-anything was three-weeks ago. Is there a site we're supposed to use for this? Thanks)

If it's a filtering issue, it's better to report it from the product where the AdGuard DNS service is incorporated. Alternatively, you can manually create an issue here: https://github.com/AdguardTeam/AdguardFilters/issues

dftf-stu commented 1 year ago

@maximtop: I couldn't find this repository when I first looked (before I asked you) but would this be the correct place? https://github.com/AdguardTeam/AdGuardDNS ?

I have a website which is totally-broken when AdGuard DNS is used, but is fine when I use any-other DNS service

maximtop commented 1 year ago

@maximtop: I couldn't find this repository when I first looked (before I asked you) but would this be the correct place? https://github.com/AdguardTeam/AdGuardDNS ?

I have a website which is totally-broken when AdGuard DNS is used, but is fine when I use any-other DNS service

yes, you can report technical issues there

kodiakhub commented 1 year ago

Please follow these steps and see if it improves the speed loading your sites:

I think it's a different issue with sites under certain circumstances. Firefox crashed completely after using more than 14 GB of memory. πŸ˜„

Screenshots ![A](https://github.com/AdguardTeam/AdguardBrowserExtension/assets/56846906/c1f8145e-5a8f-4f9f-a743-6e48851cf85c) ![B](https://github.com/AdguardTeam/AdguardBrowserExtension/assets/56846906/6ab36bd0-3372-4908-b990-e8469151380c)
dftf-stu commented 1 year ago

@kodiakhub : I did think your issue may-not be related, yes.

Is there any-reason on that website why you need to scroll up-and-down the page a lot? πŸ€”

If you do that in any browser, I would expect increased CPU and GPU use.

Have you tried disabling AdGuard and seeing if the issue still occurs then? (You can disable it by going to the hamburger-menu (three-lines) then "Add ons and themes..." and then use the ON/OFF toggle to turn it off. This will keep all of your settings for AdGuard so you can turn it back-on later and not lose anything.)

AdGuard-Disabled-Firefox

kodiakhub commented 1 year ago

@kodiakhub : I did think your issue may-not be related, yes.

True.

Is there any-reason on that website why you need to scroll up-and-down the page a lot? πŸ€”

Just for testing purposes, initially the thumbnails in the videos and AdGuard extension were loading very slowly. The same situation occurred again when we scrolled the page up and down after the thumbnails were loaded.

If you do that in any browser, I would expect increased CPU and GPU use.

Yes, but the overload is unexpected.

Have you tried disabling AdGuard and seeing if the issue still occurs then? (You can disable it by going to the hamburger-menu (three-lines) then "Add ons and themes..." and then use the ON/OFF toggle to turn it off. This will keep all of your settings for AdGuard so you can turn it back-on later and not lose anything.)

This only happens with the AdGuard extension. There is no such problem with the uBO extension and Adguard filters. You can see example test video comparisons on that issue. πŸ‘

shape55 commented 1 year ago

@dftf-stu: Ok, yes, disabling this single setting AND relaunching Firefox definitely made sites load faster. If I don't relaunch the browser after disabling this though, then it makes no difference, even if I wait a while.

However, this is only part of the issue. Just having the add-on enabled still makes pages load much more slowly than they did a couple weeks ago, w/ all toggles in every category turned off. And if I disable the add-on, then pages load instantaneously. I also just updated to FF 118.0.2, but this had no effect. However, if it requires relaunching the browser after disabling other settings for changes to take effect, then I wouldn't be able to tell.

Also, why doesn't AdGuard for Safari have the Help with the development of AdGuard filters setting?

dftf-stu commented 1 year ago

@shape55: I'm not a macOS user, only Windows, so I cannot confirm first-hand what options AdGuard for Safari offers -- but the screenshots here for that version don't seem to show it. Though I'm not-sure if Safari is even affected by this slowdown issue anyway. On my PCs, only Firefox was, but Chrome and Edge weren't

As for the slowdown in Firefox -- the person who works for AdGuard here, @maximtop , has said they are looking into it. All I can suggest in the meantime is to disable your AdGuard extension and use a different ad-blocker, such as this one, until they update this ticket to say the slowdown issue has been fixed. Then switch-back to AdGuard at that-time if you wish

shape55 commented 1 year ago

@dftf-stu: Yeah, I just realized that the Safari version doesn't include it, and then changed my question shortly before you replied :)

For now, I'll just keep this one setting disabled, as it's not worth the time to switch to a new ad blocker unless there is no fix for a while. But thanks for the suggestion.

dftf-stu commented 1 year ago

Hi @maximtop

Just to let you know but I've ran the test on a different PC while visiting family and the results are:

Firefox

Microsoft Edge

So having that option on definitely makes a noticeable difference to the load-time of sites, but more-so in Firefox, where it added nearly a minute extra, compared to the 13 seconds in Edge

dftf-stu commented 1 year ago

Hi @maximtop

I've just tested on another laptop I have (which has an Intel Core i7, 16GB RAM and an SSD) and the results are:

Firefox v118.0.2

Microsoft Edge v118.0.2088.46

So AdGuard was actually faster than the most-popular ad-blocker extension for me in Edge when the report-back option is turned-off, and the same-speed as it when it is left on. However, in Firefox, your rival loaded all eight websites in 5 seconds, whereas AdGuard with the report-back option disabled took 11 seconds, and 29 SECONDS when it is enabled. That is nearly three-times as long (or nearly SIX TIMES as long as your biggest rival)

Not-sure what is going on with AdGuard and Firefox lately, but hopefully it can be fixed... any updates you could share?

dftf-stu commented 1 year ago

Hi @maximtop

Have there been any updates on this issue you could share? Your last reply was three weeks ago (9 Oct), and this ticket will have been open for a month as of this Thursday.

I've already advised any friend or family-member to whom I've previously recommended your extension to disable that setting, but within the next week or two I'll simply start recommending they remove AdGuard and switch to a different ad-blocker as I cannot be-sure if this issue is still being looked-into or not.

Thanks

maximtop commented 1 year ago

Hi @dftf-stu,

I apologize for the delay in updating you on this matter. We have been preoccupied with other pressing issues, which has resulted in a delay in investigating the page loading times you've reported.

We are still committed to resolving this issue, and your information has been valuable in helping us understand the scope. That said, it may take some time before we can provide a concrete update or solution.

Thank you for your patience.

shape55 commented 7 months ago

Hi, just wanted to check back on this to see what the status was. Have any changes been made w/ the Help with the development of AdGuard filters setting, or general site loading times as reported above?