Add validation for allowlist

[pejotigrek]

AdGuard Extension version

4.2.226

Browser version

119.0.6045.160 (Official) (64-bit)

OS version

Windows 10

What filters do you have enabled?

AdGuard Base filter, AdGuard Annoyances filter, AdGuard Cookie Notices filter, AdGuard Popups filter, EasyList China, EasyList Germany, EasyList Italy, Liste FR, Official Polish filters for AdBlock, uBlock Origin & AdGuard, Polish Social Filters, EasyList Spanish, KAD - Anti-Scam, Polish Annoyances Filters, Polish Anti Adblock Filters, NoCoin Filter List, EasyList Polish, Polish Anti-Annoying Special Supplement

What Stealth Mode options do you have enabled?

No response

Issue Details

Extension keeps turning off - the icon is greyed out, so I am trying to turn on the protection, seems like it works, but after reloading the page - again it is turne off and no protection is applied.

Expected Behavior

AdGuard protection working as usual.

Screenshots

Screenshot 1: after starting the chrome browser and entering *any* page


Screenshot 2: when I tap on the switch, page reloads and switch shows green [but the icon is still greyed]


Screenshot 3: so I close the AdGuard's popup, again press on the icon and see the switch turned off:


Additional Information

No response

[pejotigrek]

further investigation:

I am not sure if I've missed some changes in the allowed/user lists but here's what I've found:

• I had about 50-ish entries in the allowed list
• about 10 of them was entered using the rules syntax
• it all worked for sure, until today, when I've noticed the greyed out icon [and while all updates are done automatically in my browser, indeed the AdGuard extension updated itself today or tomorrow AFAIR correctly]
• when I've deleted all "allowed" entries that were using the rules syntax - AdGuard is now running without any problems and it doesn't turn off by itself

example of the rule that "kills" the protection:

@@||androidcentral.com/$document

[I had this for sooo long, I don't even remember when I've entered it ;) but checking with rules syntax, I've tried also as @@||androidcentral.com^$document and it killed the protection too]

[DerFreischutzTKH]

same here, i think they did it again https://github.com/AdguardTeam/AdguardBrowserExtension/issues/2461

Exactly the same bug, after remove @@||xxx.com^ from my allowlist, extension works fine again wtf

[maximtop]

@DerFreischutzTKH, @pejotigrek AdGuard's allowlist doesn't support rules, only plain text with domain names (example.org). Recently, we've added support for wildcards (*.example.com), which might explain why your rules started turning protection off. If you want to use rules, then add them to the user rules section. I think we should add validation for the allowlist.

[pejotigrek]

@maximtop out of curiosity: is it possible that rules worked before? like I mentioned - I think I had those rules "almost forever" in my allow list [I really don't even remember writing some of them by hand.. so maybe were added automagically when using some "block this/allow this" options in the menu/icon?]

+1 for validation, it gave me a while to get to the list and then to find out what's blocking the protection. simple notification or even red icon color could be a nice addition :)

[maximtop]

is it possible that rules worked before?

It's unlikely that these rules worked as intended before. If they did, it must have been quite some time ago.