AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.02k stars 323 forks source link

The $generichide modifier prevents URL blocking rules from working correctly #2690

Open alexx7311 opened 8 months ago

alexx7311 commented 8 months ago

AdGuard Extension version

4.3.4

Browser version

Chrome 121

OS version

Windows 11

What filters do you have enabled?

AdGuard Base filter, AdGuard Social Media filter

What Stealth Mode options do you have enabled?

No response

Issue Details

STR: 1) Disable all filters except for Base filter and Social media filter. 2) Go to https://www.espaebook2.com/book/cuentos-del-inventor-de-respuestas-2/ 3) Open filtering log and check if the rule https://platform.twitter.com/widgets/tweet_button.html?count=vertical&url=https://www.espaebook2.com/book/cuentos-del-inventor-de-respuestas-2/ exists.

Screenshot from 4.1.57 ![Screenshot](https://github.com/AdguardTeam/AdguardBrowserExtension/assets/114913601/a7821c91-0141-414e-97fd-0f5bf6ac2efd)

Expected Behavior

No response

Screenshots

Screenshot 1:

Additional Information

No response

Alex-302 commented 8 months ago

One more case at http://matomelotte.com/tag/%E6%BE%A4%E6%9D%91%E6%8B%93%E4%B8%80

https://www.facebook.com/plugins/like.php?href=http%3A%2F%2Fmatomelotte.com is not blocked if added @@||facebook.com^$generichide

The rule, which should block that request ||facebook.com/plugins/$domain=~facebook.com|~freepresets.com

Yuki2718 commented 8 months ago

I suggest @@||facebook.com^$generichide,badfilter as a temp workaround, though probably the problem will happen with other rules too. @@||facebook.com^$generichide was added to potentially defuse their anti-adb, but no filter author has confirmed it actually works.

Alex-302 commented 8 months ago

It's better to wait. The new version (4.4) should be released soon.

krystian3w commented 8 months ago

Worse if there is no solution in planned  https://github.com/AdguardTeam/AdguardBrowserExtension/labels/Version%3A%20AdGuard%20v4%2E4 And it will be carried over to releases  https://github.com/AdguardTeam/AdguardBrowserExtension/labels/Version%3A%20AdGuard%20v4%2E5 or  https://github.com/AdguardTeam/AdguardBrowserExtension/labels/Version%3A%20AdGuard%20v4%2E6 (or his patches/hotfixes).

alexx7311 commented 6 months ago

Similar issue https://github.com/AdguardTeam/AdguardBrowserExtension/issues/2757