AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
2.96k stars 322 forks source link

Filtering log: History is still cleaned up when redirecting even if `Preserve log` is enabled and closed tabs are still stored in the open tabs list. #2701

Open tumatanquang opened 6 months ago

tumatanquang commented 6 months ago

AdGuard Extension version

4.2.241

Browser version

Chrome 109

OS version

Windows 7

What filters do you have enabled?

Filter unblocking search ads and self-promotion

What Stealth Mode options do you have enabled?

No response

Issue Details

History is still cleaned up when redirecting even if Preserve log is enabled:

Steps to take:

  1. Open Filtering log and enable the Preserve log.
  2. Open any website with pop-ups (I use vietup.net as an example)
  3. Tap anything in the webpage to have the pop-up window open in a new window
  4. All links that use the redirect will not be recorded, it only starts logging once it has been redirected to the destination page.

I recorded a video, you can refer to:

https://github.com/AdguardTeam/AdguardBrowserExtension/assets/20223064/8b8972b8-42c3-48bd-a64e-09be23d49bfc

As shown in the video, it can be seen that it is redirected from glomeliasbest.life to ak.phumpauk.com. However, the Filtering log only starts logging when it has been redirected to ak.phumpauk.com (i.e. all links used to redirect on glomeliasbest.life are not recorded).

P/s: Since I blocked ak.phumpauk.com with the hosts file so ak.phumpauk.com will return a ERR_CONNECTION_REFUSED error in the video but don't mind it because it's irrelevant.

Closed tabs are still stored in the open tabs list:

Sometimes some tabs I have closed, it has completely killed out of Task Manager as well as has freed up memory. But when I checked in the Filtering log, it still appeared in the list of open tabs.

I also tried closing the Filtering log, clearing the browser history (which doesn't seem necessary since I use an incognito window), reopening the Filtering log but it wasn't deleted from the list of open tabs either.

Only when I do a kill on this extension and restart the extension, at this point the closed tab is removed from the list of open tabs.

UPDATE: As in the video, although the Google Keep tab has been closed, no Google Keep tab is currently open, but in the open tabs list of Filtering log still shows a Google Keep tab.

https://github.com/AdguardTeam/AdguardBrowserExtension/assets/20223064/18960a89-3f1d-4e59-a552-aa737b74e179

Expected Behavior

  1. All history will be recorded, especially when the 'Preserve log' is activated. The current behavior seems to only record history at the currently open tab and the new tab does not.
  2. When the tab is closed, it is removed from the open tab list in the Filtering log.

Screenshots

No response

Additional Information

No response

alexx7311 commented 5 months ago

@tumatanquang Hello! Please update the extension to the latest version and check if these problems persist.

tumatanquang commented 5 months ago

@alexx7311 I checked on version 4.2 and latest version 4.3.31: It's still not fixed! P/s: I still update the latest information at #2484.