search

AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.12k stars 333 forks source link

Cannot add custom filters from Google Drive #2908

Open Tech-How opened 3 months ago

Tech-How commented 3 months ago

Please answer the following questions for yourself before submitting an issue

AdGuard Extension version

4.3.53

Browser version

Chrome 127

OS version

Windows 10

Ad Blocking

AdGuard Base filter

Privacy

AdGuard Tracking Protection filter

Social

AdGuard Social Media filter

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

What Tracking protection options do you have enabled?

Block trackers

Issue Details

Steps to reproduce:

  1. Upload a filter list file to your Google Drive account. Then, change the sharing permissions to anyone with the link, and copy the link.
  2. Modify the URL so it looks as follows: https://drive.google.com/uc?id=FILE_ID&export=download
  3. Paste your modified URL into your browser to test it. It should download the direct file immediately, without taking you to the Google Drive download page.
  4. Import that modified URL into the AdGuard Chrome extension.
  5. The filter is unable to add.

Expected Behavior

The filter adds successfully, as it is a direct link to the file. The method I described above works on the AdGuard mobile app, uBlock origin, Hyperweb on iOS, when called from PowerShell on Windows, etc. Every time I've modified the Google Drive URL to get the direct link it's worked in every application, except for this one.

Actual Behavior

The filter list does not import, with a generic error. Is the extension getting confused by the "?" and "&" parameters in the URL, perhaps?

Screenshots

Screenshot 1

Additional Information

Here is an example link of mine you can try: https://drive.google.com/uc?id=16UOwbt_qw0Z4vdoDVoGy6Up9_sjHjQbv&export=download

Tech-How commented 2 months ago

If someone is having trouble reproducing this or has any other information to share please do. It's possible it could be something else as well, but this filter list does work on other services.