AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
3.11k stars 332 forks source link

The custom filter download fails if it takes more than 3 seconds #2937

Open xiaomoy opened 1 month ago

xiaomoy commented 1 month ago

Please answer the following questions for yourself before submitting an issue

AdGuard Extension version

4.4.22

Browser version

Edge 128

OS version

Win 11

Ad Blocking

No response

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

What Tracking protection options do you have enabled?

No response

Issue Details

In the "New filter subscription" interface, if the download time exceeds 3 seconds, it will fail.

Expected Behavior

No response

Actual Behavior

If the download time exceeds about 3 seconds, the console log shows Fetch timeout is over

Screenshots

Screenshot 1 ![image](https://github.com/user-attachments/assets/29c0b1d1-7ea3-451a-a196-204d579d809f)

Additional Information

No response

alexx7311 commented 1 month ago

@xiaomoy Can you please provide a link to this filter? I couldn't reproduce the problem.

alexx7311 commented 1 month ago

@xiaomoy I checked with the developers. You're right, we have the timeout. How much time should the extension have for the filter to load, in your opinion?

alexx7311 commented 1 month ago

@xiaomoy any updates?

xiaomoy commented 1 month ago

@xiaomoy I checked with the developers. You're right, we have the timeout. How much time should the extension have for the filter to load, in your opinion?

@alexx7311 I sincerely apologize for my recent unavailability over the past two weeks. Upon the initial addition of the new filter subscription the data was fully downloaded. Can we then utilize the data from this initial download directly?

alexx7311 commented 1 month ago

@xiaomoy we're downloading a filter 2 times, but this is the peculiarities of implementation and we won't change that. But we can increase the 3 seconds timeout if you want. What timeout should we set in your opinion?

xiaomoy commented 1 month ago

@xiaomoy we're downloading a filter 2 times, but this is the peculiarities of implementation and we won't change that. But we can increase the 3 seconds timeout if you want. What timeout should we set in your opinion?

I propose setting the timeout to 15 seconds, after which a popup should inform the user of the download timeout. I personally think it can be set to the same download time as the new filter subscription