search

AdguardTeam / AdguardBrowserExtension

AdGuard browser extension
https://adguard.com/
GNU General Public License v3.0
2.96k stars 322 forks source link

Basic URL rule, which contains domain name, blocks WS #528

Closed Alex-302 closed 7 years ago

Alex-302 commented 7 years ago

For example - player, which uses WS, is blocked by /flirt4free. WS address: ws://chat004.vs3.com:42121/chat?token=QldcTF5JZw== Maybe that's because some wide rules like that blocks: ws://adguardwebsocket.check /domain. com

ameshkov commented 7 years ago

I guess if we want it to work similarly to other ad blockers, we should remove domain name from the adguardwebsocket.check url.

Mizzick commented 7 years ago

But I think it's very useful now, why do we have to remove this?

ameshkov commented 7 years ago

It'd be better if AG rules syntax is compatible with all other ad blockers, just to let us all use the same filters.

atropnikov commented 7 years ago

We could find matching rule only with $websocket modifier. But for this, we have to while rule parsing try to detect 'websocket' rules, like |ws://$domain=4shared.com

Mizzick commented 7 years ago

I do not understand you. So we have the rule /flirt4free, which blocks websocket request from the player. It's correct, isn't it?

atropnikov commented 7 years ago

No, this rule shouldn't block websocket request.

Mizzick commented 7 years ago

Please provide a clear example? How to reproduce this, @Alex-302 ?

atropnikov commented 7 years ago

Open http://www.flirt4free.com/, disable English filter. Add /flirt4free. rule. Expected: URL ws://adguardwebsocket.check/flirt4free.com is NOT blocked Actual: URL ws://adguardwebsocket.check/flirt4free.com is blocked