search

AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.22k stars 638 forks source link

facebook.com #113316

Closed adguard-bot closed 2 years ago

adguard-bot commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.facebook.com/

Comment

Username: @JasonFrovich

Hi you will see the size and position of the school bar on the far right, It barely moves with adguard on.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/g8xZDp5.jpg)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/rigmh2n.jpg)

System configuration

Information value
AdGuard product: AdGuard for Mac v2.7.0.1094 release
Browser: Safari
Stealth mode: disabled
DNS filtering: server: System
filters: https://filters.adtidy.org/mac_v2/filters/15.txt
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Russian,
AdGuard German
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
Other extensions used: None, only adguard
JasonFrovich commented 2 years ago

The website works, but I can't scroll and no new items show up in the feed. So adguard is breaking the FB feed

JasonFrovich commented 2 years ago

It would be nice if the turn off filter option worked, then I would just off individual filters to see if that is the issue.

JasonFrovich commented 2 years ago

I just now reset the app back to the default settings, that didn't help.

BlazDT commented 2 years ago

Please try to install latest nightly, I cannot reproduce issues (though I could not reproduce other facebook.com issues like uploading picture).

https://agrd.io/mac_nightly

Any difference if you disable every filter and DNS protection?

adguard-bot commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.facebook.com/

Comment

Username: @SamiHaua

Está claro, não posso fazer upload de fotos no Facebook, ou Dropbox, ou Vimeo, a menos que desative o AdGuard. Um pena comprei e não posso usar.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/q7htmdx.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/e1gnwMk.png)

System configuration

Information value
AdGuard product: AdGuard for Mac v2.7.0.1094 release
Browser: Safari
Stealth mode: disabled
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base

Language-specific:
AdGuard Russian,
AdGuard German,
AdGuard Spanish/Portuguese
Userscripts: https://userscripts.adtidy.org/release/popup-blocker/2.5/popupblocker.meta.js,
,
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
adguard-bot commented 2 years ago

Issue URL (Anti Adblock Script)

https://www.facebook.com/ads/library/?active_status=all&ad_type=political_and_issue_ads&country=PL&q=%22mata+do+akupresury%22&sort_data%5Bdirection%5D=desc&sort_data%5Bmode%5D=relevancy_monthly_grouped&search_type=keyword_exact_phrase&media_type=all

Comment

Przy włączonym AdGuardzie strona business.facebook.com nie działa poprawnie (część opcji na stronie nie reaguje na kliknięcia), dodatkowo pojawia się komunikat o wykryciu programu blokującego reklamy. Po wyłączeniu AdGuard strona przede wszystkim działa szybciej, po drugie wszystkie opcje działają.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/8n39Uip.png)

System configuration

Information value
AdGuard product: AdGuard for Mac v3.6.17
Browser: Chrome
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (2880),
Block WebRTC,
Hide your Referrer from third-parties
DNS filtering: server: AdGuard DNS
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances,
Fanboy's Annoyances,
Web Annoyances Ultralist,
Adblock Warning Removal List,
I don't care about cookies,
EasyList Cookie List,
Dandelion Sprout's Annoyances List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Other:
Filter unblocking search ads and self-promotion

Language-specific:
AdGuard French,
AdGuard Russian,
AdGuard German,
AdGuard Spanish/Portuguese,
EasyList Czech and Slovak,
EasyList Italy,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
List-KR,
Polish Anti Adblock Filters
Userscripts: AdGuard dla chrome
Other extensions used: Kaspersky
adguard-bot commented 2 years ago

Issue URL (Ads)

https://m.facebook.com/

Comment

Muestra de anuncios en la web de Facebook (nuevo diseño) para móvil, antes con la versión lite web Facebook no salía y tengo la extensión activada y bien configurada, funciona correctamente en otras webs

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/lZ7CNyp.jpg)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/a9rCuh7.jpg)

System configuration

Information value
AdGuard product: AdGuard Browser extension v3.6.17
Browser: Kiwi Browser
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (2880),
Hide your Referrer from third-parties
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList,
Peter Lowe's Blocklist

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
EasyPrivacy

Annoyances:
AdGuard Annoyances,
EasyList Cookie List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Other:
AdGuard DNS,
AdGuard Experimental

Language-specific:
AdGuard Spanish/Portuguese,
EasyList Spanish
Alex-302 commented 2 years ago

@SamiHaua

Está claro, não posso fazer upload de fotos no Facebook, ou Dropbox, ou Vimeo, a menos que desative o AdGuard. Um pena comprei e não posso usar.

Hi. Could you please explain what exactly is broken - existing messages or when you post new?

Alex-302 commented 2 years ago

Przy włączonym AdGuardzie strona business.facebook.com nie działa poprawnie (część opcji na stronie nie reaguje na kliknięcia), dodatkowo pojawia się komunikat o wykryciu programu blokującego reklamy. Po wyłączeniu AdGuard strona przede wszystkim działa szybciej, po drugie wszystkie opcje działają.

Please check without foreign filters.

Alex-302 commented 2 years ago

@BlazDT https://github.com/AdguardTeam/AdguardFilters/issues/113316#issuecomment-1080085330

maybe Publicidad is need to be added to this(and maybe others) rule?

https://github.com/AdguardTeam/AdguardFilters/blob/af93c8dc024ea184852d8a82a969030184d70849/EnglishFilter/sections/general_extensions.txt#L2636

BlazDT commented 2 years ago

Tried with Spanish and Portuguese language options and pricing no ads were shown. Mobile pages do not require JS rule for ads, normal CSS rules are enough. Probably something wrong with Kiwi browser configuration.

BlazDT commented 2 years ago

Got a new interface now for my mobile device where I see Suggested Pages which contains a Sponsored element, but currently unsure how to fix.

Can be reproduced here with User Agent:

Mozilla/5.0 (Linux; Android 12; Pixel 6 Pro (AppleWebKit/537.36 (KHTM, like Gecko) Chrome/99.0.4844.73 Mobile Safari/537.36

I attached a screenshot of code, first/last element shown in code is not part of Suggested part: first-no-suggested-last-end-suggested

Each element is split, so not a single hiding is working. I also have not seen a property element to indicate it. Any idea @AdamWr @zloyden ?

data-action-id is the same for the content I noticed (in above example 32483). "See All Suggested" is ID 32467, "Suggested Page" is ID 32483 and the poster with sponsored is 32477

I fixed the ad in the Menu, but the ones in newsfeed stay.

AdamWr commented 2 years ago

I still have old interface in mobile view even with this User Agent, so no ideas at the moment.

AdamWr commented 2 years ago

I have a new interface now, but I don't see sponsored posts inside a "Suggested Page", like on on your screenshot. I saw something like reported here - https://github.com/AdguardTeam/AdguardFilters/issues/112600#issuecomment-1082453377

In theory these rules should block sponsored posts:

m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"]:has(> div[data-action-id] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/))
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"]:has(> div[data-action-id] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/)) + div[data-mcomponent="MContainer"]
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"]:has(> div[data-action-id] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/)) + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"]
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"]:has(> div[data-action-id] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/)) + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"]
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"]:has(> div[data-action-id] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/)) + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"]

but we will have to add all languages to this part - span:contains(/^(Sponsored)/) and I'm not sure if it works, because after refreshing website few times, I don't see sponsored posts at the moment. I will try to check it later again.

BlazDT commented 2 years ago

In theory yes, but we have to use hardcoding. Currently they are using that text in a single word, but in the past they split each character and also embedded that text into valid non-ads and managed it by visible). Also in newsfeed ext-CSS is slowing down the website, so in the past we used javascript.

AdamWr commented 2 years ago

You can do the same using JavaScript rule, but I think that there is no reason to overcomplicate it and I do not see any slowdowns with extended-CSS rules. If they will start splitting each character then we will need to find another way to fix it, but if it works fine now, then I do not see any reason to not use these rules.

By the way, I still do not see sponsored posts.

adguard-bot commented 2 years ago

Issue URL (Ads)

http://facebook.com

Comment

Username: @wijhenke

Since today I receive more ads than post on my Facebook timeline in chrome android. On my Chrome linux desktop all ads are filtered correctly

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/C7U0a1Q.jpg)

System configuration

Information value
Platform: Android 12
AdGuard product: AdGuard for Android v3.6.7 (41)
Browser: Chrome
AdGuard mode: VPN
Filtering quality: High-quality
HTTPS filtering: enabled
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Hide your Referrer from third-parties (),
Hide your Referrer from third-parties
DNS filtering: server: https://dns.adguard.com/dns-query
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Mobile Ads,
EasyList,
AdGuard Base,
Peter Lowe's Blocklist

Privacy:
AdGuard Tracking Protection,
Fanboy's Anti-Facebook List

Social Widgets:
AdGuard Social Media,
Fanboy's Social Blocking List

Annoyances:
Adblock Warning Removal List,
AdGuard Annoyances,
I don't care about cookies,
Web Annoyances Ultralist,
Dandelion Sprout's Annoyances List,
Fanboy's Annoyances

Security:
NoCoin Filter List,
Online Malicious URL Blocklist

Other:
Filter unblocking search ads and self-promotion,
AdGuard DNS,
AdGuard Experimental

Language-specific:
AdGuard Dutch
Userscripts: https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js,
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
Other extensions used: None
BlazDT commented 2 years ago

Had to modify it a bit since ads were not hidden (also removed the ext-CSS to one):

m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"]:has(> div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/))
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"][style*="display: none !important;"] + div[data-mcomponent="MContainer"]
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"][style*="display: none !important;"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"]
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"][style*="display: none !important;"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"]
m.facebook.com#?#div[data-mcomponent="MContainer"] > div[data-mcomponent="MContainer"][style*="display: none !important;"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"] + div[data-mcomponent="MContainer"]

@AdamWr should we leave the additional ext-CSS in for safety? Facebook could add some fake styles to hide real content.

Lagginess while scrolling seems to be gone with ext-CSS with this new interface.

AdamWr commented 2 years ago

should we leave the additional ext-CSS in for safety?

@BlazDT What do you exactly mean by additional ext-CSS? If you mean this part:

:has(> div[data-action-id] > div[data-mcomponent="MContainer"] > div[data-mcomponent="TextArea"] > .native-text > span:contains(/^(Sponsored)/))

in every rule, then I think it's not necessary if these rules hide only sponsored content.

BlazDT commented 2 years ago

Added mentioned rules to Mobile filter, currently checking different language, but ad is not always showing :(

BlazDT commented 2 years ago

Added all languages now. Had to modify rule a bit due to a) different selector for Asian/Arabic languages and b) language עברית contains a sign at the start/end which regexp does not like).

robw-nl commented 2 years ago

Hi guys, I'm not yet familiar with these script but I'd like to add them too. Where can I find the updated ones?

BlazDT commented 2 years ago

In Mobile Ads filter. On my Android they are working fine, also on Mobile view on my Desktop.

robw-nl commented 2 years ago

I mean the filter rules that I have to import there. Thanks, Rob

BlazDT commented 2 years ago

You don't have to when you subscribe to mobile ads filter

robw-nl commented 2 years ago

Got it. I thought it was an additional set of rules was discussed until the filters were updated :}

On Sun, 17 Apr 2022, 10:32 BlazDT, @.***> wrote:

You don't have to when you subscribe to mobile ads filter

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardFilters/issues/113316#issuecomment-1100831410, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANPNT637XUN3XDVQ5KGSUQLVFPEDDANCNFSM5RESAILQ . You are receiving this because you were mentioned.Message ID: @.***>