AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.24k stars 639 forks source link

www.mein-schoener-garten.de #123883

Closed adguard-bot closed 2 years ago

adguard-bot commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.mein-schoener-garten.de/pflanzen/alpenveilchen/zimmer-alpenveilchen

Comment

Username: @Morku

Can't scroll with AG Annoyance filter

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/Uvdl8Ep.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/gVnx3lv.png)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.10.1
Browser: Firefox
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests
DNS filtering: server: AdGuard DNS Non-filtering
filters: AdGuard Home with AdGuard DNS filter
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard German
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js
adguard-bot commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.mein-schoener-garten.de/bienen

Comment

Username: @andy-kl

can't scroll the page

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/vwEec6C.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/vwEec6C.png)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.10.1
Browser: Chrome
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Block third-party Authorization header,
Self-destructing third-party cookies (1),
Disable cache for third-party requests,
Block Push API,
Block Location API,
Block Flash,
Block Java,
Hide your Referrer from third-parties (20.191.45.212)
DNS filtering: server: sdns://AQIAAAAAAAAAFDE3Ni4xMDMuMTMwLjEzMDo1NDQzINErR_JS3PLCu_iZEIbq95zkSV2LFsigxDIuUso_OQhzIjIuZG5zY3J5cHQuZGVmYXVsdC5uczEuYWRndWFyZC5jb20
filters: https://filters.adtidy.org/windows/filters/15.txt, User rules
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
Fanboy's Anti-Facebook List,
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
Adblock Warning Removal List,
AdGuard Annoyances

Security:
NoCoin Filter List

Other:
AdGuard Experimental

Language-specific:
EasyList Italy,
AdGuard Russian,
AdGuard German,
AdGuard Spanish/Portuguese
Userscripts: https://userscripts.adtidy.org/release/assistant/4.3/assistant.user.js,
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js,
https://userscripts.adtidy.org/release/popup-blocker/2.5/popupblocker.user.js
Referrer: 20.191.45.212
Sergey-Lyapin commented 2 years ago

I was not able to reproduce this issue. @AdguardTeam/filters-maintainers please take a look

BlazDT commented 2 years ago

Same, not seeing a popup which could lock scolling without AdGuard too. Please show screenshot of code (html and body) @Morku

Morku commented 2 years ago

@BlazDT https://gist.github.com/Morku/c7645d1bcc599a42cb2b46daa1225789

Did you try with Windows application instead of Extension?

grafik

BlazDT commented 2 years ago

I tried both individually. I see our style is applied as it should be from this rule: mein-schoener-garten.de#$?#.sp-message-open { overflow: auto !important; position: static !important; margin-top: 0 !important; }

Could you please try this rule:

mein-schoener-garten.de#$?#.sp-message-open body { overflow: auto !important; position: static !important; margin-top: 0 !important; }

Morku commented 2 years ago

@BlazDT Yes, it's working fine with body in filter. Probably an App thing again.

BlazDT commented 2 years ago

Added, somehow the domain was missing from 2nd rule which is normally required.

adguard-bot commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.mein-schoener-garten.de/pflanzen/kalanchoe/flammendes-kaethchen#wuchs

Comment

Username: @Morku

The bottom content is blocked as long I have AG Base filter active. The page loading seems to be a little glitchy in general.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/H33Pnou.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/V56SfPw.png)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.10.1
Browser: Firefox
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests
DNS filtering: server: AdGuard DNS Non-filtering
filters: AdGuard Home with AdGuard DNS filter
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard German
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js
Alex-302 commented 2 years ago

Not reproduced.

adguard-bot commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.mein-schoener-garten.de/pflanzen/kalanchoe/flammendes-kaethchen#wuchs

Comment

Username: @Morku

The issue is the same. I need to disable Base filter to get whole page loaded. I have the issue only with Firefox (AgfW and Extension). If I use a Chromium based browser (Brave, Edge), it's loaded properly.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/WbczvQb.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/g9Ht9OE.png)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.10.1
Browser: Firefox
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests
DNS filtering: server: AdGuard DNS Non-filtering
filters: AdGuard Home with AdGuard DNS filter
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard German
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js
BlazDT commented 2 years ago

Could you please show dev tools of #paragraph-wrapper-377116 - thank you (especially Styles options).

Morku commented 2 years ago

@BlazDT Like that?

Screenshot-1: ![garten](https://user-images.githubusercontent.com/6276915/179943502-7d312f7d-19c0-4b96-819a-1096499409a6.png)

When loading the page, you shortly get a view of the content before it gets hidden.
BlazDT commented 2 years ago

Please show html and body, thank you. Nothing suspicious shown in the screenshot. Did not find something useful in css files at first. When you expand #paragraph-wrapper-377116 you see the text "Herkunft" ?

With manual blocking urls I also cannot reproduce (only 1 CSS file not blocked, else it would look even worse than in screenshot).

Morku commented 2 years ago

Yes.

Screenshot-1: ![garten2](https://user-images.githubusercontent.com/6276915/179948539-0103059c-3630-4d28-a6ba-40cd483fb433.png)

Screenshot-2: ![grafik](https://user-images.githubusercontent.com/6276915/179948763-fab27f85-d465-4053-a5e9-c2310329d58e.png)

https://gist.github.com/Morku/066dd535b7c3b807a9776d85a59b3ec5 Strangely, when I wait like 20-30 seconds it MAY appear. But also disappear again when scrolling around. When testing around, I can't say for sure, it's cause by Base filter. I can't reliable reproduce by disable filter one by one. But what works for sure 100% is disableing AG entirely. Whats also may be interesting, the issue is only with the "Flammendes Käthchen" page. The https://www.mein-schoener-garten.de/pflanzen/alpenveilchen/zimmer-alpenveilchen always works fine with AG and Firefox.
BlazDT commented 2 years ago

Strange thing is you still have .sp-message-open in code. Normally it gets removed after auto-click rule. Could you please try to remove the class manually and check if it shows up fine then.

When I paste the code from your github link it shows up fine.

Morku commented 2 years ago

Not sure if doing right, so I made a video.

https://user-images.githubusercontent.com/6276915/179956669-49211fd5-bb55-41a2-ba70-6d3e3b8cb99f.mp4

Firefox randomly shows the content, but also hide it with some user action, like opening dev tools, or remove a class. Scrolling around and the other class are gone again. When I disable (second part of video) AG, I am unable to reproduce it. Content is solid.

BlazDT commented 2 years ago

For testing please try this rule:

||cdn.privacy-mgmt.com/wrapperMessagingWithoutDetection.js$domain=mein-schoener-garten.de,important

Morku commented 2 years ago

It might be just bad page layout in combination with Firefox at all.

Resizing the window affects if it is displayed or not. It also happen without AdGuard. Still, the difference is, when I scroll up and down, with AG = it doesn't recover, without AG = it recovers. It's really strange, I don't know.

https://user-images.githubusercontent.com/6276915/179963299-a3da3e15-8e6d-4a4d-9f78-529c48cea4f5.mp4

Morku commented 2 years ago

@BlazDT Doesn't make a change in behaviour with AG when adding ||cdn.privacy-mgmt.com/wrapperMessagingWithoutDetection.js$domain=mein-schoener-garten.de,important

BlazDT commented 2 years ago

So it does not depend on source-point (which results in the mentioned class name not to be present). Will check this evening when on my other device, hopefully I can reproduce.

To summarize: Hidden elements are present in code, do not have display: none. Visiblity: hidden would result the boxes to have the same size (same for any filter: blur)

I guess it also happens when only Base filter and German filter are enabled (with Stealth and DNS disabled).

zloyden commented 2 years ago

@BlazDT I was able to reproduce this once without AdGuard. For some reason they hide this content. This rule helps me in normal view mein-schoener-garten.de#%#//scriptlet('prevent-addEventListener', 'scroll', 'return"undefined"!=typeof')

zloyden commented 2 years ago

@Morku please also take a look at the rule above. By the way, it's the behavior of the site.

Morku commented 2 years ago

@zloyden I can agree that your rule improves the loading with Firefox a lot. Without the rule, the content is not loaded, but may load when resizing window or open dev tool (what the average user won't of course).

With your rule, the content is displayed directly without issue (like AdGuard is disabled). But yes, as already figured out, the page itself is glitchy if still resizing and all.

zloyden commented 2 years ago

Added the rule to AdGuard Annoyances, but it's better to contact to the owner of the site.

Andy-Kl commented 2 years ago

Off Topic

@Morku

2022-07-20_11-59-54.mp4

Wie hast du das MP4-Video in deinen Beitrag eingebunden, so dass man das Video direkt wiedergeben kann?

Morku commented 2 years ago

@Andy-Kl GitHub unterstützt seit 1 1/2 das uploaden von Video im MP4 und Mov Format: https://github.blog/changelog/2020-12-16-video-upload-public-beta/ Am Ende lädst du das genauso hoch, wie ein Foto. Drag&Drop im Textfeld. Aufzeichnen tu ich mit OBS. Encoden mit VirtualDub2 (um auch hier und da Schnitte zu setzen oder Auflösung zu ändern). Am Ende tun es auch jedes andere Tool, wie Avidemux, Handbrake, Xmedia Recode usw. Für die höchste Kompatibilität nehme ich als Encoder h.264 (x264) mit einem crf Wert 36 (extrem starke Komprimierung), damit die Datei besonders klein wird. Reicht, um etwas zu zeigen vollkommen aus. Je höher der Wert, desto kleiner die Datei. Ton lasse ich logischerweise weg.

EDIT: bzw. kannst du auch mit OBS direkt eine starke Komprimierung einstellen, aber je nach PC Performance sollte man als x264 Profil super fast, fast oder medium auswählen.

Andy-Kl commented 2 years ago

@Morku

Am Ende lädst du das genauso hoch, wie ein Foto. Drag&Drop im Textfeld.

so mache ich das auch, aber bei mir sieht das dann so aus: https://github.com/AdguardTeam/AdguardFilters/issues/124972#issuecomment-1191541251 Dein Video jedoch kann ich direkt im Fenster wiedergeben, meines will heruntergeladen werden. Deswegen dachte ich ja das es einen bestimmten Code (ähnlich bbcode?) geben würde mit dem man Videos einbinden kann/muss

Mir ging es nicht darum wie man ein Video/Screencast erstellt - sondern wie man es hier in einen Beitrag einfügt

PS zum Aufzeichnen verwende ich: ScreenToGif Screen, webcam and sketchboard recorder with an integrated editor https://www.screentogif.com

Morku commented 2 years ago

@Andy-Kl Merkwürdig. Am Video scheint es nicht zu liegen. Ich kann dein Video ganz normal durch rein ziehen hochladen und die Preview bestätigt mir eine Embedded Wiedergabe (einzigen Unterschied den ich zu meinen OBS Aufnahmen sehe ist Variable<->Constant Framrate). Vielleicht eine OS/Browser Sache, wie man GitHub nutzt? (bei mir W11/Firefox) Das es eine Profileinstellung wäre, ist mir nicht bekannt.

https://user-images.githubusercontent.com/6276915/180273926-ee0e8e6e-95f6-415e-808a-afe9429e5583.mp4

ScreenToGif videotest:

https://user-images.githubusercontent.com/6276915/180273978-b29294de-37cb-4e6c-b84c-14ef41f7f626.mp4

Andy-Kl commented 2 years ago

ahh - der Klick auf "Preview" bettet wohl erst das Video ein

Test:

https://user-images.githubusercontent.com/8377249/180276569-4b2a90ba-bda3-44cd-831a-7554168454fd.mp4

Morku commented 2 years ago

Eigentlich nicht ^^' Aber scheint ja jetzt zu klappen.