AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.22k stars 638 forks source link

www.pcgamer.com #128579

Closed adguard-bot closed 2 years ago

adguard-bot commented 2 years ago

Issue URL (Ads)

https://www.pcgamer.com/best-gaming-monitor/

Comment

page full of affiliate

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/5ipv01j.png)

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.22
Browser: Firefox
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Other Annoyances

Language-specific:
AdGuard Russian
adguard-bot commented 2 years ago

Issue URL (Annoyance)

https://www.pcgamer.com/uk/

Comment

Stop whitelisting this type of popups please. More info on this reddit thread https://www.reddit.com/r/uBlockOrigin/comments/x33sag/adguard_annoyances_interferes_with_fanboys/

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/GgzFn5T.png)

System configuration

Information value
Platform: AdGuard Annoyances Filter List
Browser: Firefox
Filters: Annoyances:
AdGuard Cookie Notices
Other extensions used: uBlock Origin
AdamWr commented 2 years ago

https://github.com/AdguardTeam/AdguardFilters/issues/128579#issuecomment-1235082464

Stop whitelisting this type of popups please

Sometimes websites requires to unblock/accept cookie notice to works properly. In this particular case, video player doesn't work if cookie notice is blocked, related to this issue - https://github.com/AdguardTeam/AdguardFilters/issues/74868#issue-807926507

Kobi-Blade commented 2 years ago

Sometimes websites requires to unblock/accept cookie notice to works properly. In this particular case, video player doesn't work if cookie notice is blocked, related to this issue - #74868 (comment)

As stated stop whitelisting annoyances, video sources work perfectly fine even with this popup blocked, only built-in ad videos that do not work (but they aren't supposed to work anyway, cause they ads).

Proper videos from sources like Youtube and Twitch are working perfectly fine on that webpage when blocking the popup.

This is a recurring and annoying issue, and honestly at this point I making my own rule, one must question what is the point of the annoyances filter, when rules are removed to allow video ads (when Adguard is supposed to block ads anyway).

This is evidence videos works just fine while blocking that popup, Untitled

At least now I know why the Annoyances filter has been crap the last few years, Imma be sending a mail to Adguard about this.

Fix this, https://github.com/AdguardTeam/AdguardFilters/issues/131340

AdamWr commented 2 years ago

The video from this issue - https://github.com/AdguardTeam/AdguardFilters/issues/74868#issue-807926507 is related to content, so it shouldn't be blocked and if cookie notice is blocked then it doesn't work.

Screenshot when cookie notice is blocked ![image](https://user-images.githubusercontent.com/29142494/193813073-0d2704db-d8eb-4ae6-9a15-bbd6e6b479ef.png)
Screenshot when cookie notice is closed ![image](https://user-images.githubusercontent.com/29142494/193813084-96b7fbcd-c244-49fa-8abf-9efe22166cf7.png)

We unblock cookie notice only if it breaks website or causes that some website's functionalities do not work and then we are adding rules which automatically close cookie notice. In this case it's automatically closed on my side.

Kobi-Blade commented 2 years ago

That is pretty much their built-in player that is packed with ads and barely any useful information, I was talking about. The videos that are important are hosted on Youtube and Twitch.

We even had a rule to remove those videos a few years ago, I assume is also your doing those videos are back.

When you close the popup, you pretty much accepting all the tracking that comes with it, so yes, is entirely different from blocking.

As stated, I already redirected a mail to Adguard about this, and already applied my own filter as well, since Adguard Annoyances filter is useless.

For anyone else who doesn't want annoyances and video ads on PC Gamer, just apply this rules to your user filters, pcgamer.com###qc-cmp2-main pcgamer.com###article-body > div.jwplayer__widthsetter

AdamWr commented 2 years ago

That is pretty much their built-in player that is packed with ads and barely any useful information, I was talking about.

I think that it doesn't matter if it's their video player or not, because as I said it's related to content, this is Red Dead Redemption 2 review and these videos are gameplays from this game, so might be useful for some users. YouTube and Twitch players contains ads too, it doesn't mean that those players should be blocked.

When you close the popup, you pretty much accepting all the tracking that comes with it, so yes, is entirely different from blocking.

It's a different thing not related to Annoyances filter, trackers are still blocked by Tracking Protection filter and we don't want to break websites. If user will notice that video player doesn't work and she/he will want to watch it then she/he will just disable an ad blocker, what is worst than automatically closed cookie notice (it's impossible to make everyone happy).

AdamWr commented 2 years ago

By the way, additionally you can also add:

||quantcast.mgr.consensu.org^$domain=pcgamer.com,important

to user rules, it should overrides exception and block script with cookie notice (clearing cache or refreshing website by using Ctrl+F5 might be required).