AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.17k stars 631 forks source link

www.promipool.de #136684

Closed adguard-bot closed 1 year ago

adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.promipool.de/stars/die-unglaubliche-verwandlung-von-jeannine-michaelsen

Comment

Username: @Morku

1-2: Video is blocked due Annoyance filter 3: Ad placeholder on right side 4: Ad placeholder in article with iPhone and Android

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/GH1rdfM.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/QCyYW8a.png)
Screenshot 3 ![Screenshot 3](https://reports-img.adguard.com/8cQ0nl2.png)
Screenshot 4 ![Screenshot 4](https://reports-img.adguard.com/4rzmoN5.jpg)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.11.3
Browser: Firefox
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests
DNS filtering: server: AdGuard DNS Non-filtering
filters: AdGuard Home with AdGuard DNS filter
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard German
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js
Morku commented 1 year ago

@zloyden

How about the placeholder on mobile? in-content-ad-wrapper

The page seems to have a different result regarding to AG product.

With AdGuard for Windows (Firefox/Chromium) = everything is fine

With AdGuard Extension + Chromium = Cookie Pop-up returned due unblock cdn.opencmp.net

Screenshot: ![promi6](https://user-images.githubusercontent.com/6276915/205602177-459eada9-1043-4837-93b7-24ea579f38ec.png)

With AdGuard Extension + Firefox = Cookie Pop-up returned and it also has the Article placeholder
Screenshot: ![promi5](https://user-images.githubusercontent.com/6276915/205602308-32a91d09-bd34-46cf-8ec2-a8e349f9d846.png)

AdGuard for iOS and AdGuard for Android = Cookie Pop-up and also Article Ad placeholder
zloyden commented 1 year ago

How about the placeholder on mobile? in-content-ad-wrapper

This rule wasn't in the optimized filter, but it will be in 1-2 hours there.

unblock cdn.opencmp.net

It's under shadowRoot(closed), so I doubt it can be hidden. @AdamWr @BlazDT what do you think about it?

BlazDT commented 1 year ago

I tried this rule which removes it, scrolling works and the video plays too, please check @Morku

promipool.de#%#AG_onLoad(function(){setTimeout(function(){if(!document.cookie.includes("trf-euconsent-v2")){var g=new MutationObserver(function(){var b=document.querySelector('body > #page ~ div:not([class]):not([id])');b&&(g.disconnect(),b.remove())});g.observe(document,{childList:!0,subtree:!0});setTimeout(function(){g.disconnect()},1E4)}},500);});

Morku commented 1 year ago

@BlazDT Autoclicking works fine with AG Extension (Firefox, Chrome) and AdGuard for iOS (after reloading page since the Extension is sluggish...)

I wonder how optimized filter will have an affect on AdGuard Extension + Firefox for the Ad placeholder. Optimized is not enabled.

grafik

zloyden commented 1 year ago

@BlazDT it works fine on my end, but what if just block it? I don't see any problem with the rule below.

promipool.de##body > #page ~ div:not([class]):not([id])
AdamWr commented 1 year ago

If I'm not wrong, extensions can hide elements in closed shadowRoot, so this should works:

promipool.de###consentDialog

For apps something like this should be fine:

promipool.de#%#(()=>{window.Element.prototype.attachShadow=new Proxy(window.Element.prototype.attachShadow,{apply:(a,b,c)=>{const d=Reflect.apply(a,b,c),e=new CSSStyleSheet;return e.insertRule("#consentDialog { display: none !important; }"),d.adoptedStyleSheets=[e],d}})})();
Code: ```js (() => { const wrapper = (target, thisArg, args) => { const shadowEl = Reflect.apply(target, thisArg, args); const stylesheet = new CSSStyleSheet(); stylesheet.insertRule('#consentDialog { display: none !important; }'); shadowEl.adoptedStyleSheets = [stylesheet]; return shadowEl; }; const handler = { apply: wrapper }; window.Element.prototype.attachShadow = new Proxy(window.Element.prototype.attachShadow, handler); })(); ```
AdamWr commented 1 year ago

If promipool.de##body > #page ~ div:not([class]):not([id]) works fine then I think that it could be added.

zloyden commented 1 year ago

@AdamWr I added it, but your rules also work fine on my side. Could you add them?

AdamWr commented 1 year ago

I think that additional rules are not needed if promipool.de##body > #page ~ div:not([class]):not([id]) works fine.

Morku commented 1 year ago

From all provided rules, promipool.de##body > #page ~ div:not([class]):not([id]) works best on iPhone. Other rules always had to need to reload, to glitch out the Extension.

I still wonder whats going on with AG Extension and Firefox. When I add promipool.de##.in-content-ad-wrapper in userfilter, the placeholder is blocked. Optimized filters aren't enabled.

zloyden commented 1 year ago

Yep, it does. Ok, thank you all :)

I still wonder whats going on with AG Extension and Firefox. When I add promipool.de##.in-content-ad-wrapper in userfilter, the placeholder is blocked. Optimized filters aren't enabled.

That's kinda strange. I see that the rule ##.in-content-ad-wrapper applies on the page (AdGuard for Firefox).

Morku commented 1 year ago

@zloyden It does not!

Screenshot-1: ![Promi7](https://user-images.githubusercontent.com/6276915/205622457-9b6b50cb-a944-49fe-8614-b2a7b3230fdd.png)

zloyden commented 1 year ago

@Morku looks like the exception rule hasn't been applying for some time on my end, but I've removed it. Check the filter update in 1-2 hours.