AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.22k stars 638 forks source link

youtube.com: URL tracking #142820

Closed MasterKia closed 1 year ago

MasterKia commented 1 year ago

Prerequisites

What product do you use?

Other ad blocker

AdGuard version

.

What type of problem have you encountered?

Missed analytics or tracker

Which browser(s) do you use?

Firefox

Which device do you use?

Desktop

Where is the problem encountered?

https://www.youtube.com/watch?v=pAZWv8QQ8Co

What filters do you have enabled?

AdGuard URL Tracking filter

What Stealth Mode options do you have enabled?

No response

Add your comment and screenshots

YouTube's description links have tracking parameters.

Example: https://www.youtube.com/watch?v=pAZWv8QQ8Co

In the description: https://www.youtube.com/redirect?event=video_description&redir_token=[...]&q=https%3A%2F%2Fwww.paypal.me%2Fpaysyfr&v=pAZWv8QQ8Co

event, redir_token, q being the destination link and v being the video id.

Proposed filters for AdGuard URL Tracking Protection:

||youtube.com/redirect?$removeparam=event
||youtube.com/redirect?$removeparam=redir_token
||youtube.com/redirect?$removeparam=v

Result link: https://www.youtube.com/redirect?q=https%3A%2F%2Fwww.paypal.me%2Fpaysyfr

Privacy

krystian3w commented 1 year ago

Maybe good for only My Filters Tab or User Rules (.../pages/options.html#user-filter) tab/Filter (apps may have list named as Filter - similar to legacy interface of ABP) due links will always ask to confirm redirect.

MasterKia commented 1 year ago

links will always ask to confirm redirect.

It's better than YouTube tracking which external links the user has clicked on (v parameter for video id).

krystian3w commented 1 year ago

Worse if every day people start complaining and "you" have to paste them a link to the solution:

  • disable Filter "URL tracking" or
  • add this to AdGuard's own rules / my filters in uBO:
    ||youtube.com/redirect?$removeparam=event,badfilter
    ||youtube.com/redirect?$removeparam=redir_token,badfilter
    ||youtube.com/redirect?$removeparam=v,badfilter

These clicker can be used in scams:

[path="/redirect?q="]www.youtube.com#%#//scriptlet('trusted-click-element', '#invalid-token-redirect-goto-site-button', '', '500')
MasterKia commented 1 year ago

[path="/redirect?q="]www.youtube.com#%#//scriptlet('trusted-click-element', '#invalid-token-redirect-goto-site-button', '', '500')

Trusted filters are only controlled by the AdGuard team or My filters or user trusted filterlists.

krystian3w commented 1 year ago

But for a while the link will be automatically clicked in someone.

Maintaining in regex a list of domains where clicking looks OK may not be possible (especially when the line exceeds the limit of allowed characters per filter rule e.g. 65 kilibytes).

AdamWr commented 1 year ago

I'm not sure if these rules should be added as it causes that there is necessary to confirm redirection. There was issue about confirming redirection (caused by $cookie rule) here - https://github.com/AdguardTeam/AdguardFilters/issues/128041#issuecomment-1229174825 and related comment - https://github.com/AdguardTeam/AdguardFilters/issues/128041#issuecomment-1237773494 (and comments below). So I guess that it's not user friendly and there will be similar reports.

@Alex-302 Could you please take a look at this issue when you come back from vacation?

Alex-302 commented 1 year ago

I'm not sure if these rules should be added as it causes that there is necessary to confirm redirection.

This is annoying behavior. The rule is for user filter only.

MasterKia commented 1 year ago

So AdGuard doesn't block any click-tracker links too just in case some users get upset? So much for "AdGuard Tracking protection" list.

Alex-302 commented 1 year ago

You will be tracked by Google in any case.