AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.17k stars 631 forks source link

Etsy Cosmetic Filtering with Ublock #149330

Closed Anvillior closed 1 year ago

Anvillior commented 1 year ago

Prerequisites

What product do you use?

Other ad blocker

AdGuard version

Filter

What type of problem have you encountered?

Missed ads or ad leftovers

Which browser(s) do you use?

Chrome

Which device do you use?

Desktop

Where is the problem encountered?

https://www.etsy.com/search?q=anime%20pins&ref=search_bar

What filters do you have enabled?

AdGuard Base filter

What Stealth Mode options do you have enabled?

No response

Add your comment and screenshots

  1. div[data-behat-search-results-lg] .listing-link.logged:not([data-shop-id]) seems to make it block search results, but not ads.

  2. Screenshots

    Screenshot 1:

https://imgur.com/a/GTyT936

Privacy

BlazDT commented 1 year ago

Removed problematic rule. Ad removable not so easy without JS due to "fake" ads which are hidden via transform css. @AdamWr please check.

AdamWr commented 1 year ago

As far as I understand, it's related to - https://github.com/AdguardTeam/AdguardFilters/issues/148111#issuecomment-1513134079 (I mean "ads").

Just items, promoted by sellers. We should not remove them from results. They are not duplicated.

BlazDT commented 1 year ago

If a seller pays extra to have a higher visibility, they are ads and should be removed.

AdamWr commented 1 year ago

This rule seems to works fine on my end:

etsy.com#?#div[data-search-results] .wt-list-unstyled .wt-text-caption > span[class]:contains(/Ad[\s\S].*by Etsy seller/):matches-css(display: inline-block):upward(.wt-list-unstyled)

but I'm not sure if it should be added - https://github.com/AdguardTeam/AdguardFilters/issues/148111#issuecomment-1513134079 @Alex-302 Could you please take a look?

BlazDT commented 1 year ago

The text is localized though.

Alex-302 commented 1 year ago

If a seller pays extra to have a higher visibility, they are ads and should be removed.

No. You will remove a part of items. OLX has same feature, and promoted items may be useful if you want to byu for example a used device. "Promoted" is not equal to "higher price".