AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.2k stars 638 forks source link

www.chip.de #158944

Closed adguard-bot closed 1 year ago

adguard-bot commented 1 year ago

Issue URL (Ads)

https://www.chip.de/downloads/IObit-Unlocker_51304878.html

Comment

Username: @andy-kl

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/h0jjv1or8ug4gooog00cc488cgwkg4k1tdtgh5vp09.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/raizcxb8vpws8c0so4scsgssco8wkgstlzrw1120i8.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.14
Browser: Chrome
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Block third-party Authorization header,
Self-destructing third-party cookies (0),
Disable cache for third-party requests,
Block WebRTC,
Block Push API,
Block Location API,
Block Flash,
Hide your Referrer from third-parties (66.249.66.67)
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
Fanboy's Anti-Facebook List,
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
Adblock Warning Removal List,
AdGuard Annoyances

Security:
NoCoin Filter List

Other:
AdGuard Experimental

Language-specific:
EasyList Italy,
AdBlockID,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
List-KR,
Persian Blocker,
Polish Anti Adblock Filters,
IndianList,
AdGuard German,
AdGuard Japanese
Custom filters: https://pastebin.com/raw/Gbxy8nby,
https://pastebin.com/raw/yLbW1zkH
Userscripts: https://userscripts.adtidy.org/release/assistant/4.3/assistant.user.js,
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js,
https://userscripts.adtidy.org/release/popup-blocker/2.5/popupblocker.user.js
Referrer: 66.249.66.67
adguard-bot commented 1 year ago

Issue URL (Ads)

https://www.chip.de/download/

Comment

Username: @Morku

Ad placeholder on top on all download subpages

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/6x7owp7cr3wgsscs8g8c4c0o444ko8k4vk85bs44ww.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/c3vkmp9vd5sk40csk40wok4g4s4c88wpiflspua46o.png?nc=1)
Screenshot 3 ![Screenshot 3](https://cdn.adguard.info/sitereports/65dqcqw9oeosccgogooskck0c4ggggob5ej8bai8wo.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.14
Browser: Firefox
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Disable cache for third-party requests
DNS filtering: server: AdGuard DNS Non-filtering
filters: AdGuard Home with AdGuard DNS filter
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard German
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js
Morku commented 1 year ago

@AdamWr Sadly this change doesn't fix for me.

AdamWr commented 1 year ago

It works fine on my end.

Screenshot ![image](https://github.com/AdguardTeam/AdguardFilters/assets/29142494/1ddf1c5c-bae2-4faf-805a-f0e9d8e11020)

Does it work if you add:

chip.de#?#div[class]:has(> a[href*="contentpartnerId"]:only-child img)

to user rules?

AdamWr commented 1 year ago

I was able to reproduce another ad placeholder, but only after accepting cookie notice. I have added:

chip.de###aabhor

Filters update should be available in 1-2 hours.

Morku commented 1 year ago

@AdamWr

Took me a while, but I think I found the reason, because other Firefox profiles and browser don't show the placeholder anymore.

When you go into about:config and search for cookiebanners.service.mode , change the value to 2 (restart browser)

grafik

This option is also for autoclicking Cookie Banners provided by Mozilla, but also in a safe way to not break the page. The question here is now, in which way it interfere with AdGuard.

The cookiebanners.service.mode is also useful for some pages, for example https://www.n-tv.de/ Compared with AdGuard solution, it only shows the Cookie Pop-up one time shortly, while AdGuard needs to extra seconds to autoclick.

Maybe Mozillas solution might be not perfect.

Maybe you can check again the page with that option.

AdamWr commented 1 year ago

Could you please test this rule:

chip.de###aabhor

The cookiebanners.service.mode is also useful for some pages, for example https://www.n-tv.de/ Compared with AdGuard solution, it only shows the Cookie Pop-up one time shortly, while AdGuard needs to extra seconds to autoclick.

I didn't check what exactly Mozilla does, but as far as I can see, in case of n-tv.de, script from AdGuard filters accept/enable only necessary options, it would be probably faster if it would click only on the "Accept all" button.

Morku commented 1 year ago

@AdamWr

It works fine.

It would be disappointing, if Mozilla solution simply Accept all Cookies, because regarding the Blog, the option 2 reject all if possible: https://community.mozilla.org/de/campaigns/firefox-cookie-banner-handling/

AdamWr commented 1 year ago

It was a quick test, so I might be wrong, but it looks like that in the case of n-tv.de Firefox just allow all cookies, otherwise if cookies are rejected then embedded Tweet should not load here - https://www.n-tv.de/politik/Ukraine-Ganze-Familie-bei-Angriff-auf-Cherson-getoetet-article24322805.html but it's loaded on my end (I have set cookiebanners.service.mode to 2 and disabled Tracking protection, because it blocks embedded Tweets).

Morku commented 1 year ago

@AdamWr Thanks for checking. So I might disable cookiebanners.service.mode again :)

JobcenterTycoon commented 1 year ago

The ads are back on my end. They are very aggressive at the moment and monitoring uBO and EL germany to circumvent the filter.

JobcenterTycoon commented 1 year ago

chip.de##a[href*="chip.de/downloads/"] img[src*="hash"] breaking the images on https://www.chip.de/download/9232_Downloads/gesamt-charts/

AdamWr commented 1 year ago

Fixed.

JobcenterTycoon commented 12 months ago

chip.de##a[href*="chip.de/downloads/"] img[src*="hash"] works but its suboptimal because only the image is hidden but the clickable link is still here.

AdamWr commented 12 months ago

Okay, I have added:

chip.de#?#a[href*="chip.de/downloads/"]:has(img[src*="hash"]:not([class], [data-src]))
JobcenterTycoon commented 11 months ago

The ads are back.

AdamWr commented 11 months ago

Fixed, I hope that without incorrect blocking.

JobcenterTycoon commented 11 months ago

Ads are back ...

JobcenterTycoon commented 11 months ago

Good fix! But Firefox is still unfixed.

Morku commented 11 months ago

It's working fine on my Firefox 🤔 (AGfW)

AdamWr commented 11 months ago

It's only about Firefox extension - it cannot update/download new JavaScript rules. It was Friday evening when I have added the rule and it was just easier and faster to check/test JS rule than few other rules which could cause incorrect blocking (these ads images have similar structure like other images). Maybe tomorrow I will add element hiding rules for Firefox extension.