AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.16k stars 632 forks source link

www.reddit.com #159337

Closed adguard-bot closed 1 year ago

adguard-bot commented 1 year ago

Issue URL (Ads)

https://www.reddit.com/

Comment

Tons of "Promotion" posts and videos that are eating up my data/bandwidth on Reddit.com

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/8jjmg3mg5p8gg488osc4s8gcow84sc4k49lebljgy8.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard for Windows v7.14
Browser: Chrome
AdGuard driver: WFP
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Strip URLs from tracking parameters,
Self-destructing third-party cookies (180),
Block Location API
DNS filtering: server: tls://dns.adguard-dns.com
filters: https://filters.adtidy.org/windows/filters/15.txt, User rules
Filters: Ad Blocking:
EasyList,
AdGuard Mobile Ads,
AdGuard Base

Privacy:
EasyPrivacy,
Peter Lowe's Blocklist,
Fanboy's Enhanced Tracking List,
Fanboy's Anti-Facebook List,
Fanboy's Anti-thirdparty Fonts,
Legitimate URL Shortener,
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
Fanboy's Social Blocking List,
AdGuard Social Media

Annoyances:
Fanboy's Annoyances,
Web Annoyances Ultralist,
Adblock Warning Removal List,
I don't care about cookies,
EasyList Cookie List,
Dandelion Sprout's Annoyances List,
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Other:
Filter unblocking search ads and self-promotion,
AdGuard Experimental
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js,
https://userscripts.adtidy.org/release/popup-blocker/2.5/popupblocker.user.js
Other extensions used: None.
BlazDT commented 1 year ago

Not shown, please check @zloyden

zloyden commented 1 year ago

Also not reproduced it on my end.

adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.reddit.com/?rdt=37614

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/jn8m2ob7t0oos0ww8448kcowc8s4s4s531qakgrtro.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/o0ciqjtaiuosoc80csc0ss8cgs04g0soq4hi29zjpc.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.5.0
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard Tracking Protection,
EasyPrivacy,
Fanboy's Enhanced Tracking List

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
Adblock Warning Removal List,
Fanboy's Annoyances,
Web Annoyances Ultralist,
Dandelion Sprout's Annoyances List

Security:
NoCoin Filter List
BlazDT commented 1 year ago

What's broken? First screenshot hidew site's own use app button and promoted posts (top one comes from Safari, not fixable).

adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.reddit.com/

Comment

Username: @airboat-mantrap

Adblock does not work on www.reddit.com with the classic interface enabled anymore. It only seems to work on old.reddit.com

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/r3smrut754go084ssc8888w4ckgc8c0idxlbtbpxe0.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/f9t67an3t68s8w08owgwwgko84cgc4cdum9k4i12d4.png?nc=1)
Screenshot 3 ![Screenshot 3](https://cdn.adguard.info/sitereports/eee9zyc15n48cw4kooosgcck8kscsoc9d6qtnnnl68.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard for Safari v1.11.14
Browser: Safari
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard Tracking Protection

Annoyances:
AdGuard Annoyances,
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
Adblock Warning Removal List,
Fanboy's Annoyances,
Web Annoyances Ultralist,
I don't care about cookies,
Dandelion Sprout's Annoyances List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List
Other extensions used: DuckDuckGO Privacy Essentials
Alex-302 commented 1 year ago

@airboat-mantrap Cannot reproduce with your settings. Please try to disable-enable content blockers in Safari settings and restart Safari, and check for filters update.

adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.reddit.com

Comment

For some time now, Reddit just isn't loading with AdGuard enabled. No such issues with uBlock or Ghostery, but I just like AdGuard way more. It's annoying to click Refresh every time after page already loads just for page to fully load.

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/10pgagl7wbyo8ww8g0ko88ks484k4wkn97xue8hpu8.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/6ze23kgwbz40o4gowcgw0gocw0o008crzeywwyfimo.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.57
Browser: Firefox
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Strip URLs from tracking parameters,
Block WebRTC,
Hide your Referrer from third-parties
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
Legitimate URL Shortener

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances,
Adblock Warning Removal List,
I don't care about cookies

Security:
NoCoin Filter List
Alex-302 commented 1 year ago

Can't reproduce with new or old design. Which filter cuases it?

airboat-mantrap commented 1 year ago

It ended up being that content blockers were set to not load at all on www.reddit.com when I went to Safari > Settings for reddit.com... Once I checked that off, everything was working again.

adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.reddit.com/new/

Comment

Site is not full loading, I need to refresh after visiting to get site fully loaded, with disabled AdGuard site loads normal. Clearing cache and history don't help at all. Looks like faulty filter entry.

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/jihaeioywrkkcw88k4o8s4w4c4k8s0kh01ladprrp4.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/4ed5ns5f68is8kowkcs0wocwo0000wkdc8uqb8gwp4.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.57
Browser: Firefox
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Strip URLs from tracking parameters,
Self-destructing third-party cookies (10),
Block WebRTC,
Hide your Referrer from third-parties
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Annoyances:
AdGuard Annoyances,
I don't care about cookies,
EasyList Cookie List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Language-specific:AdGuard German,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
EasyList Czech and Slovak,
EasyList Germany,
EasyList Italy,
Hungarian,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
Polish GDPR-Cookies Filters,
Polish Anti Adblock Filters,
Frellwit's Swedish Filter,
Dandelion Sprout's Nordic Filters
Alex-302 commented 1 year ago

Site is not full loading, I need to refresh after visiting to get site fully loaded, with disabled AdGuard site loads normal. Clearing cache and history don't help at all. Looks like faulty filter entry.

Please try to update extension. Actual version is 4.2

Also please test without Self-destructing third-party cookies

Xetmes commented 1 year ago

Hello, thanks for Your answer, but I've latest version according to Mozilla Addons Repo.

adguard-bot commented 1 year ago

Issue URL (Ads)

https://www.reddit.com/r/memes/comments/fgbtxh/nokia_stops_kia_from_correcting_the_spelling/

Comment

An ad is shown at the centre of my screenshot.

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/qsy3kmn8ziocwwkowk4c0sgcsc8ogg78qf8acyzo8w.jpg?nc=1)

System configuration

Information value
AdGuard product: AdGuard Content Blocker v2.6.1
Browser: Samsung Browser
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances
Alex-302 commented 1 year ago

An ad is shown at the centre of my screenshot.

App or site? The site is clean on my device. The app cannot be filtered without root access. Try AdGuard for Android from adguard.com, or disable/enable content blocker in browser settings.

adguard-bot commented 1 year ago

Issue URL (Social Widget)

https://www.reddit.com/r/Rainbow6/comments/nwnpkj/how_do_i_make_siege_default_to_launch_in_vulkan/

Comment

Username: @Mekanik97

İğrenç embed butonunu engellemek istiyorum ancak reddit engellemeyi önlüyor olmalı ki embed butonu seçilemiyor. I can't choose embed button

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/6z5fniuib3swww0880wg4k48gs0wwgw24xng8e3egk.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.2.151
Browser: Chrome
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Language-specific:
AdGuard Turkish
adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.reddit.com

Comment

Username: @sprunkwallace

It is specifically the mobile app banners filter and the annoyances filter which contains the mobile app banners filter that causes reddit commenting to break. it also causes the spoiler button to not work properly.

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/2f0vgm9ubp7ow8c8g0g0oso0o4gwsgosec8y0cfw0g.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/amv81xe56u8go4ssws0os0sw0co44g8nn68difnrlw.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard Browser extension v4.1.57
Browser: Firefox
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Strip URLs from tracking parameters,
Self-destructing third-party cookies (2880),
Hide your Referrer from third-parties
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
EasyPrivacy,
Legitimate URL Shortener,
Fanboy's Enhanced Tracking List

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Other Annoyances,
Adblock Warning Removal List,
Web Annoyances Ultralist,
I don't care about cookies

Security:
Online Malicious URL Blocklist,
NoCoin Filter List
Other extensions used: tampermonkey, lastpass, tabliss, return youtube dislike, twp translate web pages, windows defender
BlazDT commented 1 year ago

@sprunkwallace What exactly is not working with spoiler button? Black element is spoiler element. I also do not see any overlay.

image

sprunkwallace commented 1 year ago

that first image? thats the comment box when the specified filters are active. it is stuck in a loading loop, and i cannot interact with it in any way, shape or form. i cannot click it, i cannot type into it, i cannot post comments at all unless i refresh the page first.

the same thing happens when a reddit post has spoilered details. if i do not refresh the page first before interacting with the "show spoilers" button, it does nothing at all.

if it wasnt clear, those pictures are taken in dark mode. image with the filters active, clicking that button is about as useful as clicking on nothing.

BlazDT commented 1 year ago

Please post a link with a spoiler enabled.

sprunkwallace commented 1 year ago

what do you mean post a link with spoiler enabled? thats a screenshot of the reddit spoiler button on dark mode. do you want me to post a reddit link that has a spoiler? here https://www.reddit.com/r/BaldursGate3/comments/vdsdlc/all_the_ways_to_boost_ability_scores_in_bg3_ea/

i feel like there is a failure in communication here. the mobile app banner filter, when enabled, interferes with reddit's ability to let you post comments, disables the comment overlay, and prevents you from being able to view spoilered text and images.

BlazDT commented 1 year ago

Sadly I still cannot reproduce :( You can check filtering log which rule is applied from Mobile app filter (if you do not want to try the big list below).

@zloyden @AdamWr can you please check, thank you.

Meanwhile you can try these rules (those are only applied when I visit the page):

reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#body:not(.with-listing-chooser) { overflow: visible !important; position: static !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@%#//scriptlet('remove-class', 'scroll-disabled', 'body')
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@%#//scriptlet('remove-class', 'm-blurred', '.m-blurred')
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@%#//scriptlet('prevent-addEventListener', 'block-body-scrolling')

If not working, please add these rules:

reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@?#@#nsfw-qr-dialog:contains(Scan this QR code to download the app now)
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#shreddit-app > div.sidebar-grid.pdp { filter: unset !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@#.mobile-web-redirect-bar
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#body { pointer-events: auto !important; overflow: auto !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@#shreddit-async-loader[bundlename="bottom_bar_xpromo"]
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#shreddit-experience-tree { display: none !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#.theme-beta .sidebar-grid.fixed { position: unset !important;}
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@?#.XPromoPopup.m-active
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@?#.XPromoPopupRpl.m-active
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#body.scroll-is-blocked { overflow: auto !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@?#@#AppRouter-main-content > div[class] > div[class^="_"]:has(> div[class^="_"] > img[alt="QR Code to get the Reddit app"])
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#.m-blurred { filter: none !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#.XPromoBlockingModal { display: none !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#.XPromoBlockingModalRpl { display: none !important; }
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@?#div[class^="_"] > button[class*=" "]:has(> i.icon-qr_code)
reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@$#div[class="NavFrame"] div.XPromoBottomBar { display: none !important; }

If working then, please remove one rule, check and if still working, remove the next rule.

AdamWr commented 1 year ago

Click to see spoiler/View spoiler button works fine on my end with AdGuard Annoyances/AdGuard Mobile App Banners filter enabled.

sprunkwallace commented 1 year ago

filtering rule wont work, as in order to check the log, it requires that you reload the page, which means that the bug causing reddit to break doesnt show up

sprunkwallace commented 1 year ago

it also breaks commenting overlay on my end, preventing commenting without refreshing

sprunkwallace commented 1 year ago

reddit.com,reddittorjg6rue252oqsxryoxengawnmo46qy4kyii5wtqnwfj4ooad.onion#@?#div[class^="_"] > button[class*=" "]:has(> i.icon-qr_code) whatever this user rule is, its one of the culprits

sprunkwallace commented 1 year ago

without that rule, and without the mobile app banner rules enabled, the site works as normally

BlazDT commented 1 year ago

The rules I posted are unblock rules and therefore cannot interfere unless some issue with FireFox extension's compiler.

sprunkwallace commented 1 year ago

well, deleting that unblock rule, with all the other rules in place, made reddit function normally

adguard-bot commented 1 year ago

Issue URL (Ads)

https://www.reddit.com/

Comment

Username: @Arduingo

Promoted post in reddit are not being blocked by the extension, I have made the question in forums and it seems to work for others

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/oo8ssf1wa4gwko8c8cggk04s444oksj5pgxy3wyn4k.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/hyoh0ujut40k888ckscco4sc08o40ko1u01fd3gext.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard for Safari v1.11.14
Browser: Safari
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances
Other extensions used: None, the only additional filter is Safari own privacy protection
BlazDT commented 1 year ago

@Arduingo Please disable content blockers, wait a bit and reenable them. https://support.apple.com/guide/safari/websites-ibrwe2159f50/mac#:~:text=To%20change%20these%20settings%2C%20choose,menu%20next%20to%20the%20website.

adguard-bot commented 1 year ago

Issue URL (Incorrect Blocking)

https://www.reddit.com/r/jailbreak/comments/7tagoq/release_spotify_new_ui_enabler_v12/

Comment

Username: @jimmysofat6864

The page does not work unless I accept the prompt to view in safari which is missing when AdGuard is enabled. I managed to link it down to the AdGuard Mobile App Banners filter not doing its job which is part of annoyances. Using iPhone 7 Plus on iOS 14. Doesn’t support advanced filtering.

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/6qw1rf17b3ks4gwkosgokwwgs84csg8rhveoe5u1ys.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/t2ip9hkt6lw8sgwcwcwkok0oooscko4g3zvkyjfpnw.png?nc=1)

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.4.6
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Annoyances:
AdGuard Mobile App Banners
jimmysofat6864 commented 1 year ago

Please refer to this this old issue which describes the issue that I am referring to. I managed to narrow down which filter wasn’t working. I have that filter enabled but I still see the message and as expected I can’t scroll down which is the odd behavior I mentioned before.

https://github.com/AdguardTeam/AdguardFilters/issues/154350#event-9995690215

166E7898-3A0F-49D9-8EE0-ACE4E7B72C94

jimmysofat6864 commented 1 year ago

I think it also has something to do with fanboy annoyances as well as having that enabled makes the page appear with no app buttons but then the page is fully nonfunctional.

02FF7A71-B2F2-4FAA-BCF3-DCAB356C2B2D

BlazDT commented 1 year ago

If you add this rule to user filter (wth AdGuard filters only), is it working? reddit.com#@?#.XPromoPopupRpl.m-active

Normally those rules should not apply to iOS without Advanced protection due to #?#. If working for you I will modify rules.

jimmysofat6864 commented 1 year ago

If you add this rule to user filter (wth AdGuard filters only), is it working? reddit.com#@?#.XPromoPopupRpl.m-active

Normally those rules should not apply to iOS without Advanced protection due to #?#. If working for you I will modify rules.

@BlazDT Enabling that in custom filters still shows the prompt to install the app.

1A7B5773-745D-4525-9976-533903C5AC95

BlazDT commented 1 year ago

As expected. Without advanced protection this is the best you can get.

jimmysofat6864 commented 1 year ago

As expected. Without advanced protection this is the best you can get.

@BlazDT Thats strange as when I enabled the other filter lists it shows the page just fine without the pop up box but the scrolling doesn’t work. Is there a way to get it to auto select continue in browser?

BlazDT commented 1 year ago

Since you cannot scroll and modification of scrolling requires advanced protection, there is nothing to do. Therefore we show the modal, so you can press on continue to use the page.

So filtering is working as expected on non advanced protection.