Closed zloyden closed 1 year ago
zloyden
commented
1 year ago @Versty the leftover appears when the nitefall extension is enabled. If it is disabled, the filtering works as it is supposed to. @gototheskinny now the discussion is here. Please be ready to answer the delevopers' questions.
gototheskinny
commented
1 year ago @Versty the leftover appears when the nitefall extension is enabled. If it is disabled, the filtering works as it is supposed to.
@gototheskinny now the discussion is here. Please be ready to answer the delevopers' questions.
Ofc feel free to tag me!
gototheskinny
commented
1 year ago Same behavior on https://www.odatv4.com/siyaset/ogan-in-el-hareketi-gundem-oldu-fulya-ozturk-aciklama-yapti-27402135 too. Top app banner is correctly blocked when nitefall is disabled.
Versty
commented
1 year ago @gototheskinny Thank you for reporting! We have managed to reproduce the issue on our side.
slavaleleka
commented
1 year ago @gototheskinny cannot install the Nitefall app, not available in the region (tried few different regions)
what's your AppleID region? do you know where is it available now?
gototheskinny
commented
1 year ago @gototheskinny
cannot install the Nitefall app, not available in the region (tried few different regions)
what's your AppleID region? do you know where is it available now?
Turkey. And just checked the appstore and it's unavailable for me too. But this issue is probably there on simular dark mode for safari apps. Ps: I'm using a jailbroken device that has the exact app but in a tweak form. And this issue is still there.
Found this on the devs Twitter I guess their account is terminated. I wasn't expecting that.. OK. https://twitter.com/foxfortmobile/status/1677359343161982978?s=46&t=hciYFYAc1bEWqHVC9biq3g
gototheskinny
commented
1 year ago @gototheskinny
cannot install the Nitefall app, not available in the region (tried few different regions)
what's your AppleID region? do you know where is it available now?
Now it's available again. https://apps.apple.com/tr/app/nitefall-dark-mode-for-safari/id1575190591?l=tr
gototheskinny
commented
1 year ago It's happening in this site too exact same behavior: https://uzmanparam.milliyet.com.tr/borsa/hisse-senetleri/enka-insaat-enkai/?period=5 if you guys need screenshots I would upload it for now it's not necessary.
slavaleleka
commented
1 year ago for this leftover there is a rule for yorum.altin.in which matches an element with specific style attribute value:
yorum.altin.in##div[style="margin-top:10px;display:block;width:100%;"]but the Nitefall extension changes styles of elements so filtering rules should be more specific. @zloyden FYI
nitefall disabled: https://uploads.adguard.org/slbdzdrvmwrsg.png
nitefall enabled: https://uploads.adguard.org/slbdzdrvrbij6.png
zloyden
commented
1 year ago After spoken with @Alex-302, it was decided to leave it as it is.
It is blocked by the AdGuard, there is no ad. The thing is, it is the Nitefall extension that interferes with the code of the website.
gototheskinny
commented
1 year ago After spoken with
@Alex-302, it was decided to leave it as it is.It is blocked by the AdGuard, there is no ad. The thing is, it is the Nitefall extension that interferes with the code of the website.
OK, I get it. Thank you guys for checking!
@adguard-bot commented on Tue May 16 2023
Issue URL (Ads)
https://yorum.altin.in/tum/dolar
Comment
Username: @gototheskinny
Screenshots
Screenshot 1
System configuration
AdGuard Base,
AdGuard Mobile Ads
Privacy:
AdGuard Tracking Protection
Social Widgets:
AdGuard Social Media
Annoyances:
AdGuard Annoyances
Language-specific:
AdGuard German,
AdGuard Turkish
@zloyden commented on Tue May 16 2023
Fixed, update should be available in 2-3 hours.
@gototheskinny commented on Thu May 18 2023
@zloyden Just checked it and it's not fixed for me rn.
@zloyden commented on Thu May 18 2023
Not reproduced it on my end even with a Turkish IP. Try to clear browser data, update the filters (wait almost one minute there), open the site. If that doesn't work, you should re-enable the content blockers in Safari settings (wait about the same time as when you update the filters).
@gototheskinny commented on Thu May 18 2023
Tried everything that you've said but it's not working. It's only for me I guess.
@zloyden commented on Thu May 18 2023
Strange, try to do next:
yorum.altin.in#?#.sol > div:has(> ins.adsbygoogle)in User rules@gototheskinny commented on Thu May 18 2023
Without nitefall extension
Screenshot:
With nitefall ex
Screenshot:
Just tried without the user rule same response --- @zloyden commented on [Thu May 18 2023](https://github.com/AdguardTeam/AdguardFilters/issues/151001#issuecomment-1553138017) > Without nitefall extension Do you mean [this](https://apps.apple.com/us/app/nitefall-dark-mode-for-safari/id1575190591)? As I can see, if you enable nitefall extension, you'll get the leftover. So, seems that the problem is not with the rules. --- @gototheskinny commented on [Thu May 18 2023](https://github.com/AdguardTeam/AdguardFilters/issues/151001#issuecomment-1553150547) > > Without nitefall extension > > > > Do you mean [this](https://apps.apple.com/us/app/nitefall-dark-mode-for-safari/id1575190591)? As I can see, if you enable nitefall extension, you'll get the leftover. > > So, seems that the problem is not with the rules. Yes that's the extension. Yeah that's the cause of the issue. That's the first time this extension caused an issue.