AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.17k stars 631 forks source link

google.com #166699

Closed adguard-bot closed 11 months ago

adguard-bot commented 11 months ago

Issue URL (Ads)

https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https%3A%2F%2Fyappy.media%2F&ved=2ahUKEwiC57KwitOCAxV1HBAIHYLYDtMQFnoECAgQAQ&usg=AOvVaw3uPjLZ51wfIYMQrFiYVD_b

Comment

Назойливая реклама Username: @https://www.google.com/url?sa=t&source=web&rct=j&opi=89978449&url=https://yappy.media/&ved=2ahUKEwiC57KwitOCAxV1HBAIHYLYDtMQFnoECAgQAQ&usg=AOvVaw3uPjLZ51wfIYMQrFiYVD_b

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/q7pvwfzslvkwow4okkwo0s4gc4swkkgf2gkqsritfk.jpg?nc=1)

System configuration

Information Value
AdGuard product: AdGuard Content Blocker v2.7.2
Browser: Браузер Samsung Internet
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Other:
AdGuard Experimental,
Filter unblocking search ads and self-promotion

Language-specific:AdGuard Russian,
AdGuard German,
AdGuard Japanese,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
AdGuard Turkish,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
ABPindo,
Bulgarian list,
EasyList China,
EasyList Czech and Slovak,
EasyList Hebrew,
EasyList Italy,
Liste AR,
Liste FR,
ROList,
Greek AdBlock Filter,
Polish GDPR-Cookies Filters,
Estonian List,
List-KR,
YousList,
ABPVN List
adguard-bot commented 11 months ago

Issue URL (Ads)

https://www.google.com/search?q=px7&ie=UTF-8#ip=1

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/dx9efxdya1w0kgoooc4gg4woskgockseazb07zttoo.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Android v4.2.118
Browser: Edge
License type: paid
AdGuard mode: VPN
HTTPS filtering: enabled
Stealth mode options: Send Do-Not-Track header,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (180),
Self-destructing first-party cookies (4320)
DNS filtering: server: https://dns.adguard-dns.com/dns-query
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
Fanboy's Enhanced Tracking List,
Peter Lowe's Blocklist,
Fanboy's Anti-Facebook List

Social Widgets:
AdGuard Social Media,
Fanboy's Social Blocking List

Annoyances:
AdGuard Annoyances,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets,
Adblock Warning Removal List,
Fanboy's Annoyances,
Web Annoyances Ultralist,
Dandelion Sprout's Annoyances List

Other:
Filter unblocking search ads and self-promotion
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js
jellizaveta commented 11 months ago

https://github.com/AdguardTeam/AdguardFilters/issues/166699#issue-2002678100 Для блокировки рекламы на android лучше использовать полноценное приложение AdGuard для Android.

jellizaveta commented 11 months ago

https://github.com/AdguardTeam/AdguardFilters/issues/166699#issuecomment-1822144863 Unfortunately, I cannot reproduce this issue on my end. Please, check that the browser is in the list of filtered applications.

adguard-bot commented 11 months ago

Issue URL (Incorrect Blocking)

https://www.google.com/search?q=s22+android+14

Comment

Ориентировочно дело в базовом фильтре. Вчера вечером (23.11.23) сломались кнопки в поисковике гугл, на яндекс дзен и перестали грузится некоторые видео/картинки. Провайдера менял, при отключении adguard все работает Username: @Insight16

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/9qvzt5mpo5wcc0wwo0o8gcog4840gkcl6zc5xpp4w0.jpg?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/lq05nne9y9wg4sgc40cwww88kw4s884fcpyzqtxrvk.jpg?nc=1)
Screenshot 1 with AdGuard disabled ![Screenshot 1](https://cdn.adguard.info/sitereports/7ycwqjsq3noks80coowgw8wsgk0o0oknb3tezygxpw.jpg?nc=1)
Screenshot 2 with AdGuard disabled ![Screenshot 2](https://cdn.adguard.info/sitereports/azkubq9e36gcc44ogoko00gcssw00sw7tgddf01cag.jpg?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Android v3.6.11 (54)
System version: Android 13
Browser: Браузер Samsung Internet
License type: paid
AdGuard mode: VPN
HTTPS filtering: enabled
Stealth mode options: Block WebRTC,
Block Push API,
Block Location API,
Strip URLs from tracking parameters,
Hide your search queries,
Send Do-Not-Track header,
Remove X-Client-Data header from HTTP requests,
Protect against DPI,
Disable cache for third-party requests,
Block trackers
DNS filtering: server: System
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Russian
Userscripts: https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
adguard-bot commented 11 months ago

Issue URL (Incorrect Blocking)

https://www.google.com.ua/m?q=%D1%81%D1%82%D1%8F%D0%B6%D0%B0%D1%82%D0%B5%D0%BB%D1%8C&client=ms-opera-mobile&channel=new&espv=1

Comment

Не раскрываются элементы меню и подсказки. Username: @Spok1

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/lzq6zf4rryoc8800gk0s88og0oo4k4g421yitenfvk.png?nc=1)
Screenshot 1 with AdGuard disabled ![Screenshot 1](https://cdn.adguard.info/sitereports/jkk82a2qho0sc04044wg80swc8oc8swlvig2da2dhc.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Android v3.6.11 (54)
System version: Android 7
Browser: Opera
License type: free
AdGuard mode: VPN
HTTPS filtering: enabled
Stealth mode: disabled
DNS filtering: server: https://dns.cloudflare.com/dns-query
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:
AdGuard Ukrainian,
AdGuard Russian
Userscripts: disabled
adguard-bot commented 11 months ago

Issue URL (Ads)

https://www.google.com/search?q=eset+home&sca_esv=585181514&ei=33hhZf2jOanm5NoP6KOH-Ao&ved=0ahUKEwi9j5z1qN6CAxUpM1kFHejRAa8Q4dUDCBA&uact=5&oq=eset+home&gs_lp=Egxnd3Mtd2l6LXNlcnAiCWVzZXQgaG9tZTIFEAAYgAQyBRAAGIAEMgUQABiABDIFEAAYgAQyBRAAGIAEMgUQABiABDIFEAAYgAQyBRAAGIAEMgUQABiABDIFEAAYgARI8QpQAFjsCXAAeAGQAQCYAbQCoAGiEaoBBTItNy4xuAEDyAEA-AEBwgIFEC4YgATCAgsQLhiABBjHARjRA8ICFBAuGIAEGJcFGNwEGN4EGN8E2AEBwgIQEC4YgAQYigUYxwEY0QMYQ8ICHxAuGIAEGIoFGMcBGNEDGEMYlwUY3AQY3gQY4ATYAQHCAgoQABiABBiKBRhDwgILEC4YgAQYxwEYrwHiAwQYACBBiAYBugYGCAEQARgU&sclient=gws-wiz-serp

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/mchlkmd3ruowoswkcwk44wcgw04ssgo7fhw053sx64.jpg?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Windows v7.15.1 (4386)
Browser: Edge
License type: paid
AdGuard driver: WFP
Stealth mode options: Block Location API,
Block Flash,
Block Java,
Strip URLs from tracking parameters,
Hide your search queries,
Send Do-Not-Track header,
Hide your Referrer from third-parties (www.google.com),
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Protect against DPI,
Self-destructing third-party cookies (180),
Disable cache for third-party requests,
Block third-party Authorization header,
Disable WAP Push Message Routing Service,
Disable Windows Defender automatic samples submission,
Disable Windows Telemetry,
Turn off Advertising ID
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
Peter Lowe's Blocklist,
Fanboy's Enhanced Tracking List,
Fanboy's Anti-Facebook List

Annoyances:
AdGuard Annoyances,
Fanboy's Annoyances,
Web Annoyances Ultralist,
Adblock Warning Removal List,
I don't care about cookies,
Dandelion Sprout's Annoyances List

Security:
Online Malicious URL Blocklist,
NoCoin Filter List

Language-specific:Official Polish filters for AdBlock, uBlock Origin & AdGuard,
AdGuard Turkish,
AdGuard French,
AdGuard Russian,
AdGuard Chinese,
AdGuard German,
AdGuard Japanese,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
AdGuard Ukrainian,
ABPindo,
Bulgarian list,
EasyList Czech and Slovak,
EasyList Hebrew,
EasyList Italy,
EasyList Lithuania,
Latvian List,
Liste AR,
Liste FR,
ROList,
Icelandic ABP List,
AdBlockID,
Greek AdBlock Filter,
EasyList Thailand,
Hungarian,
Xfiles,
RU AdList: Counters,
ABPVN List,
Estonian List,
CJX's Annoyances List,
Polish Social Filters,
List-KR,
KAD - Anti-Scam,
Adblock List for Finland,
ROLIST2,
Persian Blocker,
road-block light,
Polish Annoyances Filters,
Polish Anti Adblock Filters,
Frellwit's Swedish Filter,
YousList,
EasyList Polish,
Polish Anti-Annoying Special Supplement,
Dandelion Sprout's Nordic Filters,
Dandelion Sprout's Serbo-Croatian List,
IndianList,
Macedonian adBlock Filters,
EasyList Portuguese
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js
https://userscripts.adtidy.org/release/popup-blocker/2.5/popupblocker.user.js
Other extensions used: Eset Security
Spok1 commented 11 months ago

@BlazDT, can't you check what's wrong and what broke the script? Because Alex and evil den don't work on weekends. All hope is on you.🙏

BlazDT commented 11 months ago

@ last report with "AdGuard for Windows v7.15.1 (4386)": You have way too many enabled filters which can break elements. Please only enable AdGuard filters and ensure you do not have the filter Filter unblocking search ads and self-promotions enabled.

@Spok1 Sadly I cannot reproduce the issue on Android 14 with given config and paid Android (though paid version has only additional features which should not take effect in this case).

Is this url opening fine?

https://www.google.com.ua/search/about-this-result?origin=www.google.com.ua&ons=10041&ri=&fd=CggKAggTCgIIPxIECgIICRoCCAE&dis=EAE&hl=en_DE&gl=DE&vet=10CAAQjogJahcKEwjwjPfIq9-CAxUAAAAAHQAAAAAQAg.1wFiZaPeHZLjxc8P7tCRmAM.i&uact=1&cctld=com.ua

Is everything working if you check with Chrome browser? I know Opera can be a bit troublesome to install HTTPS certificate.

If I understand free vs paid correctly, free Android version does not allow you access to user filters? If it allows, please try to add this rule: @@||google.com.ua^$elemhide

Please note that rule will disable element hiding completely (and ads show up). It is a temporary rule to check what is breaking the page.

adguard-bot commented 11 months ago

Issue URL (Incorrect Blocking)

https://www.google.com/search?q=google&client=safari&sca_esv=585272054&sxsrf=AM9HkKnlnrIVeU614Pgo66GJ-n68NSX1_g%3A1700930946805&source=hp&ei=giViZfW5Lo_ZkdUPlY2EkAE&iflsig=AO6bgOgAAAAAZWIzkgJW1rygYFEcF_rYyqw08xvirZTv&ved=0ahUKEwj1gvrGzd-CAxWPbKQEHZUGARIQ4dUDCAk&uact=5&oq=google&gs_lp=Egdnd3Mtd2l6IgZnb29nbGUyEBAuGIAEGIoFGMcBGNEDGEMyCxAAGIAEGIoFGJECMgoQABiABBiKBRhDMgsQABiABBiKBRiRAjIKEAAYgAQYigUYQzIKEAAYgAQYigUYQzIKEAAYgAQYigUYQzIKEAAYgAQYigUYQzIKEAAYgAQYigUYQzIKEAAYgAQYigUYQ0jfCFD0AVjGBnABeACQAQCYAb8BoAG9BqoBAzAuNrgBA8gBAPgBAagCAcICBhCzARiFBMICBRAAGIAE&sclient=gws-wiz&safe=active

Comment

  • Enter/return to search after editing search terms on a Google Search (All) page enters a new line instead of loading the search;
  • When video results appear, such as Youtube videos with the option to be previewed within the Search page, clicking the [expand video] button/icon or the [play video] button/icon does nothing – if the page has been scrolled down, clicking those buttons will set the scroll position to its start;
  • Both of these issues happen only under the general search feature (as far as I've tested) – not on the main google.com page nor within a "Images" or "Videos" filter search page. Username: @catfaceingeometricshapes

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/hvlcgu4s8bkgk88g4sksw4kc4g088kcj92eo4fkihc.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/cl9o7afkdjsccwksow8wws40s4sc8cimrmzf6ws48c.png?nc=1)
Screenshot 1 with AdGuard disabled ![Screenshot 1](https://cdn.adguard.info/sitereports/b4frbnskemo8wks0swgwkw0g4k4kkwp2xlvwijdc0w.png?nc=1)
Screenshot 2 with AdGuard disabled ![Screenshot 2](https://cdn.adguard.info/sitereports/phk8a0wv2b4s8socc44s88s08cc8c4wnw4bxqad234.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Mac v2.9.2.1234 release
System version: macOS 12.7.1
Browser: Safari
License type: paid
Stealth mode: disabled
DNS filtering: server: https://dns.adguard-dns.com/dns-query
filters: https://filters.adtidy.org/mac_v2/filters/15.txt
Filters: Ad Blocking:
AdGuard Base

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Language-specific:
AdGuard Russian,
AdGuard German,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
AdGuard French,
EasyList Czech and Slovak,
EasyList Italy,
Adblock List for Finland,
Dandelion Sprout's Nordic Filters
Userscripts: AdGuard Extra (url: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js)
Other extensions used: Are.na for Safari (extension), Hush (extension), Omnivore (extension), Push to Kindle (extension), Surfed (extension), Bitdefender Virus Scanner (app)
Spok1 commented 11 months ago

@blazdt

Is this url opening fine? https://www.google.com.ua/search/about-this-result?origin=www.google.com.ua&ons=10041&ri=&fd=CggKAggTCgIIPxIECgIICRoCCAE&dis=EAE&hl=en_DE&gl=DE&vet=10CAAQjogJahcKEwjwjPfIq9-CAxUAAAAAHQAAAAAQAg.1wFiZaPeHZLjxc8P7tCRmAM.i&uact=1&cctld=com.ua

Yes

Is everything working if you check with Chrome browser?

No. Browsers have nothing to do with it. Same behavior everywhere.

I know Opera can be a bit troublesome to install HTTPS certificate.

This is already in the past. Starting from version 75, Opera trusts user certificates by default.

If I understand free vs paid correctly, free Android version does not allow you access to user filters?

Not at all!

please try to add this rule: @@||google.com.ua^$elemhide

Unfortunately, this had no effect ,however, the @@__^$document syntax that I looked at in a similar commit and which I adjusted to the sites on which the problem works for me, in particular these are Google search results and Github, but this is not a solution to the problem,Is not it? You have to figure this out somehow!

BlazDT commented 11 months ago

document exclusion is only disabling AdGuard.

Please try one with jsinject instead of document. If not working, exchange with urlblock.

Spok1 commented 11 months ago

@BlazDT

Please try one with jsinject instead of document. If not working, exchange with urlblock.

I'm afraid I didn't understand you.

BlazDT commented 11 months ago

In previous rule you had $document. There you exchange the word document with one of the phrases I posted in my previous reply.

Spok1 commented 11 months ago

@BlazDT, @@||google.com.ua^$jsinject right? I added it to the list, it also helps. And what does this mean for us?

BlazDT commented 11 months ago

Correct. That means some JavaScript rule ( #%# ) is running bogus here (rule disables every JavaScript rule to this site). Will check which rules get applied for this page later.

Spok1 commented 11 months ago

Will check which rules get applied for this page later.

Where to check?

But this rule does not work on Github, it only helps @@||github.com^$document What to do in this case?

BlazDT commented 11 months ago

We are talking about Google here, so why do you mention GitHub now?

EDIT: Please add these rules and reply if working:

google.com.ua#@%#//scriptlet('remove-attr', 'ping', 'div[id="search"] a[data-ved][ping]')
google.com.ua#@%#(function() { try { if ("undefined" != typeof localStorage) { window.localStorage.setItem("gtButterbarDismissalExpiry", ((new Date).getTime() + 6048E5).toString()) } } catch (ex) {} })();
google.com.ua#@%#(function(){try{var time=(new Date).getTime();var cookieDate=new Date(time+1314E6);var hostname=location.host;var locSubString=null;if(!hostname.startsWith("google.")&&!hostname.startsWith("youtube."))locSubString=hostname.substring(hostname.indexOf(".")+1);var loc=locSubString||hostname;if(document.cookie.indexOf("CONSENT=YES")!==-1)return;document.cookie="CONSENT=YES+; domain="+loc+"; path=/; expires="+cookieDate.toUTCString()}catch(ex){console.error("AG: failed to set consent cookie: "+ex)}})();
google.com.ua#@%#//scriptlet('trusted-click-element', 'body > div > div div.GzLjMd > button + button[id="L2AGLb"] > div.QS5gu', '', '500')
google.com.ua#@%#//scriptlet('trusted-click-element', 'body > div > div div.IKl7Q button[id="L2AGLb"] > div.QS5gu', '', '500')

If not working, is it working if you only enable Base filter?

EDIT2: EasyList is disabling generichide on google search in the first place, so proposed filter @@||google.com.ua^$jsinject should not have worked in the first place. @@||google.*^$generichide,jsinject,important

Spok1 commented 11 months ago

We are talking about Google here, so why do you mention GitHub now?

Because the basic filter also breaks scripts on GitHub, so it’s fair to mention this, since the problem is the same.

EDIT: Please add these rules and reply if working:

google.com.ua#@%#//scriptlet('remove-attr', 'ping', 'div[id="search"] a[data-ved][ping]')
google.com.ua#@%#(function() { try { if ("undefined" != typeof localStorage) { window.localStorage.setItem("gtButterbarDismissalExpiry", ((new Date).getTime() + 6048E5).toString()) } } catch (ex) {} })();
google.com.ua#@%#(function(){try{var time=(new Date).getTime();var cookieDate=new Date(time+1314E6);var hostname=location.host;var locSubString=null;if(!hostname.startsWith("google.")&&!hostname.startsWith("youtube."))locSubString=hostname.substring(hostname.indexOf(".")+1);var loc=locSubString||hostname;if(document.cookie.indexOf("CONSENT=YES")!==-1)return;document.cookie="CONSENT=YES+; domain="+loc+"; path=/; expires="+cookieDate.toUTCString()}catch(ex){console.error("AG: failed to set consent cookie: "+ex)}})();
google.com.ua#@%#//scriptlet('trusted-click-element', 'body > div > div div.GzLjMd > button + button[id="L2AGLb"] > div.QS5gu', '', '500')
google.com.ua#@%#//scriptlet('trusted-click-element', 'body > div > div div.IKl7Q button[id="L2AGLb"] > div.QS5gu', '', '500')

If not working, is it working if you only enable Base filter?

None of the rules work.

EDIT2: EasyList is disabling generichide on google search in the first place, so proposed filter @@||google.com.ua^$jsinject should not have worked in the first place. @@||google.*^$generichide,jsinject,important

Add this rule to the list?

BlazDT commented 11 months ago

Yes, instead of previous generichide or document or jsinject rule for google (you can leave the #@%# rules active for testing). If @@||google.*^$generichide,jsinject,important is not working, please try:

@@||google.*^$elemhide,jsinject,important

Spok1 commented 11 months ago

@@||google.*^$generichide,jsinject,important Works. What's next? What about Github? Leave @@||github.com^$document?

BlazDT commented 11 months ago

Please open an issue about github.com and post there what exactly is broken ( you can post issue link here). Please try this one for github instead: @@||github.com^$generichide,jsinject,important

Could you please double-check your base filter is from today (I am on version 2.3.11.26? Not that there is a bug with getting updates and we are chasing a ghost here.

Except very generic JS inject rules I sadly do not get any applied to my google searches (especially not from Base filter). @AdamWr an idea which JS rule could break it? Probably some generic JS rule is breaking github and google.

AdamWr commented 11 months ago

I'm not sure, but I guess that the problem might be also old version used (AdGuard for Android v3.6.11 (54)). This version uses old scriptlets library and due to this some website might be broken, for example by trusted-click-element scriptlet (or by any other scriptlet).

Spok1 commented 11 months ago

@AdamWr, what are you offering? Switch to using the power-hungry version 4.x? Is this really beyond repair?

I'm not sure, but I guess that the problem might be also old version used (AdGuard for Android v3.6.11 (54)). This version uses old scriptlets library and due to this some website might be broken, for example by trusted-click-element scriptlet (or by any other scriptlet).

Spok1 commented 11 months ago

@BlazDT

Please open an issue about github.com and post there what exactly is broken ( you can post issue link here). Please try this one for github instead: @@||github.com^$generichide,jsinject,important

Two days ago I sent a report about the problems to Github. You can watch it at this link! Rule @@||github.com^$generichide,jsinject,important does not work. Works @@||github.com^$document

Could you please double-check your base filter is from today (I am on version 2.3.11.26? Not that there is a bug with getting updates and we are chasing a ghost here.

Yes, I have the same version.

AdamWr commented 11 months ago

what are you offering? Switch to using the power-hungry version 4.x? Is this really beyond repair?

I just mean that it might be caused by a scriptlet which didn't work correctly in old version (but I might be wrong and I cannot reproduce this problem with version 4). And if it's the case then it rather shouldn't be fixed in the filters (this way we wouldn't be able to use some scriptlets, because someone uses old version of the app), but rules can be added to user rules (though as I cannot reproduce it, then it's hard to say which exactly rule(s) cause problem). You can also try to install latest version and then check if issue still occurs.

Spok1 commented 11 months ago

@AdamWr

You can also try to install latest version and then check if issue still occurs.

There is a forum where discuss the application, and there some use the old version, like me, with a similar problem, and those who use version 4+ do not have such a problem,But two days ago there were no breakdowns, which means the problem is in the filters, and not in the program. In addition, in the new version 4, filters for tracking trackers and parameters in url have a paid basis. And since I don't have a license key, I won't be able to us them after update. That's why I'm not eager to update.😴

AdamWr commented 11 months ago

But two days ago there were no breakdowns

That's information might be helpful. I see that 3 days ago a generic scriptlet has been added (rather incorrectly) and it might causes problem in old version.

Please test this rule:

#@%#//scriptlet('prevent-element-src-loading', 'script', 'npttech.com')
Spok1 commented 11 months ago

@AdamWr

Please test this rule:

@%#//scriptlet('prevent-element-src-loading', 'script', 'npttech.com')

After applying it, menus in Google search results, lists and pictures began to be displayed; The GitHub menu now opens correctly as well. You're great.🤝

AdamWr commented 11 months ago

I think that scriptlet rules should not be added as a generic solution (except probably few of them), so I have changed the rule.

Basically it looks like that the problem is as mentioned before, old app uses old scriptlets library and some scriptlets have been improved/fixed in new version of the app. The same problem may occurs on other websites where such scriptlets are applied, but if it would be added for specific website, then it would not be removed if it works correctly with latest version of the app.

Spok1 commented 11 months ago

@AdamWr, you can close this commit as completed. The changes have already been applied globally.

AdamWr commented 11 months ago

If I'm not wrong, there is one more issue which wasn't checked out yet - https://github.com/AdguardTeam/AdguardFilters/issues/166699#issuecomment-1826379671

Spok1 commented 11 months ago

@AdamWr, ok.

Alex-302 commented 11 months ago

@catfaceingeometricshapes I don't see expand button in Safari. In Chrome it works.

catfaceingeometricshapes commented 11 months ago

@catfaceingeometricshapes I don't see expand button in Safari. In Chrome it works.

You don't have the icon that's little, with a transparent dark-grey rounded square, behind two white angled brackets, displayed diagonally, on the top right corner of every Youtube video result, that I pointed to with a turquoise arrow in "Screenshot 1"?

I've had Adguard disabled in the meantime. Now that you replied I re-enabled it and both of these issues are gone, things seem to be working as before.

Alex-302 commented 11 months ago

@catfaceingeometricshapes

You don't have the icon that's little, with a transparent dark-grey rounded square, behind two white angled brackets, displayed diagonally, on the top right corner of every Youtube video result, that I pointed to with a turquoise arrow in "Screenshot 1"?

Yes, in Safari only.

I've had Adguard disabled in the meantime. Now that you replied I re-enabled it and both of these issues are gone, things seem to be working as before.

So all good now?

catfaceingeometricshapes commented 11 months ago

All good at the moment 👌

On Mon, 27 Nov 2023 at 18:07, Alex @.***> wrote:

@catfaceingeometricshapes https://github.com/catfaceingeometricshapes

You don't have the icon that's little, with a transparent dark-grey rounded square, behind two white angled brackets, displayed diagonally, on the top right corner of every Youtube video result, that I pointed to with a turquoise arrow in "Screenshot 1"?

Yes, in Safari only.

I've had Adguard disabled in the meantime. Now that you replied I re-enabled it and both of these issues are gone, things seem to be working as before.

So all good now?

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardFilters/issues/166699#issuecomment-1828359065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2HXW2SGYGK2NY6OQNMIS3YGTJEZAVCNFSM6AAAAAA7TIXY3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGM2TSMBWGU . You are receiving this because you were mentioned.Message ID: @.***>