AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.07k stars 620 forks source link

www.protothema.gr #172879

Closed adguard-bot closed 6 months ago

adguard-bot commented 6 months ago

Issue URL (Incorrect Blocking)

https://www.protothema.gr/world/article/1467291/gamos-omofulon-zeugarion-pos-eidan-ta-diethni-mme-tin-psifisi-tou-nomoshediou-istoriki-stigmi/

Comment

tweets are not displayed properly if you haven't accepted cookies Username: @lica98

[NSFW] Screenshots

Screenshot 1 Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for Windows v7.17.0 nightly 10 (4608)
Browser: brave 121.0.0.0
License type: free
AdGuard driver: WFP
Stealth mode: disabled
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Mobile Ads,
AdGuard Base

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances

Language-specific:AdGuard Turkish,
AdGuard French,
AdGuard Russian,
AdGuard Chinese,
AdGuard Ukrainian,
AdGuard German,
AdGuard Japanese,
AdGuard Dutch,
AdGuard Spanish/Portuguese,
Bulgarian list,
EasyList Czech and Slovak,
EasyList Italy,
EasyList Lithuania,
Latvian List,
Liste AR,
AdBlockID,
Hungarian,
Estonian List,
List-KR,
Adblock List for Finland,
Persian Blocker,
road-block light,
Polish Anti Adblock Filters,
Frellwit's Swedish Filter,
Dandelion Sprout's Nordic Filters,
Dandelion Sprout's Serbo-Croatian List,
IndianList,
Macedonian adBlock Filters
Userscripts: https://greasyfork.org/scripts/401432-google-image-search-show-image-dimensions/code/Google%20Image%20Search%20-%20Show%20Image%20Dimensions.user.js
https://gist.github.com/ner00/ec9ae47e202b8e99f19be44a5af6baf3/raw/viewimage.user.js
https://gist.github.com/MRuy/ca74d6a359c487d760f4a698e76fb0d6/raw/sb.ltn.fi.coloredcategories.user.js
https://gist.github.com/MRuy/ca74d6a359c487d760f4a698e76fb0d6/raw/sb.ltn.fi.lastupdate.user.js
https://gist.github.com/TheJzoli/8a4cd979d433b7359cdf61c238bc0181/raw/sb.ltn.fi.hidecolumns.user.js
https://raw.githubusercontent.com/mchangrh/uscripts/main/sbltnfi/sbltnfi-imprecise-times.user.js
https://raw.githubusercontent.com/ducng99/SBBCoolHelper/master/SBBCoolHelper.user.js
https://userscripts.adtidy.org/beta/adguard-extra/1.0/adguard-extra.user.js
Referrer: https://www.protothema.gr/
zloyden commented 6 months ago

Are you sure? I see the tweets after refusing consent to cookies.

Screenshot: ![image](https://github.com/AdguardTeam/AdguardFilters/assets/33488229/e8d46539-5826-4f2a-ac50-9fdde1f293db)

lica98 commented 6 months ago

@zloyden but adguard blocks the cookie message entirely so how can you accept or refuse?

you shouldn't need to choose to accept or refuse in the first place, just have the website working properly

zloyden commented 6 months ago

Actually, the cookies has been already blocked by the AdGuard Annoyances and there is no incorrect blocking - the tweets are loaded fine. Which filter breaks it?

you shouldn't need to choose to accept or refuse in the first place

It's required, otherwise you won't see the tweets.

lica98 commented 6 months ago

It's required, otherwise you won't see the tweets.

I mean that you as a user do not need to engage in any way with the cookie notices, the annoyances filter is supposed to remove them and at the same time keep everything working on the site @zloyden

zloyden commented 6 months ago

user do not need to engage in any way with the cookie notices, the annoyances filter is supposed to remove them

I have already explained why it is necessary to refrain from accepting cookies. Besides, you also mentioned the same in the description. Just removing the cookies is not enough, you have to interact with them by refusing or accepting them.

tweets are not displayed properly if you haven't accepted cookies

the annoyances filter is supposed to remove them

We have a rule for this and it works fine.

protothema.gr#%#//scriptlet('trusted-click-element', '.qc-cmp2-summary-buttons > button[mode="secondary"] + button[mode="secondary"]')

You didn't answer my question.

zloyden commented 6 months ago

@AdamWr could you take a look at this on your end?

AdamWr commented 6 months ago

I see that cookie notice is automatically closed and Tweets load fine on my end. I guess that one of the third-party filter lists block cmp.inmobi.com and it causes issue.

AdamWr commented 6 months ago

Nevermind, it's blocked by AdGuard Mobile Ads filter.

AdamWr commented 6 months ago

I have added domain to exception rule, but I guess that it may breaks other websites. As far as I can see, inmobi.com is an advertisement company and have a lot of subdomains - https://subdomainfinder.c99.nl/scans/2024-02-17/inmobi.com, so I guess it shouldn't be removed. Maybe instead we could add something like:

||inmobi.com^$to=~cmp.inmobi.com

so it shouldn't blocks requests from cmp.inmobi.com, but I'm not sure if it will works on iOS and how it will be converted to DNS rule.

zloyden commented 6 months ago

I have been thinking about it or using the denyallow modifier. Perhaps it can't be handled without exceptions for some platforms.

zloyden commented 6 months ago

@lica98 update the filters in 1-2 hours. Btw, using the AdGuard Mobile Ads on desktop is redundant.

lica98 commented 6 months ago

@zloyden there have been some websites where ads were not blocked if you didn't have it enabled (like here)

zloyden commented 6 months ago

Strange. If you have it on desktop sites without the filter, it's better to report it.