AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
2.97k stars 627 forks source link

www.xda-developers.com #180746

Closed adguard-bot closed 1 month ago

adguard-bot commented 1 month ago

Issue URL (Ads)

https://www.xda-developers.com/windows-11-home-vs-windows-11-pro/

Comment

Ad remnant space left behind by .w-adsninja-video-player element Username: @DimitrisKalaboukas

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/ndwwcrtx6wgoww80sg4swcgwwok80kgjrctra0a4xw.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard Browser Extension v4.3.53
System version: Windows 11, version 23h2
Browser: Firefox
Stealth mode: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads,
EasyList

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking,
EasyPrivacy,
Peter Lowe's Blocklist,
Fanboy's Anti-Facebook List

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Annoyances,
Fanboy's Annoyances,
Dandelion Sprout's Annoyances List

Security:
Online Malicious URL Blocklist

Language-specific:
Greek AdBlock Filter
Yuki2718 commented 1 month ago

I'm unsure what to do for this. Should this be treated as a false positive, or should we adjust the grid layout? @Alex-302

Alex-302 commented 1 month ago

False positive image

Alex-302 commented 1 month ago

Please don't assign In Progress label, it assigns issue to you, and we may miss it (the odds aren't great, but they are).

Yuki2718 commented 1 month ago

Please don't assign In Progress label, it assigns issue to you, and we may miss it (the odds aren't great, but they are).

I don't understand, In progress => the issue will be fixed by me, otherwise I'll ping like this.

Alex-302 commented 1 month ago

I don't understand, In progress => the issue will be fixed by me, otherwise I'll ping like this.

This just affects the order in which tasks are processed by us.

Yuki2718 commented 1 month ago

So I fix without adding the In progress label?

On my end xda-developers.com#@#.ad-zone:not(.textads) is not enough, the player is still not shown.

Alex-302 commented 1 month ago

Hm. Which rules and filters block it on your end?

Yuki2718 commented 1 month ago

I'm puzzled as even

@@||xda-developers.com^$generichide
@@||xda-developers.com^$~third-party
@@||xda-developers.com^$third-party

don't work. But if I turn blocker off, it's shown.

Alex-302 commented 1 month ago

Weird. On my end only one rule hides a player

Details ![image](https://github.com/AdguardTeam/AdguardFilters/assets/8361299/9156fc0a-4a2e-46a5-a295-e7126eb3cf1b)
Alex-302 commented 1 month ago

But not working without privacy filters.

Yuki2718 commented 1 month ago

Maybe it's only me, but the same behavior on different Chrome profiles or uBO. @piquark6046 @zloyden

Alex-302 commented 1 month ago

No, reproduced with Base only. Trying to find a necessary rule (blocking).

Yuki2718 commented 1 month ago

xda-developers.com#@#.ad-zone:not(.textads) is working on Firefox. Will add to EL.

Alex-302 commented 1 month ago

||googletagservices.com/tag/js/gpt.js$xmlhttprequest,script,redirect=googletagservices-gpt please test only Base + this rule.

Yuki2718 commented 1 month ago

That works!

zloyden commented 1 month ago

Do you mean the redirect rule? I've also checked it on Chrome, but only the exception rule works.

Alex-302 commented 1 month ago

@zloyden TPF fixes it) (second part of the issue)

Yuki2718 commented 1 month ago

yes, ||googletagservices.com/tag/js/gpt.js$xmlhttprequest,script,redirect=googletagservices-gpt + xda-developers.com#@#.ad-zone:not(.textads) fixes the issue.

Yuki2718 commented 1 month ago

But exception @@||googletagservices.com/tag/js/gpt.js$domain=xda-developers.com not.

zloyden commented 1 month ago

https://github.com/AdguardTeam/AdguardFilters/issues/180746#issuecomment-2147682061 yep, I can also confirm it.

zloyden commented 1 month ago

@Yuki2718 https://github.com/AdguardTeam/AdguardFilters/issues/180746#issuecomment-2147691042 these rules work fine on my end.

@@||googletagservices.com/tag/js/gpt.js$domain=xda-developers.com
@@||securepubads.g.doubleclick.net/pagead/managed/js/gpt/*/pubads_impl.js$domain=xda-developers.com
xda-developers.com#@#.ad-zone:not(.textads)
Yuki2718 commented 1 month ago

confirmed, will add to EL.

Yuki2718 commented 1 month ago

@Alex-302 Regarding this comment

! TODO: check with Easylist 06.06.24

##.ad-zone:not(.textads) is in Base (anti-adblock.txt) and not in EL. EL already has xda-developers.com#@#.ad-zone.

Alex-302 commented 1 month ago

Added also Slava's rules with for CBs.

Yuki2718 commented 1 month ago

Added also Slava's rules with for CBs.

Though I added to EL? https://github.com/easylist/easylist/commit/1f250ca453839c640571059b16cfc7905106ebf7

Alex-302 commented 1 month ago

@Yuki2718 Did not see. Removed.

SeriousHoax commented 1 month ago

@Alex-302 @Yuki2718 Is it expected for it to not work when AdGuard DNS is used or AdGuard DNS filter in AdGuard for Windows?

Alex-302 commented 1 month ago

Will check a bit later.

SeriousHoax commented 1 month ago

Will check a bit later.

One more thing, these two sites also have similar issues that xda-forum had. Currently videos are not shown with ADG Extension + Cloudflare DNS. https://www.howtogeek.com/lume-cube-edge-light-20-review/ https://www.makeuseof.com/nzxt-function-2-review/

Screenshot: ![1](https://github.com/AdguardTeam/AdguardFilters/assets/29574622/78c11559-432a-4ac8-ad4f-875d7d83c20f)
adguard-bot commented 1 month ago

Issue URL (Social Widget)

https://www.xda-developers.com/intel-should-be-more-worried-about-qualcomm-than-it-has-ever-been-with-amd/

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/ekizhlrlv808o4swgcgw04ko00gk4ccfpu5rauo8rc.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Android v4.5
System version: Android 9
Browser: Edge
AdGuard mode: VPN
HTTPS filtering: enabled
Stealth mode options: Hide your search queries,
Send Do-Not-Track header,
Hide your Referrer from third-parties,
Hide your User-Agent,
Protect against DPI,
Self-destructing third-party cookies (180),
Self-destructing first-party cookies (4320)
DNS filtering: server: quic://xxxxxxx.d.adguard-dns.com
filters: https://filters.adtidy.org/android/filters/15_optimized.txt
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard URL Tracking,
AdGuard Tracking Protection,
Legitimate URL Shortener,
Fanboy's Anti-Facebook List

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets
Custom filters: https://github.com/bpc-clone/bypass-paywalls-clean-filters/raw/main/bpc-paywall-filter.txt
Userscripts: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js
https://userscripts.adtidy.org/release/disable-amp/1.0/disable-amp.meta.js
https://github.com/bpc-clone/bypass-paywalls-clean-filters/raw/main/userscript/bpc.en.user.js