AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.21k stars 638 forks source link

www.npr.org #189230

Closed adguard-bot closed 1 month ago

adguard-bot commented 1 month ago

Issue URL (Incorrect Blocking)

https://www.npr.org/2024/09/20/nx-s1-5121176/fda-flumist-flu-vaccine-at-home-approved

Comment

See https://github.com/AdguardTeam/AdguardForAndroid/issues/5101 , NPR pages freeze on first load seemingly due to a pop-up failing to load (not being block correctly?) which makes scrolling impossible. I just tested on this NPR article https://www.npr.org/2024/09/20/nx-s1-5121176/fda-flumist-flu-vaccine-at-home-approved in Chrome Incognito mode on Android 14. Interestingly after refreshing the frozen page it loads fine, so it appears to only be an issue on the first load of an NPR page in an Incognito session (for non-Incognito Chrome, seemingly if NPR has ever been loaded before subsequent articles load fine, so I guess it only applies on the first time an NPR article is loaded).

After pausing Adguard and loading a new Incognito session of the same article, I'm fairly certain the pop-up "Get the app" for NPR's own app is likely what is causing the page to freeze, it's probably being blocked in such a way that the page can't be scrolled after it fails to load? Screenshot_20240921-125241

Edit2: After some additional testing, I've narrowed it down to the "AdGuard Popups filter". Turning off that particular filter allows the "Get the app" pop-up to load and be closed manually to continue scrolling, while turning it back on causes the pop-up to fail to load which blocks scrolling. Username: @jeffreymcclain

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/ccmcovwbhwggkw00k04o84g04o4o4wcir84xzhtkdc.png?nc=1)
Screenshot 1 with AdGuard disabled ![Screenshot 1](https://cdn.adguard.info/sitereports/kyvns062sogo84o8c48w0wwg00sks441e94meg186c.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Android v4.6.3
System version: Android 14
Browser: Chrome
License type: paid
AdGuard mode: VPN
HTTPS filtering: enabled
Tracking protection: disabled
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base

Annoyances:
AdGuard Popups
Browsing Security: disabled
Browsing Security statistics: disabled
Userscripts: disabled
jeffreymcclain commented 1 month ago

The tl;dr is that the AdGuard Popups filter appears to cause an NPR pop-up about their mobile app to fail to load, which has the indirect consequence of causing scrolling to no longer function. Note even with AdGuard paused this pop-up only appears after 10-15 seconds or so after scrolling a bit, it doesn't load immediately. I'm assuming the fix would be to adjust the "Adguard Popups filter" logic to either not block this particular pop-up or to block it in such a way that scrolling still functions after?

AdamWr commented 1 month ago

Fixed, filters update should be available in 1-2 hours.