AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.12k stars 632 forks source link

hbr.org #189848

Open adguard-bot opened 5 days ago

adguard-bot commented 5 days ago

Issue URL (Annoyance)

https://hbr.org/2024/09/ai-can-mostly-outperform-human-ceos Username: @rakleed

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/et4b0hhuyy8sscwc8wsssw44gsggk0wmgka0uuw5z4.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/9qoks3xitskc88socsccosss8wc8kkwaqzoodhnllc.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for iOS v4.5.5
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Language-specific:
AdGuard Russian
adguard-bot commented 19 hours ago

Issue URL (Incorrect Blocking)

https://hbr.org/2024/09/ai-can-mostly-outperform-human-ceos

Comment

When AdGaurd is enabled, the header is not completely visible.

Also leftovers from social buttons, mobile app link, self-promo and email subscription. Username: @rakleed

Screenshots

Screenshot 1 ![Screenshot 1](https://cdn.adguard.info/sitereports/6hqppp3acww08cokw404g8kg8kswk0kdkzsg4lvqi8.png?nc=1)
Screenshot 2 ![Screenshot 2](https://cdn.adguard.info/sitereports/284leos6m9ogswo0gwwc88k4gsw8gs4k7ke5skt0og.png?nc=1)
Screenshot 3 ![Screenshot 3](https://cdn.adguard.info/sitereports/ljtit6lyrqoscwk0w04sgg4wcco800o4dzk0lb7wpw.png?nc=1)
Screenshot 1 with AdGuard disabled ![Screenshot 1](https://cdn.adguard.info/sitereports/p95ymqjeq1cc8sw4cks0okcsk0csocc4cqtig3h1ny.png?nc=1)

System configuration

Information Value
AdGuard product: AdGuard for Mac v2.15.1.1731 release
Browser: Chrome
Tracking protection options: Strip URLs from tracking parameters,
Hide your search queries,
Hide your Referrer from third-parties,
Hide your User-Agent,
Remove X-Client-Data header from HTTP requests,
Self-destructing third-party cookies (180),
Disable cache for third-party requests,
Block trackers
DNS filtering: server: https://d.adguard-dns.com/dns-query/xxxxxxx
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection,
AdGuard URL Tracking

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances,
AdGuard Widgets

Language-specific:
AdGuard Russian
Browsing Security: enabled
Browsing Security statistics: disabled
Userscripts: IMDb Tomatoes (url: https://update.greasyfork.org/scripts/15222/IMDb Tomatoes.user.js)
AdGuard Extra (url: https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.user.js)
Nova YouTube (url: https://openuserjs.org/install/raingart/Nova_YouTube.user.js)
Userstyles: disabled

Issue configuration

Import

rakleed commented 19 hours ago
Screenshots AdGuard enabled: ![image](https://github.com/user-attachments/assets/2db7ca45-fca8-4955-9d2e-e132ac8c0cf4) ![image](https://github.com/user-attachments/assets/82dcb613-e2ed-4a87-861f-931c7b1dad03) ![image](https://github.com/user-attachments/assets/b180fea0-bd37-421e-94e9-4b997b233463) AdGuard disabled: ![image](https://github.com/user-attachments/assets/15018b31-7b73-413f-8b44-94dad9f02176)
BlazDT commented 18 hours ago

Broken header not reproduced, looks like something is hiding the class Standard_primary-ad-container. Please check filtering log. Other elements hidden.

rakleed commented 14 hours ago

@BlazDT you should update the rule https://github.com/AdguardTeam/AdguardFilters/commit/2c1de6e8581c1f5c2cb86d66c040a8c50637a8f1#diff-573dc3f218d8218a83deb0f9a6c1b1969b357dc584dc49ee3133ee81e890dd16R85 to

hbr.org##ul[class^="PageUtils_container"] > li:not([class*="PageUtils_standard"]):has(> [data-analytics^="share"])

because now X icon still visible.

Also in macOS app, the rule https://github.com/AdguardTeam/AdguardFilters/commit/2c1de6e8581c1f5c2cb86d66c040a8c50637a8f1#diff-e34a1d9fc96c2d698dbb2e06d11bf42bd7297804b08911de57ee498d56ce84b7R21 doesn't work at all.

And about the header - it is displayed correctly while the page is loading, but when it is completely loaded, it is overlapped by the header. Attached the saved page: hbr-org-saved-page.html.zip

BlazDT commented 13 hours ago
hbr.org##ul[class^="PageUtils_container"] > li:not([class*="PageUtils_standard"]):has(> [data-analytics^="share"])

because now X icon still visible.

Was not visible before, but now, updated.

Also in macOS app, the rule 2c1de6e#diff-e34a1d9fc96c2d698dbb2e06d11bf42bd7297804b08911de57ee498d56ce84b7R21 doesn't work at all.

Working fine on Chrome Extension, maybe bug in mac app

Regarding broken header: Mentioned class Standard_primary-ad-container__woctl has the class sf-hidden added while mine not (also has children while yours not).

@zloyden please check on Mac, thank you.

zloyden commented 2 hours ago

@BlazDT not reproduced on my end.

rakleed commented 50 minutes ago

The link to the mobile application is now always blocked after clearing the cache.

And now for some reason, the HTML of the page has changed. It comes like in https://github.com/AdguardTeam/AdguardFilters/issues/189848#issuecomment-2392135734, and then like this: hbr-org-saved-page-2.html.zip

And when you open the site every time in a new Incognito tab, the header either hides or doesn’t. As I understand it, it depends on whether the hbr.org##div[data-testid="ad-container"] rule for hiding is applied to the parent. However, I couldn’t find such a rule in the filters. Could it really be a bug?


@zloyden @BlazDT I think I found steps to reproduce the issue. If your title is displayed correctly, then:

  1. To the left of the URL in Chrome, click the settings icon (View site information).
  2. Select Cookies and site data.
  3. Then Manage on-device site data.
  4. Then delete all the data that is there.
  5. Then open the developer tools.
  6. Right-click the reload icon to the left of the URL and select Empty cache and hard reload.

I don't know if this is a browser bug related to SSG, or AdGuard.