AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.18k stars 635 forks source link

idg.se #29637

Closed adguard-bot closed 5 years ago

adguard-bot commented 5 years ago

Issue URL (Incorrect Blocking)

https://www.idg.se/

Comment

Username: @mathiasbb

Scrolling stops working when AdGuard is enabled.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/v8hXOBx.jpg)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/Pio0mQD.jpg)

System configuration

Information value
Platform: Ext
AdGuard version: 2.10.14
Browser: Chrome
Filters: EasyList,
EasyPrivacy,
Fanboy's Annoyances,
AdGuard Annoyances,
AdGuard Base,
Peter Lowe's list,
Fanboy's Enhanced Tracking List,
AdGuard Spyware
Other extensions used: Privacy Guard (no effect disabling)
THEtomaso commented 5 years ago

FYI, 'Frellwit's Swedish Filter' already contains a sublist, with highly specialized rules, which fixes this issue: https://github.com/lassekongo83/Frellwits-filter-lists/blob/master/Swedish/swe-ppd-filters.txt

If you're located in Sweden, you should subscribe to his list. You'll find it here: https://github.com/lassekongo83/Frellwits-filter-lists/ (Scroll down to "Available lists" > "Frellwits-Swedish-Filter.txt", and click on "Subscribe"!)

Alex-302 commented 5 years ago

I can't reproduce with AdGuard and our filters. @AdamWr please take a look.

THEtomaso commented 5 years ago

@AdamWr / @Alex-302:

The site freezes, because the cookie consent is blocked by the following rules (found in 'Fanboy's Annoyance List' / 'Fanboy's Cookie List'):

##.idgcp__section
###idgcp__section

So, the correct place for reporting this issue, would be here: https://github.com/ryanbr/fanboy-adblock/issues/

Of course, the most obvious fix is to simply allow the cookie consent, like this:

idg.se#@#.idgcp__section
idg.se#@##idgcp__section

But in this case, doing so will actually be a bad idea, as such exception rules will override the much better solution (found in 'Frellwit's filter', which I refered to in my previous post):

idg.se##.idgcp__modal--in .idgcp__layer:style(background: none !important;)
idg.se##.idgcp__layer--active, .idgcp__layer--active body:style(overflow: auto !important;)
idg.se##.idgcp__layer:style(z-index: 0 !important;)

These rules (which also contains other domains) blocks the cookie consent, while they still allow the site to load properly!

--

EDIT: @lassekongo83: I'm notifying you about this, to make sure that no one overrides your beautifully crafted rules! :)

AdamWr commented 5 years ago

I can reproduce it only on first visit with Fanboy's Annoyances enabled, if I disable that list, it works fine on my end.

mathiasbb commented 5 years ago

Thank you, adding Frellwits-Swedish-Filter.txt works fine.

slavaleleka commented 5 years ago

not reproducing on my end now