AdguardTeam / AdguardFilters

AdGuard Content Blocking Filters
https://adguard.com/
GNU General Public License v3.0
3.22k stars 638 forks source link

Shiftdelete—Obsolete rules #83670

Closed ghost closed 3 years ago

ghost commented 3 years ago

Shiftdelete now has a new design. So it seems current old rules not needed. I checked all rules. They don't show up in HTML and the filtering log.

Ads

shiftdelete.net##.empty-space.h40
shiftdelete.net##.banner_kutu
shiftdelete.net##iframe[src^="https://shiftdelete.net/assets/bannerz/"]
||shiftdelete.net/assets/bannerz/
shiftdelete.net##[id="300x600"]
shiftdelete.net##.banner_must_head
shiftdelete.net###adSelector

Social

shiftdelete.net##.v2Social_Shares > a[class]:not(._sreddit)
shiftdelete.net##div.yt 
shiftdelete.net##.toolbar-bottom 
~shiftdelete.net##.fa-youtube-square
shiftdelete.net##.social_share

Annoyance

shiftdelete.net##.e_magazine_mobile 
shiftdelete.net##img[title="Torrent Yasal mı? - ShiftDelete.Net"]

Mobile

shiftdelete.net##.top_banner_ad
shiftdelete.net##[class^="big_banner"]
shiftdelete.net##.mobile_ad_content
shiftdelete.net##iframe[src*="/getAd?"]

Whitelist

! https://github.com/AdguardTeam/AdguardFilters/issues/14124
@@||eotech-yoqblou5gqrdrn.netdna-ssl.com^$domain=shiftdelete.net
@@||shiftdelete.net/wp-content/themes/*_shiftdelete_net//app/mobile/dfp.js$domain=shiftdelete.net

Spyware ||shiftdelete.net/api/banner_


Update: This rule shiftdelete.net##a[href^="https://www.hepsiburada.com/"] > img doesn't work as expected. It just hides the thumbnail but ad is still there. I think it can be removed.

krystian3w commented 3 years ago

shiftdelete.net##a[href^="https://www.hepsiburada.com/"] > img

possible use :upward(1) and maybe again works.

shiftdelete.net#?#a[href^="https://www.hepsiburada.com/"] > img:upward(1)

or older :has(> ):

shiftdelete.net#?#a[href^="https://www.hepsiburada.com/"]:has(> img)

but this exclude hide ads on iOS/iPadOS and Android Content Blocker "plugin".

Alex-302 commented 3 years ago

Update: This rule shiftdelete.net##a[href^="https://www.hepsiburada.com/"] > img doesn't work as expected. It just hides the thumbnail but ad is still there. I think it can be removed.

Works fine on my end. Please make screenshot.

ghost commented 3 years ago

@Alex-302

Behavior when rule is enable:

Screenshot ![s1](https://user-images.githubusercontent.com/79805068/120712500-606a9380-c4c9-11eb-877f-4ecb16aecbd8.png)

Behavior when rule is disabled:

Screenshot ![s2](https://user-images.githubusercontent.com/79805068/120712520-682a3800-c4c9-11eb-841c-ead6264ebb60.png)

I just checked in desktop version. Maybe it works on mobile, I don't know

krystian3w commented 3 years ago

Maybe on PC this will be good:

##.thb-article-bottom-ad
##.thb-article-bottom-ad + .thb-sponsored-content-container

compatible with iOS.

Alex-302 commented 3 years ago

@Erengit Please provide URL and full screenshot. I don't see unblocked ads on iPad.

Alex-302 commented 3 years ago

Maybe on PC this will be good:

that elements already hidden.

krystian3w commented 3 years ago

Not on Erengit PC, maybe he disabled AdGuard Turkey before exclude bug with hide only photos.

https://github.com/AdguardTeam/AdguardFilters/blob/8af4d5d49d1ea2d88fa3d70c7247f1387cd0f6c3/TurkishFilter/sections/specific.txt#L66-L67

or temporary used disable rules button in AdGuard app.

Alex-302 commented 3 years ago

Will wait his reply.

ghost commented 3 years ago

@Alex-302

First, add whitelist these two rules:

shiftdelete.net#@#.thb-article-bottom-ad
shiftdelete.net#@#.thb-sponsored-content-container

Click the link below: https://shiftdelete.net/kripto-paralar-neden-dusuyor


There is an advert at the bottom of the article that directs you to Hepsiburada.

Image ![s3](https://user-images.githubusercontent.com/74098460/120865866-83fc0f80-c597-11eb-9c9c-4dc9e5772b5d.png)

This rule only blocks the thumbnails of the ad. ##a[href^="https://www.hepsiburada.com/"] > img

When rule is enable:

Image ![s1](https://user-images.githubusercontent.com/74098460/120865989-c45b8d80-c597-11eb-9214-5f1f6c3aa216.png)

When the rule is disabled:

Image ![s2](https://user-images.githubusercontent.com/74098460/120868829-924d2a00-c59d-11eb-83fd-803fbb626fa8.png)

Thumbnails appear when you disable rule. #@#a[href^="https://www.hepsiburada.com/"] > img


So actually rule is not needed because the ad is already blocked by ##.thb-article-bottom-ad and ##.thb-sponsored-content-container

krystian3w commented 3 years ago

Maybe older plugin not used thb-article-bottom-ad and on a few urls is active?

Alex-302 commented 3 years ago

ok