AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.36k stars 90 forks source link

AG v2.10 causes the frequent disconnections from Bulletin Board System (BBS). #1520

Closed lancelot-moon closed 7 years ago

lancelot-moon commented 7 years ago

@ameshkov @vbagirov

Hi,

  1. AG v2.10 causes the frequent disconnections from Bulletin Board System (BBS). BBS: https://ru.wikipedia.org/wiki/BBS

In Taiwan, many people use a mobile BBS app for visiting PTT. PTT BBS: https://en.wikipedia.org/wiki/PTT_Bulletin_Board_System

Such like: JPTT: https://play.google.com/store/apps/details?id=com.joshua.jptt

PiTT: https://play.google.com/store/apps/details?id=com.ihad.ptt

PTT+: https://play.google.com/store/apps/details?id=com.pttplus

Mo PTT: https://play.google.com/store/apps/details?id=mong.moptt&hl=zh_TW

isPTT: https://play.google.com/store/apps/details?id=com.ismiya.isptt&hl=zh_TW

PTT Hybrid: https://play.google.com/store/apps/details?id=com.bbs.reader&hl=zh_TW

BePTT: (Its developer doesn't put ads in the app. Good!) https://play.google.com/store/apps/details?id=y_studio.ka5983.ptt2&hl=zh_TW

PTTopia: https://play.google.com/store/apps/details?id=com.wisescott.breezeptt&hl=zh_TW

PTTNOW: (Website mode. Don't need an account for login. Only reading mode.) https://play.google.com/store/apps/details?id=whitebird.ptt_now&hl=zh_TW

PTT HOT: (Website mode. Don't need an account for login. Only reading mode.) https://play.google.com/store/apps/details?id=com.jiecode.ptt&hl=zh_TW

and so on.

The default port setting in those mobile BBS apps is 443. Maybe AG also uses port 443. When enabling AG, it's hard to connect to BBS. For solving the issue, we can change the port setting in those mobile BBS apps from 443 to 23 (or others) or enable Secure Shell (SSH) for connection.

SSH: https://ru.wikipedia.org/wiki/SSH

With AG v2.9, there is no disconnection when surfing on BBS. But AG v2.10 causes the frequent disconnections when using those BBS apps for surfing on BBS. May you solve it? You don't have an account for login into PTT. Maybe it's a little trouble understanding the frequent disconnections from BBS.

You can use PTTNOW or PTT HOT for viewing what PTT is. That's website mode. Don't need an account for login. But only reading mode because actually we don't login into PTT. https://www.ptt.cc/index.html

Or you can use a Windows app for visiting BBS. PCMan: http://pcman.ptt.cc/windows.html https://github.com/pcman-bbs/pcman-windows/releases/download/9.4.2/PCMan.exe Interface:

Screenshot: ![image](https://i.imgur.com/uRAG4Wu.png)

Address: ptt.cc Type "guest" for login into PTT. But you are usually unable to login into PTT because there are limited connections for guest accounts. Only try more times when Taiwanese people are sleeping... (Moscow time 20:00 PM ~ 01:00 AM) There should be more chances to login into PTT with a guest account during that period. After login into PTT, this is the operating interface. There were 87379 accounts online. There are also some articles about AdGuard on PTT. AdGuard is popular for Taiwanese net friends.
Screenshot: ![image](https://i.imgur.com/OBtj45f.png)

@AdamWr 2. Block ads in those mobile BBS apps. Please add the under ad domains or path into AG filter. ||graph.facebook.com/network_ads_common^ ||pagead2.googlesyndication.com^ ||ad-specs.guoshipartners.com^ ||ad2iction.com^ ||ads.mopub.com^ ||aotter.net^ ||doubleclick.net^ Thanks a lot!
ameshkov commented 7 years ago

How does the disconnection look like?

lancelot-moon commented 7 years ago

Hi, For example, I enable AG v2.10 and then use JPTT app for login into PTT (BBS). When I read articles on PTT, JPTT app suddenly shows "disconnection occurred". On the above of JPTT, it shows a red banner which reminds "disconnection occurred". But I'm unable to save the screenshot in time. It's because JPTT app will soon automatically re-connect to PTT. On the above of JPTT, it soon changes to show an orange banner which reminds "connecting (連線中)". Such as the below.

Screenshot: ![image](https://i.imgur.com/DAv8cQK.jpg)

Use PTT+ app. When disconnection occurred, PTT+ app showed "disconnection, tap to recover connection (連線中斷, 點擊恢復連線)".
Screenshot: ![image](https://i.imgur.com/Bj5jafj.jpg)

Even AG v2.10 causes disconnections when I play mobile games.
AdamWr commented 7 years ago

Please add the under ad domains or path into AG filter. ||graph.facebook.com/network_ads_common^ ||pagead2.googlesyndication.com^ ||ad-specs.guoshipartners.com^ ||ad2iction.com^ ||ads.mopub.com^ ||aotter.net^ ||doubleclick.net^

||graph.facebook.com/network_ads_common^ - we have wider rule in our Mobile ads filter. ||pagead2.googlesyndication.com^,||ads.mopub.com^ ,||doubleclick.net^ - we have these rules in filter. ||ads.ad2iction.com^ - this rule is in Simplified domain names filter/AdGuard DNS

||aotter.net^ - it doesn't look like only ads domain, could you please tell me in which app there are ads from this domain?

Added: ||ad-specs.guoshipartners.com^

lancelot-moon commented 7 years ago

Hi, Those are mobile BBS apps' ad domains. BBS: https://en.wikipedia.org/wiki/Bulletin_board_system

After you login into BBS, you can see those ads in the mobile BBS app.

"graph.facebook.com/network_ads_common" is one of PTT+'s ad domains. Ad in PTT+:

Screenshot: ![image](https://i.imgur.com/J2i87sZ.jpg)

You know that viewing facebook might be abnormal if blocking graph.facebook.com. I found the ad path. If blocking graph.facebook.com/network_ads_common, PTT+ has no ad. Android version of AdGuard can not only block domains but also paths. "aotter.net" has not only ads but also trackers. You should block it. "aotter.net" is JPTT, MO PTT and PTTNOW's ads and trackers domain. I already added it in my blacklist. https://imgur.com/a/aDPV4 Another thing... Have you add "m.104.com.tw/api/1.0/ad/" in your filter? https://github.com/AdguardTeam/AdguardForiOS/issues/496 It's because I ever tried to search "m.104.com.tw/api/1.0/ad/" in your filters. But I didn't find that path in your filters. B/R
AdamWr commented 7 years ago

Hi, We have this rule: ||graph.facebook.com/network_ads in Mobile Ads filter, so in my opinion it is not necessary to add this: ||graph.facebook.com/network_ads_common^

"aotter.net" has not only ads but also trackers.

I mean that they have "normal" website, for example - https://agirls.aotter.net/post/51953 which will be broken if I add this rule. If you add ||aotter.net^$third-party ads are blocked?

I will install PTT+ and PTTNOW and check, but I need some time for it. By the way, please next time report ads here - https://github.com/AdguardTeam/AdguardFilters/issues

lancelot-moon commented 7 years ago

Hi,

You can try MO PTT. https://play.google.com/store/apps/details?id=mong.moptt&hl=zh_TW

But you don't have an account for login into PTT BBS. It's trouble understanding where ads are in app.

Or you can try PTTNOW. (Website mode. Don't need an account for login. Only reading mode.)

After adding ||aotter.net^$third-party in my user filter, ads are Not blocked. Sorry AdamWr, Before you added tkmftc.aotter.net in Mobile ads filter, the ad was not blocked. I didn't notice that although I cancelled to tick aotter.net in advance in my user filter at that time, the rule (||aotter.net^) was still ticked after I reopened AdGuard. A bug. I saw the ad was blocked because aotter.net is blocked in my user filter. It was not because the rule "||aotter.net^$third-party" was working.

Sorry, I'll report ads there next time.

AdamWr commented 7 years ago

Another thing... Have you add "m.104.com.tw/api/1.0/ad/" in your filter? AdguardTeam/AdguardForiOS#496

Yes, this rule was added - https://github.com/AdguardTeam/AdguardFilters/blob/692201f17dd66ec2a2e7c5193baa51a117e5a6bd/MobileFilter/sections/specific_app.txt#L69

lancelot-moon commented 7 years ago

@ameshkov

Hi ameshkov,

I update AdGuard to v2.10.164 RC. But the disconnection from BBS after I login into BBS still occurs. Do you need helps? Can Russian people understand what BBS is? BBS is a social community, such like facebook and VK.

In Taiwan, some universities' students establish BBS on servers. PTT BBS is only one of them, but it's the biggest BBS in Taiwan. Around or over one hundred thousand people on PTT BBS.

ameshkov commented 7 years ago

We understand, it's just the problem seems rather complicated, the fix is planned for v2.11.

Temporary solution would be to disable AG for BBS until the fix arrives.

lancelot-moon commented 7 years ago

Hi ameshkov, If necessary, I can privately lend you an account for login into PTT BBS by email. aalpatkina knows my email address. You can let aalpatkina give me your email address.

Or if you can solve the issue without a PTT BBS account for test, it's ok.

Hope that the disconnections from BBS can be solved in v2.11. Temporary solution... we suggest using v2.9.

I have another question. The default port setting in those mobile BBS apps (JPTT, Mo PTT and so on) is 443. When enabling AdGuard, those mobile BBS apps are hard to connect to BBS. For solving the issue, we can change the port setting in those mobile BBS apps from 443 to 23 (or others) or enable Secure Shell (SSH) for connection. Is it because AdGuard's local VPN immovably also uses port 443?

Thanks for your great work!

ameshkov commented 7 years ago

For solving the issue, we can change the port setting in those mobile BBS apps from 443 to 23 (or others) or enable Secure Shell (SSH) for connection. Is it because AdGuard's local VPN immovably also uses port 443?

No, that's because AG does not filter connections to ports less than 80

lancelot-moon commented 7 years ago

No, that's because AG does not filter connections to ports less than 80

Really?

As what you have known, the default port setting in those mobile BBS apps (JPTT, Mo PTT and so on) is 443. Except for port 443, port 23 is also available. Using other ports causes failed connection. If we don't change the port 443 setting in those mobile BBS apps in advance, we are unable to connect to BBS. Or we don't need to change port 443. Some mobile BBS apps provide Secure Shell (SSH) for connection. SSH: https://ru.wikipedia.org/wiki/SSH

After enabling SSE for connection, we can connect to BBS via mobile BBS apps. Does AdGuard not filter SSH?

You said that AG does not filter connections to ports less than 80. But AdGuard actually filters ads after we use port 23 or SSH connection for login into BBS. Do you not need an PTT BBS account for test?

Use Mo PTT app (port 23). MO PTT app's ad domains: flurry.com doubleclick.net aotter.net

Without AdGuard: You can see ads banners in Mo PTT app. https://imgur.com/a/RjEs2

With AdGuard: No ad. AG still filters ads even if I use port 23 in Mo PTT app. https://imgur.com/a/qCZmb

B/R

ameshkov commented 7 years ago

Port 23 is used for the BBS connection, but not for third-party connections (ads and tracking), that's why they are blocked okay.

lancelot-moon commented 7 years ago

Port 23 is used for the BBS connection, but not for third-party connections (ads and tracking), that's why they are blocked okay.

Thanks for broadening my horizon.

I'm using AdGuard for Android v.2.10.164 RC. AdGuard still causes disconnections from BBS in MO PTT app and other mobile BBS apps. This is the screenshot of MO PTT app when the disconnection occurred.

Screenshot: ![image](https://i.imgur.com/ih7em9J.png)

MO PTT app doesn't provide automatic re-connecting. That means: "Oh! There is something wrong which causes the disconnection. Wish to re-connect?" I knew that the repair is planned for v2.11. AG v.2.9 doesn't cause disconnections from BBS. Why does AG v.2.10 cause disconnections from BBS? Hope that the issue also doesn't happen in the next version of AdGuard Pro for iOS. Those mobile BBS apps are Traditional Chinese interface. If you need helps, please let me know. Thanks a lot!
lancelot-moon commented 7 years ago

Ah, Some Taiwanese net friends don't know that they need to change a mobile BBS app's port setting or enable SSE for login into BBS with AdGuard. May you design that AG doesn't block the BBS connection but ads when using port 443? It's better.

Thank you. :3

Eh, Did aalpatkina tell that I held an activity of randomly draw lots AdGuard free 1 year licenses for Taiwanese net friends on PTT BBS?

Thank AdGuard very much for the patronage! )))

lancelot-moon commented 7 years ago

@AdamWr

lancelot-moon:

Please add the under ad domains or path into AG filter. ||graph.facebook.com/network_ads_common^ ||pagead2.googlesyndication.com^ ||ad-specs.guoshipartners.com^ ||ad2iction.com^ ||ads.mopub.com^ ||aotter.net^ ||doubleclick.net^

AdamWr:

||pagead2.googlesyndication.com^,||ads.mopub.com^ ,||doubleclick.net^ - we have these rules in filter.

Hi AdamWr,

isPTT: https://play.google.com/store/apps/details?id=com.ismiya.isptt&hl=zh_TW

pagead2.googlesyndication.com is one of isPTT's ad domains. It's in AdGuard English filter and other filters, but not in Simplified domain names filter. It causes AdGuard for Android can block ads from pagead2.googlesyndication.com, but AdGuard Pro for iOS with AdGuard DNS server can't block them. (I already checked that ad-specs.guoshipartners.com, ad2iction.com, ads.mopub.com and doubleclick.net are in Simplified domain names filter.)

I also reported some missed ad domains in the section of AdguardFilters last weekend. https://github.com/AdguardTeam/AdguardFilters/issues/7595 https://github.com/AdguardTeam/AdguardFilters/issues/7596 https://github.com/AdguardTeam/AdguardFilters/issues/7593

Maybe you'll add them in English filter or Mobile ads filter. May you also not forget to add all of them in Simplified domain names filter (AdGuard DNS server) for iOS users?

Thanks a lot!

lancelot-moon commented 7 years ago

@ameshkov @AdamWr

Hi,

You can try Mo PTT for login as a guest. Mo PTT: A mobile BBS app. for iOS: https://itunes.apple.com/tw/app/mo-ptt/id804745434?l=zh&mt=8

for Android: https://play.google.com/store/apps/details?id=mong.moptt&hl=zh_TW

Please click "我沒有帳號,路過看看". It means: "I don't have an account. Visit as a guest."

Screenshot: ![image](https://i.imgur.com/vjUAbPU.png)

After entering PTT BBS, the message tells that you only can read articles and don't have complete features because you don't have an account. Click "確定" (Ok).
Screenshot: ![image](https://i.imgur.com/7squNy0.png)

Mo PTT has added some boards in the favorites.
Screenshot: ![image](https://i.imgur.com/5ldJwGT.png)

For example: Visit Android board. You can read my article whose date is 3rd November on Android board of PTT BBS.
Screenshot: ![image](https://i.imgur.com/7SHbEQ9.jpg)

If you want to visit the total boards for reading more articles on PTT BBS, you click "Classified boards".
Screenshot: ![image](https://i.imgur.com/HpAR73F.png)

But it's strange that the disconnection from BBS seems not occur if login as a guest via Mo PTT app with AdGuard. If having an account for login into PTT BBS, stay on PTT BBS and wait for some time, and then the disconnection from BBS occurred via Mo PTT app with AdGuard. This is the screenshot of MO PTT app when the disconnection occurred. MO PTT app doesn't provide automatic re-connecting. That message means: "Oh! There is something wrong which causes the disconnection. Wish to re-connect?"
Screenshot: ![image](https://i.imgur.com/ih7em9J.png)

Click "主選單"(Main menu). If you have an account, more features. Well, click "設定"(Setting).
Screenshot: ![image](https://i.imgur.com/vsnHivq.png)

AdGuard for Android and AdGuard Pro for iOS cause the hard connection to BBS. 2 solutions. 1. Don't need to change the default port 443. Use SSH connection. SSH: https://ru.wikipedia.org/wiki/SSH
Screenshot: ![image](https://i.imgur.com/DXhHnrG.png)

2. Need to modify the default port 443 to 23 or 3000~3010.
Screenshot: ![image](https://i.imgur.com/p2CGHYy.png)

If using other port numbers except for port 443, 23 or 3000~3010, it may let us not connect to BBS.
Screenshot: ![image](https://i.imgur.com/IiI5nS6.png)

If you already enabled AdGuard before login into BBS, you need to first go to setting for enabling SSH connection or changing to use port 23 or 3000~3010.
Screenshot: ![image](https://i.imgur.com/vjUAbPU.png)

If needing any helps, please let me know. Thanks for your great work!
ameshkov commented 7 years ago

This bug should be resolved in the coming patch.

Probably caused by this: https://github.com/AdguardTeam/AdguardForAndroid/issues/1547#issuecomment-344866651

lancelot-moon commented 7 years ago

‧★,::‧( ̄▽ ̄)/‧:‧°★*

Hi, Thanks for your great work! (  ̄□ ̄)/ <( ̄ㄧ ̄ ) <( ̄ㄧ ̄ ) отдать честь https://github.com/AdguardTeam/AdguardForAndroid/releases Now the latest version of AdGuard for Android is v2.10.164. Will the 2.10 patch be used in the next version of v2.10 beta? I'll try if it's valid. B/R

lancelot-moon commented 7 years ago

Hi,

I updated to v2.10.171 RC. https://github.com/AdguardTeam/AdguardForAndroid/releases/tag/v2.10.171-rc

It's valid. There is already no disconnection from BBS. Thank you very much!

You had known that if enabling AdGuard before login into BBS, we need to first go to setting for enabling SSH connection or changing to use port 23 on those mobile BBS apps. Is it possible that we don't need to enable SSH connection or change to use port 23 for login into BBS with AdGuard for Android / AdGuard Pro for iOS?

B/R

ameshkov commented 7 years ago

Should we disable HTTPS filtering for these apps by default?

lancelot-moon commented 7 years ago

Hi,

I disabled AdGuard's HTTPS filtering in advance. And then I tried to login into BBS via the default port setting 443 without SSH connection. If using JPTT, I have to wait for 2 minutes for login. The waiting time is too long.

If using Mo PTT, I was unable to connect to BBS server. Mo PTT showed the error, "Oh! The server has no response, please try again later."

Disabling HTTPS filtering is absolutely not the solution. A risk of being unable to connect to PTT BBS.