AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.3k stars 89 forks source link

Add "Certificate status" dialog window with install/move/remove options #1698

Closed ameshkov closed 6 years ago

ameshkov commented 6 years ago

Tap on the certificate status item should bring up a dialog window with a couple of options. The options depend on the current certificate state and root access.

Not installed state

Installed state (user store)

Depending on the root access, we should show different text there.

With root: Removes the certificate from the trusted credentials. Without root: Security settings will be opened. Find "trusted credentials", switch to "user" tab and remove AdGuard certificate.

Installed state (system store)

We no more need Alternative way to install certificate and Install certificate into the Firefox browser items on the main HTTPS filtering screen so you can safely remove them from there.

Regarding moving certificate, you can inspire by how it's done here: https://github.com/Nutomic/movecerts You cannot reuse a single line of code from there, though, as it's a GPL.

nkartyshov commented 6 years ago

done

ameshkov commented 6 years ago

I've got a bug report regarding certificate removal:

Cert installation/uninstallation is a little wonky. I click remove and it says success, but then I go back and it says still it's installed into the System store

nkartyshov commented 6 years ago

done