search

AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.36k stars 90 forks source link

Moving certificate to the system store does not work on some devices #1827

Closed ameshkov closed 6 years ago

ameshkov commented 6 years ago

One complaint: http://4pda.ru/forum/index.php?s=&showtopic=601691&view=findpost&p=72083643

Another one: https://forum.xda-developers.com/showpost.php?p=76234465&postcount=3088

You'll need to ask users for logs to figure what's wrong.

yochananmarqos commented 6 years ago

The reason why it didn't work for the guy on XDA is because he's using Magisk. The system is not mounted r/w. I wrote a Magisk module to move the certificate to the system store attached here.

EDIT: It's now in the Magisk repo as Move Certificates.

ghost commented 6 years ago

@yochananmarqos Thanks! It worked perfectly. And it worked better than Move Certs.

carlylemiii commented 6 years ago

The reason why it didn't work for the guy on XDA is because he's using Magisk.

I use Magisk... AG moves it fine for me.

yochananmarqos commented 6 years ago

@carlylemiii Then you're using something besides Magisk that is allowing /system to be mounted r/w.

carlylemiii commented 6 years ago

Then you're using something besides Magisk that is allowing /system to be mounted r/w

Nope. Magisk 16.0 on a Pixel 2 XL, and no modules. Or, at least, AdGuard shows it as being in the system store, and it shows up under the SYSTEM tab under the device's Trusted Credentials. I DO still get the "Network may be monitored", it may be worth noting. Just throwing all this out there for another data point.

Edit: A reboot took care of that, actually. 😮

p00h commented 6 years ago

I can confirm the module is usefull. Xiaomi MI5s, Mokee ROM based on Android 7.1.2. I've installed module and the CA seems to be moved into the system storage.