search

AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.31k stars 89 forks source link

update automation exception in latest nightly #2383

Closed patrickdrd closed 5 years ago

patrickdrd commented 5 years ago

so I tried to start update action, according to this: https://kb.adguard.com/en/android/solving-problems/tasker

and I got the following exception: java.lang.RuntimeException: Unable to start receiver com.adguard.android.receivers.AutomationReceiver: android.os.NetworkOnMainThreadException at android.app.ActivityThread.handleReceiver(ActivityThread.java:3087) ~[na:0.0] at android.app.ActivityThread.-wrap18(ActivityThread.java) ~[na:0.0] at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1591) ~[na:0.0] at android.os.Handler.dispatchMessage(Handler.java:102) ~[na:0.0] at android.os.Looper.loop(Looper.java:154) ~[na:0.0] at android.app.ActivityThread.main(ActivityThread.java:6236) ~[na:0.0] at java.lang.reflect.Method.invoke(Native Method) ~[na:0.0] at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:891) ~[na:0.0] at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:781) ~[na:0.0] at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:103) ~[na:na] Caused by: android.os.NetworkOnMainThreadException: null at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1303) ~[na:0.0] at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:86) ~[na:0.0] at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:74) ~[na:0.0] at java.net.InetAddress.getAllByName(InetAddress.java:752) ~[na:0.0] at com.android.okhttp.internal.Network$1.resolveInetAddresses(Network.java:29) ~[na:0.0] at com.android.okhttp.internal.http.RouteSelector.resetNextInetSocketAddress(RouteSelector.java:187) ~[na:0.0] at com.android.okhttp.internal.http.RouteSelector.nextProxy(RouteSelector.java:156) ~[na:0.0] at com.android.okhttp.internal.http.RouteSelector.next(RouteSelector.java:98) ~[na:0.0] at com.android.okhttp.internal.http.HttpEngine.createNextConnection(HttpEngine.java:346) ~[na:0.0] at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:329) ~[na:0.0] at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:247) ~[na:0.0] at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:457) ~[na:0.0] at com.android.okhttp.internal.huc.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:126) ~[na:0.0] at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.connect(DelegatingHttpsURLConnection.java:89) ~[na:0.0] at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java) ~[na:0.0] at com.adguard.commons.d.e.a(UrlUtils.java:537) ~[na:0.0] at com.adguard.commons.d.e.f(UrlUtils.java:490) ~[na:0.0] at com.adguard.android.a.b.b(ServiceApiClient.java:367) ~[na:0.0] at com.adguard.android.a.b.b(ServiceApiClient.java:213) ~[na:0.0] at com.adguard.android.service.n.c(FilterServiceImpl.java:598) ~[na:0.0] at com.adguard.android.service.n.b(FilterServiceImpl.java:171) ~[na:0.0] at com.adguard.android.receivers.AutomationReceiver.onReceive(AutomationReceiver.java:95) ~[na:0.0] at android.app.ActivityThread.handleReceiver(ActivityThread.java:3080) ~[na:0.0] ... 9 common frames omitted

I'm running AG with dns on (adguard regular), https filtering on and VPN mode

Revertron commented 5 years ago

Thanks, it's quite easy to fix. The fix will be in next nightly.

nkartyshov commented 5 years ago

Fixed

Test instruction:

  1. Install AdGuard
  2. Install Tasker
  3. Add task for the filters update

Expected result: The filters should updated by task