search

AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.37k stars 90 forks source link

Update default HTTPS exclusions list automatically #368

Open vozersky opened 8 years ago

vozersky commented 8 years ago

Comments regarding 2.5.39 alpha: "The https whitelist is only updated on a clean install.There's also no way to reset the https whitelist through the UI, for testing this new build I had to extract the whitelist from the apk and copy over its content(after emptying the old whitelist first)."

Suggestion: The lists are reset to default after an update. Also look into a way to properly merge the user edited lists with the new defaults

Revertron commented 8 years ago

I think we must redesign those lists to a full-featured Activities with buttons like "Clear", "Default" and so on.

ameshkov commented 8 years ago

Merging these lists will be a pain.

Also I am not sure if we should really merge if user has edited that list. What if he wanted to have it empty?

TPS commented 8 years ago

@ameshkov

Merging these lists will be a pain. Also I am not sure if we should really merge if user has edited that list.

Maybe, like the current filterlists, maybe there should be 2 sets of white-/blacklists? I.E., AG's own preloaded 1s (if, included in #25, which will be online updatable, like the filterlists currently), which you can merge or overwrite as you choose (especially if delta updating becomes a thing), & then the user's own, which are left to the user to manage.

TPS commented 8 years ago

@ameshkov

What if he wanted to have it empty?

Also, just like current filterlists, the preloaded white-/blacklists above should be togglable off as the user prefers.

ameshkov commented 8 years ago

Maybe, like the current filterlists, maybe there should be 2 sets of white-/blacklists? Also, just like current filterlists, the preloaded white-/blacklists above should be togglable off as the user prefers.

This becomes too complex for such a rarely used feature:)

Usually almost nobody edits a whitelist. What for the blacklist, the situation is very different. It is supposed to be filled by a user, and I guess he or she may be upset if we merge something new into it.

On the other hand, I think we really lack "reset lists" option as it's rather easy to clean it accidentally and no easy way to return it back.

ameshkov commented 7 years ago

Assigned to v2.10.

ameshkov commented 6 years ago

@nkartyshov Here's what we need to do in order to implement this:

Server side

  1. Introduce an HTTPS whitelist version
  2. Serve the files it from the filters.adtidy.org server

Client side

  1. Divide the SSL whitelist into two parts: user-defined and default (updateable) list
  2. Do not store it in preferences anymore (handle the app update appropriately).
  3. The user-defined part should be in the diff format (as you can either add or remove a domain to the list)
  4. Leave the UI as it is now (just calculate the diff properly). We'd better not spend time on UI at the moment.
ameshkov commented 6 years ago

Actually, let's divide it again into two different tasks :)

I am still not sure if updating that list is okay from the user perspective. With that approach one day we can remove all domains from the whitelist (we won't of course, but we CAN)

ameshkov commented 6 years ago

Moved client-side tasks here: https://github.com/AdguardTeam/AdguardForAndroid/issues/1748

Moved auto-update further to v3.0 milestone.