No indication that HTTPS filtering should not be enabled for an app

ameshkov commented 1 year ago

Please answer the following questions for yourself before submitting an issue.

[X] I am running the latest version
[X] I checked the documentation and found no answer
[X] I checked to make sure that this issue has not already been filed

AdGuard version

4.0 Nightly 39

Environment

- OS: Android 13
- Device: Xiaomi phone

Root access

[ ] Yes, I have it.

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Generally, AdGuard should indicate if there's an issue with an app because of which this or that feature cannot (or should not) be enabled.

Talking about HTTPS filtering, not every app supports it when the certificate is in the User store. In the previous version we indicated that there's an issue by showing a dialog that explained the situation and asked the user again.

In v4.0 we should further improve this approach and use it not just for HTTPS filtering, but for App management (routing), Ad blocking, etc.

HTTPS filtered apps. We should indicate that filtering cannot (or should not) be enabled for an app. Internally, we have a list of apps that support HTTPS filtering, all others do not.
App management -> HTTPS filtering switch (same thing as HTTPS filtered apps)
App management -> Route traffic through AdGuard. Internally, we have a list of exceptions, the apps that we do not route through AdGuard by default. We usually also have an issue on Github about such an app and it would be nice to mention that issue in the warning text. There's also a low-level setting that should be taken into account.
Filtered apps. The same thing as with "Route traffic", we have a list of exceptions internally for which AdGuard won't do content filtering. We also usually have a link to a Github issue that we could mention to the user.
App management -> Content filtering (same thing as Filtered apps).

Expected Behavior

No response

Screenshots

No response

Additional Information

No response

DandelionSprout commented 6 months ago

Having been moved here by ESurina, despite my issue report visibly not being a duplicate at all:

All of the points in Issue Details above would strongly need to have a root-check and an "Android version"-check, to help determine which apps that can be filtered, and which ones cannot.

An app that can be filtered with root, may very well not be able to be filtered without root, even more so for "HTTPS filtering".

ameshkov commented 6 months ago

I don't get it, the point of this issue is pretty much the same as in yours -- prevent people from accidentally enabling HTTPS filtering when it can cause trouble.

DandelionSprout commented 6 months ago

Hmm, I suppose so. It was just that the points in "Issue Details" above looked to me like they relied on hardcoded blacklists of unsuited apps regardless of root, whereas my idea (mostly?) involved disallowing users from turning on HTTPS Filtering in non-browser apps if the ''AdGuard for Android'' app detected a lack of root.

ameshkov commented 6 months ago

It's just this issue covers more than just the HTTPS filtering, it also covers known issues.

AdguardTeam / AdguardForAndroid