AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.36k stars 90 forks source link

Removing app from Custom firewall rules removes another app when there are 2 or more apps on the list #4917

Open ESurina opened 1 year ago

ESurina commented 1 year ago

Please answer the following questions for yourself before submitting an issue.

AdGuard version

4.2 Nightly

Environment

- OS: Android 12
- Device: Xiaomi
- Firmware:

Root access

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Protection -> Firewall -> Custom firewall rules
  2. Add 5 apps
  3. Try to delete the first app

Expected Behavior

The first app on the list is deleted.

Actual Behavior

The third app on the list is deleted.

Screenshots

Screenshot 1:

Additional Information

This also happens when you try to delete the second and the last app (also sometimes the penultimate app) on the list. This happens when there are 5 or more apps on the list.

Also the problem when there are 2 or more apps on the list is:

  1. Delete the last app on the list by swiping to the left
  2. Tap Back
  3. Open Custom firewall rules tab Deleted app appears on the list and another app is removed.
ESurina commented 1 year ago

Extra from @binarweb : The default settings for "Global firewall rules" is set to block all connections. Another customization for the settings are the ones from the first time opening wizard. I start an internet connection via Wi-Fi of mobile data. The Adguard is running and is prompting me (via notifications) to allow access to most of the apps that wants to access the internet. I disregard the notifications and I manually allow access to an app via "Quick actions" from "Firewall" or by "Custom firewall rules" and by adding it manually via "+ Add app". Then I'm checking all the "Applied custom rules" for the app.

The issue is not always appearing, but most of the times (about 30% of the times). While the app has been added by the step above and the icon is clearly the app I wanted, the app doesn't have internet access while another app has internet access instead (the wrong app that has now access to the internet starts to show notifications).

PavelParkhomenko commented 6 months ago

Issue replicable on Mi 8 Lite, MIUI 12, Android 10 in 4.4 Nightly 47. See attached video https://github.com/AdguardTeam/AdguardForAndroid/assets/104919935/8c298320-48cf-4279-ad0d-00960195ac83

PavelParkhomenko commented 6 months ago

903245 crm The issue is also reported by a user on the Samsung Galaxy S23 (Android 14; 4.4 Nightly 47)