AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.31k stars 89 forks source link

Add application filter by "Route traffic through AdGuard" #5014

Closed Peter-maximus closed 5 months ago

Peter-maximus commented 11 months ago

Please answer the following questions for yourself before submitting an issue.

AdGuard version

4.1.101

Environment

- OS:Android 10
- Device: OnePlus

Root access

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

In Adguard 4.x in app list (tab app management) there is no clear visibility which apps are excluded from filtering. You have to click each and every app in the list to open new window to show its filtering state.

In Adguard 3.x there was clear visibility of filtering state of particular app by small colorful icons near the app name. So to find excluded apps it was enough to scroll down the list of apps and find the apps with red icons.

Expected Behavior

Please add back the previous feature or even better enable filtering or at least sorting of apps in the app management list by its state (excluded / included in filtering)

Actual Behavior

See issue details.

Screenshots

Screenshot 1:

Additional Information

No response

maxikuzmin commented 11 months ago

@Peter-maximus in version 4 you can conveniently see filtered apps in the "HTTPS-filtered apps" list. Just go to Settings tab -> Filtering -> Network -> HTTPS filtering -> HTTPS-filtered apps

Peter-maximus commented 11 months ago

Unfortunately it shows just state of HTTPS filtering for apps (thx for this hint to HTTPS filtering "secret" menu) However I need to see the state of AdGuard routing for each and every app ("Route traffic through AdGuard checkbox").

Is anywhere such a "secret menu" for this state?

If not, please add back this view from v3.x or even better please enable filtering or at least sorting of apps in the app management list by its state (route traffic through AdGuard disabled / enabled)

Peter-maximus commented 11 months ago

any update please?

maxikuzmin commented 11 months ago

@Peter-maximus thanks for the long wait. We have changed the status of the issue to "Feature request", let's see how many likes this issue gets

Peter-maximus commented 11 months ago

apologize, but such a feature is crucial…

i believe it is very important to know which apps are routed through AdGuard and which not…

This was without any notice removed in the latest version, which should be better, not worse than previous one.

artemiv4nov commented 11 months ago

@Peter-maximus Hi! Try the following app path: Protection -> Ad blocking -> Filtered apps (or something like that). It's related to filtering (ad blocking) screen.

Peter-maximus commented 11 months ago

apologize, but i am talking about something completely different.

some apps doesn't work correctly if routed through adguard even if they are whitelisted for adblocking.

please read complete description of the issue above.

let me know if more info is needed.

thx a lot.

From: Artyom Ivanov @.*** Sent: 03 November 2023 17:09 To: AdguardTeam/AdguardForAndroid Cc: Peter-maximus; Mention Subject: Re: [AdguardTeam/AdguardForAndroid] Missing apps whitelist (Issue #5014)

@Peter-maximus https://github.com/Peter-maximus Hi! Try the following app path: Protection -> Ad blocking -> Filtered apps (or something like that). It's related to filtering (ad blocking) screen.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5014#issuecomment-1792715245 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ARRIL6KDEFTVUTBGQVFWVXTYCUJIBAVCNFSM6AAAAAA5YREHVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJSG4YTKMRUGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ARRIL6JVJRN6EZPDJUTJN2TYCUJIBA5CNFSM6AAAAAA5YREHVCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTK3KU62.gif Message ID: @.***>

artemiv4nov commented 10 months ago

Ah, so you want not just an ad blocking filtering state but the routing state (complete filtering). Well, we are working on app management improvements just like you imagine: maybe represented icons, maybe something else. Please follow the task updates.

Peter-maximus commented 10 months ago

the cleanest and easiest way would be to implement filter to app list view (e.g. by routing state). this way you don't need to add any addtional icons.

aleclerc7 commented 7 months ago

+1 It would be nice indeed to have a color or icon to mark those apps that have special settings, and those that are completely bypassing the filter because altogether disabled. This would make it easy to see at a glance which app has specific behavior or is out of the filters. Thank you very much!

PavelParkhomenko commented 5 months ago

Unfortunately it shows just state of HTTPS filtering for apps (thx for this hint to HTTPS filtering "secret" menu) However I need to see the state of AdGuard routing for each and every app ("Route traffic through AdGuard checkbox").

Is anywhere such a "secret menu" for this state?

Hello! Could you kindly review the menu by navigating through: Settings -> Filtering -> Network -> Proxy -> Apps operating through proxy? It appears to match your description precisely.

Additionally, we're actively exploring the possibility of introducing indicators for the status of individual apps within the "App management" section, as per your original suggestion.

PavelParkhomenko commented 5 months ago

This issue is now closed. For future reference, please monitor the status of the request at this link: https://github.com/AdguardTeam/AdguardForAndroid/issues/5286