AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.31k stars 89 forks source link

When adding filters other than adguard dns to dns filters it blocks sites that arent in the list #5077

Closed jordanswrld94 closed 10 months ago

jordanswrld94 commented 10 months ago

Please answer the following questions for yourself before submitting an issue.

AdGuard version

4.3

Environment

- OS: android 13
- Device: galaxy s23 ultra

Root access

What filters do you have enabled?

AdGuard Base filter, AdGuard Mobile Ads filter, AdGuard Tracking Protection filter, AdGuard URL Tracking filter, AdGuard Social Media filter, AdGuard Annoyances filter, AdGuard DNS filter

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Add adguard base filter to dns filter section
  2. Visit duckduckgo.com
  3. Site is blocked

Expected Behavior

Site not be blocked

Actual Behavior

Site blocked

Screenshots

Screenshot_20231112_150816_AdGuard

Additional Information

No response

jordanswrld94 commented 10 months ago

@maxikuzmin can you reproduce this?

jordanswrld94 commented 10 months ago

Also.happens with easylist

jordanswrld94 commented 10 months ago

This issue does not occur on android 4.2 only 4.3 nightly

jordanswrld94 commented 10 months ago

I tried old versions. Looks like everything worked fine up until 4.3 nightly 23

maxikuzmin commented 10 months ago

@jordanswrld94 checked also on the latest nightly version, but I didn't have this problem again. I tried with AdGuard Base filter, without this filter, and also tried with adding another filter, but the site is not blocked. In your case access to the site is restricted for a long time, or it only happens for a short period of time?

jordanswrld94 commented 10 months ago

Hmm thats so weird.. it happens even with a fresh set of settings. Its a permanent block. As long as i have other filters enabled it is blocked

maxikuzmin commented 10 months ago

@jordanswrld94 please also send debug logs with reproduction times to devteam@adguard.com

jordanswrld94 commented 10 months ago

Sent

jordanswrld94 commented 10 months ago

I found it. Its blocking because of a cosmetic rule? Thats so weird

jordanswrld94 commented 10 months ago

The weird thing is that nightly 22 it doesnt do that. I will just stick with nightly 22 until it can be fixed. But i do see the only thing that changed code wise between nightly 22 and 23 is dns libs. So it has to do with that im guessing?

maxikuzmin commented 10 months ago

@jordanswrld94 could you please clarify which filter you are adding to the DNS filters module? You can post a link to add this filter

jordanswrld94 commented 10 months ago

https://ibb.co/DYLfqNp https://ibb.co/k6LsFzs

Here is a screenshot ofnthe filters im using

maxikuzmin commented 10 months ago

@jordanswrld94 I'm not quite following you. Are you adding basic AdGuard filters to the DNS section?

jordanswrld94 commented 10 months ago

Yes just adding the ones from the adblocking filters section.

maxikuzmin commented 10 months ago

@jordanswrld94 why are you adding these filters to DNS filters? Those filters are in the Filters section, and you can enable them there

jordanswrld94 commented 10 months ago

Because i want to block them on dns level aswell

maxikuzmin commented 10 months ago

@jordanswrld94 but including filters in "Filters" is enough. There is a DNS filter in the DNS section, Easylist and Basic filter are included there. The filters you add to the DNS section are not intended for DNS filtering, it will have no effect. It's most likely this combination that is blocking access to sites.

Here is what will work for you. Don't forget to select RAW. You can read more about how DNS filters work here and here Read more about the syntax here

jordanswrld94 commented 10 months ago

Ok. Thankyou.

maxikuzmin commented 10 months ago

@jordanswrld94 btw, maybe this is triggering the duplicate rules you opened another issue about. Please try leaving only DNS filters in the DNS section, and repeat that issue. Let me know the results in the issue about duplicate rules