search

AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.3k stars 89 forks source link

App management is very slow when changing App firewall settings #5432

Open shriganesh opened 4 weeks ago

shriganesh commented 4 weeks ago

Please answer the following questions for yourself before submitting an issue

AdGuard version

4.6.1

Environment

HTTPS filtering

Root access

Integration with AdGuard VPN

Routing mode

Local VPN

Ad Blocking

AdGuard Base filter, AdGuard Mobile Ads filter

Privacy

AdGuard Tracking Protection filter, AdGuard URL Tracking filter

Social

AdGuard Social Media filter

Annoyances

AdGuard Annoyances filter, AdGuard Cookie Notices filter, AdGuard Popups filter, AdGuard Mobile App Banners filter, AdGuard Other Annoyances filter, AdGuard Widgets filter, Adblock Warning Removal List

Security

Online Malicious URL Blocklist

Language-specific

No response

Other

AdGuard DNS filter

Which DNS server do you use?

Cloudflare DNS

DNS protocol

DNS-over-HTTPS

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Issue Details

Steps to reproduce:

  1. Go-to app management
  2. Select an app, then go-to app firewall settings
  3. Enable or disable use wi-fi
  4. Go back It'll take about 40-60

Expected Behavior

It shouldn't take 40-60s.

Actual Behavior

It's taking around 40-60s

https://github.com/user-attachments/assets/38b27fe3-adc5-42e1-90cd-b5071699cc5e

Screenshots

Screenshot 1

Additional Information

No response

Versty commented 3 weeks ago

@shriganesh Thank you for reporting! We would like to take a look at the logs from your device, please follow the steps below.

  1. Enable debug logging: Settings -> General -> Advanced -> Logging level -> Debug

  2. Reproduce the issue, then remember the exact time when it happened

  3. Collect logs: Settings -> General -> Advanced -> Export logs and system info

  4. Send this file to devteam@adguard.com:

    • mention the 5432 number in the subject
    • specify the exact time when the issue occurred
shriganesh commented 3 weeks ago

Hi,

I tried enabling debug logs, reproduced the issue. But when I tried exporting logs, it keeps failing. I tried several times and it keeps failing.

Thanks,

Shri

On Mon, Aug 19, 2024, 11:51 PM Diana @.***> wrote:

@shriganesh https://github.com/shriganesh Thank you for reporting! We would like to take a look at the logs from your device, please follow the steps below.

1.

Enable debug logging: Settings -> General -> Advanced -> Logging level -> Debug 2.

Reproduce the issue, then remember the exact time when it happened 3.

Collect logs: Settings -> General -> Advanced -> Export logs and system info 4.

Send this file to @.***:

  • mention the 5432 number in the subject
    • specify the exact time when the issue occurred

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5432#issuecomment-2296388335, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ666MI3WT5LG4H7OSU2LTZSHL45AVCNFSM6AAAAABMU6C3J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJWGM4DQMZTGU . You are receiving this because you were mentioned.Message ID: @.***>

Versty commented 3 weeks ago

@shriganesh Please open Developer options screen in the device settings and make sure that the Don't keep activities option is disabled.

shriganesh commented 3 weeks ago

Hi,

I've verified and it's disabled only.

Thanks

On Fri, Aug 23, 2024, 3:40 AM Diana @.***> wrote:

@shriganesh https://github.com/shriganesh Please open Developer options screen in the device settings and make sure that the Don't keep activities option is disabled.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5432#issuecomment-2305071227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ666LUEVP6ZMOZSZ6GKRLZSYBAHAVCNFSM6AAAAABMU6C3J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGA3TCMRSG4 . You are receiving this because you were mentioned.Message ID: @.***>

shriganesh commented 3 weeks ago

Hi,

I also tried reinstalling adguard, tried nightly builds. Still facing the same problem. One thing that I noticed is the problem appears only after I import my firewall rules.

I'll try exporting debug logs once again.

Thanks

On Fri, Aug 23, 2024, 7:50 AM Shri Ganesh @.***> wrote:

Hi,

I've verified and it's disabled only.

Thanks

On Fri, Aug 23, 2024, 3:40 AM Diana @.***> wrote:

@shriganesh https://github.com/shriganesh Please open Developer options screen in the device settings and make sure that the Don't keep activities option is disabled.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5432#issuecomment-2305071227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ666LUEVP6ZMOZSZ6GKRLZSYBAHAVCNFSM6AAAAABMU6C3J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGA3TCMRSG4 . You are receiving this because you were mentioned.Message ID: @.***>

shriganesh commented 3 weeks ago

Hi,

I just tried exporting the logs again. And it failed again.

Thanks, Shri

On Fri, Aug 23, 2024, 9:30 AM Shri Ganesh @.***> wrote:

Hi,

I also tried reinstalling adguard, tried nightly builds. Still facing the same problem. One thing that I noticed is the problem appears only after I import my firewall rules.

I'll try exporting debug logs once again.

Thanks

On Fri, Aug 23, 2024, 7:50 AM Shri Ganesh @.***> wrote:

Hi,

I've verified and it's disabled only.

Thanks

On Fri, Aug 23, 2024, 3:40 AM Diana @.***> wrote:

@shriganesh https://github.com/shriganesh Please open Developer options screen in the device settings and make sure that the Don't keep activities option is disabled.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5432#issuecomment-2305071227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ666LUEVP6ZMOZSZ6GKRLZSYBAHAVCNFSM6AAAAABMU6C3J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBVGA3TCMRSG4 . You are receiving this because you were mentioned.Message ID: @.***>

Versty commented 3 weeks ago

@shriganesh Alright then, let's try to sort out the crash first.

Please follow these steps:

  1. Reproduce the crash, then remember the exact time when it happened

  2. Collect a bug report in the system settings Device settings -> Developer options -> Bug report

(Note: it will take some time to collect the bug report, please wait until the bug report is completed.)

  1. Send this file to devteam@adguard.com:
    • mention the 5432 number in the subject
    • specify the exact time when the issue occurred
shriganesh commented 3 weeks ago

Hi,

It's not actually crashing but it's just very slow and now my mobile battery is dying much faster (my mobile became unusable as filtering became unstable). So I reverted back to v4.5.2. after reverting I'm no longer facing any issues.

On Fri, 23 Aug, 2024, 8:33 pm Diana, @.***> wrote:

@shriganesh https://github.com/shriganesh Alright then, let's try to sort out the crash first.

Please follow these steps:

1.

Reproduce the crash, then remember the exact time when it happened 2.

Collect a bug report in the system settings Device settings -> Developer options -> Bug report 3.

Send this file to @.***:

  • mention the 5432 number in the subject
    • specify the exact time when the issue occurred

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5432#issuecomment-2306583108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ666KQHM3NSFR37YHEQIDZS3XT5AVCNFSM6AAAAABMU6C3J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBWGU4DGMJQHA . You are receiving this because you were mentioned.Message ID: @.***>

Versty commented 1 week ago

@shriganesh The crash when exporting logs will be addressed in #5447, stay tuned!

shriganesh commented 1 week ago

@Versty Thanks. I'm looking forward for a fix as I'm stuck on v4.5. Any version above that is causing this slowness (v4.6.1, v4.6.2 and 2 nightly builds after that).

Was there any change done in 4.6.x and later?

I'm using Adguard in 2 other mobiles. And one of that is again Samsung. But 4.6.2 is working fine on those. Issue appears to happen only in 4.6.2 in S24 ultra (possibly after importing configuration).

I regularly backup and export my firewall rules in all my phones.

Versty commented 1 week ago

@shriganesh Would you mind resetting the AdGuard app to default settings and check if the issue persists with the default settings on the problematic device? It would help us a lot to find the root of this issue.

If so, please clear the app data in the system settings and let me know the result.

Versty commented 1 week ago

@shriganesh The crash during logs export is fixed in the latest nightly version. Please update AdGuard to 4.7 nightly 16 and collect debug logs as described in the https://github.com/AdguardTeam/AdguardForAndroid/issues/5432#issuecomment-2296388335

shriganesh commented 1 week ago

@shriganesh Would you mind resetting the AdGuard app to default settings and check if the issue persists with the default settings on the problematic device? It would help us a lot to find the root of this issue.

If so, please clear the app data in the system settings and let me know the result.

Yes. I've tried it already. It becomes slow only after I import my firewall rules backup. Until then it's reasonably fast.

shriganesh commented 1 week ago

@shriganesh The crash during logs export is fixed in the latest nightly version. Please update AdGuard to 4.7 nightly 16 and collect debug logs as described in the #5432 (comment)

Okay will do it in a couple of days.

ericzeez commented 1 week ago

I'm experiencing the exact same issue on my Galaxy S24. Once I add roughly 10 custom firewall rules, I experience a lot of lag interacting with the app, it's slow to open the different sections within the firewall module, slow to execute an action, etc. The more custom firewall rules I add the slower the app feels, to the point I can no longer even disable firewall notifications. I will toggle to disable a firewall rule notification and it will automatically toggle it right back. Downgrading back to version 4.5 solves all these issues. Avoiding version 4.6.x for now as I use the firewall heavily with many rules.