search

AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.37k stars 90 forks source link

Integrate AdGuard Pro with Samsung Knox VPN API for Enhanced Security #5470

Open yazhamuthan-aruchamy opened 2 months ago

yazhamuthan-aruchamy commented 2 months ago

Issue Details

Currently, AdGuard Pro utilizes traditional/local VPN methods for ad-blocking and tracking protection on Samsung devices. However, Samsung's Knox security offers a more secure and efficient solution through its VPN API. Disconnect Pro already leverages this API, demonstrating its feasibility.

Problem Statement:

The existing local VPN approach has limitations:

  1. Reduced battery life
  2. Increased latency
  3. Incompatibility with certain apps.

Security Concerns:

  1. Traditional VPNs may not provide robust encryption.
  2. Local VPNs can be vulnerable to exploits.
  3. Lack of integration with Samsung's advanced security features.

User Experience:

  1. Complex setup and configuration process.
  2. Frequent disconnections and reconnections.
  3. Limited control over VPN settings.

Knox VPN API Benefits:

  1. Enhanced security and encryption.
  2. Improved performance and battery life.
  3. Seamless integration with Samsung's security features.

Comparison to Disconnect Pro:

Disconnect Pro leverages Samsung's Knox VPN API to block ads and trackers without relying on traditional or local VPN methods. Notably, Disconnect Pro's usage of Knox VPN API does not exclude the simultaneous use of other VPNs, ensuring uninterrupted ad-blocking and tracking protection.

Similarly, integrating AdGuard Pro with Knox VPN API would:

  1. Match Disconnect Pro's industry-leading security and performance standards.
  2. Enhance AdGuard Pro's competitiveness in the ad-blocking market.
  3. Provide Samsung users with an unparalleled ad-blocking experience, combining AdGuard Pro's advanced filtering capabilities with Knox VPN API's robust security features.

Key Benefits:

By integrating AdGuard Pro with Knox VPN API, users can:

Proposed solution

Implement AdGuard Pro integration with Samsung Knox VPN API to:

  1. Enhance security and privacy.
  2. Improve battery life.
  3. Reduce latency.
  4. Increase compatibility with Samsung apps.

Alternative solution

  1. Continue using traditional/local VPN methods
  2. Explore other VPN APIs (e.g., OpenVPN)
  3. Collaborate with Samsung to develop a custom VPN solution

Benefits:

  1. Improved security and privacy for Samsung users
  2. Enhanced performance and battery life
  3. Increased competitiveness with Disconnect Pro
  4. Expanded AdGuard Pro functionality

Implementation Requirements:

  1. Samsung Knox SDK integration
  2. API key acquisition from Samsung
  3. Compatibility testing with various Samsung devices
  4. Updates to AdGuard Pro's filtering algorithms

Acceptance Criteria:

  1. Successful integration with Knox VPN API
  2. Verification of improved security and performance
  3. Seamless user experience
  4. Compatibility with various Samsung devices

Labels:

(feature, enhancement, security, performance)

maxikuzmin commented 1 month ago

@yazhamuthan-aruchamy can you please clarify what you mean by AdGuard Pro? AdGuard Pro version is for iOS only

yazhamuthan-aruchamy commented 1 month ago

Hi,

To my mistake it is not adguard pro it adguard premium on Android. I am mentioned actually the doubts were Clarify on the previous request.

This is just an Feedback in future if you guys collaborate with Samsung for the Knox this will be useful for most of the premium users.

Thanks for this assistance now.

By Yazhamuthan A

On Mon, 30 Sept, 2024, 5:48 pm maximkuzmin, @.***> wrote:

@yazhamuthan-aruchamy https://github.com/yazhamuthan-aruchamy can you please clarify what you mean by AdGuard Pro? AdGuard Pro version is for iOS only

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5470#issuecomment-2383028945, or unsubscribe https://github.com/notifications/unsubscribe-auth/A66PQ7YLAI72QQTNXSPHRRLZZE6RNAVCNFSM6AAAAABO6HIQHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGAZDQOJUGU . You are receiving this because you were mentioned.Message ID: @.***>

maxikuzmin commented 1 month ago

@yazhamuthan-aruchamy

I see mention actually the doubts were Clarified on the previous request.

what do you mean? I don't see any mention of any previous requests. Have you checked with Knox yet?

yazhamuthan-aruchamy commented 1 month ago

Hi actually in the 957342 this ticket thay have clarified the doubts, They have mentioned that right now adguard does not supported KNOX it is bit complicated in future need to redesign and Needed to understand the concept of knox everything so they have mentioned that it will not possible now but in future we will try to add it to the adguard.

That why I have mentioned earlier about this sorry for the inconvenience caused not to mention detailed.

Thanks Yazhamuthan A

On Mon, 30 Sept, 2024, 6:14 pm maximkuzmin, @.***> wrote:

@yazhamuthan-aruchamy https://github.com/yazhamuthan-aruchamy

I see mention actually the doubts were Clarified on the previous request.

what do you mean? I don't see any mention of any previous requests. Have you checked with Knox yet?

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForAndroid/issues/5470#issuecomment-2383087212, or unsubscribe https://github.com/notifications/unsubscribe-auth/A66PQ7YPKYOCZGYSIXLIDCLZZFBUHAVCNFSM6AAAAABO6HIQHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGA4DOMRRGI . You are receiving this because you were mentioned.Message ID: @.***>

0xrxL commented 1 month ago

As a Samsung user, I agree about battery drain. Last AdGuard nightly for example is always always appears on the top of power consumption list. Would be great to try a Knox based version instead.

yazhamuthan-aruchamy commented 1 month ago

@maxikuzmin

I see mention actually the doubts were Clarified on the previous request.

what do you mean? I don't see any mention of any previous requests. Have you checked with Knox yet?

Hi, I am literally Very sorry for those confusions,

I have Mistakenly taken this as an support ticket, where I was replying the answers on my email which I got quite confusion again sorry for that.

Now Let me clear you doubts and one by one.

In android I am an premium costumer for 2 years I would like to have recently switched to samsung A35 5G with Knox protection, on the normal version of android adguard is using the LocalVPN which is really a great one but when it comes to KNOX in samsung they offer an VPN API,

So what Is this ? This is a samsung technology where used to block the ads and trackers using the VPN API instend of without needed the normal tradition/Local VPN slot.

Why this is important in the Samsung? By using this It will free up the VPN slot in the devices and we can able to use the other tradtional VPN in the VPN slot. This way it will be useful to use the traditional VPN to change the IP's and Adguard to block the trackers and ads.

Is this feature is available or any one performed it? Typically Yes, Disconnect Pro uses the Samsung KNOX VPN API to use their software to add this one this will have the abilty to block the trackers and ads also we can able to use the VPN simultaneously without disconnecting the Disconnect Pro app.

Now How does this perform ? If you use the Local VPN to block the ads and trackers in adguard If you try to install the VPN ex: NordVPN it will stop the Local VPN and it will perform the NordVPN unable to blcok the ads and trackers in there.

Alternative solutions ? Trying the Split tunnel to use the adguard premium Still it is not working and tryed many alternative solutions still not yet working.

So these are the things I would like to give it to you in my request for the samsung KNOX instend of using the Traditional/Local VPN method to block the ads and trackers this VPN API method will be able to use the both adguard premium and VPN simultaneously without need to cancel or turn off the other one.

If you have any doubts or clafications Please feel free to contact me without any hesitate. I would like to help you in the upcoming doubts. thanks.

maxikuzmin commented 1 month ago

@0xrxL @yazhamuthan-aruchamy thanks for the info, we will look into this and integrate Knox VPN in the next updates

yazhamuthan-aruchamy commented 1 month ago

Thanks for this it will really an helpful for the peoples who are using samsung with knox.