search

AdguardTeam / AdguardForAndroid

Open bug tracker for Android version of AdGuard.
https://adguard.com/
1.34k stars 90 forks source link

Pros and Contras of ROOT / XPOSED with AdGuard? #798

Closed Bluscream closed 7 years ago

Bluscream commented 8 years ago

Would adding a XPosed module / root request give the app any advantage of what the app can do / filter right now, if yes which? Also would root make ssl filtering work in nougat?

ameshkov commented 8 years ago

Also would root make ssl filtering work in nougat?

Just having root is not a panacea from nougat issues. We can install root certificate in the system storage, but in this case we could face some issues with the websites using HTTP key pinning (like github). I am keeping track of possible issues in this task: #334

XPosed module is the whole different story. Using it could give us a lot and I am seriously considering going this way.

Bluscream commented 8 years ago

@ameshkov wait, http pinning? I moved the Adguard Cert to system storage with MoveCerts! but never had any problems with it until #793 came up. Do you think this is also related to AdGuard being in the system cert store?

image

Bluscream commented 8 years ago

Also @ameshkov if you start using a xposed module please keep it optional, cause on one of my devices (GT-I9295) XPOSED works flawlessly, but another (SM-T555) installing xposed reults in a bootloop... :(

ameshkov commented 8 years ago

Do you think this is also related to AdGuard being in the system cert store?

Exactly, this is the consequence of moving cert to the system storage.

ameshkov commented 8 years ago

Also @ameshkov if you start using a xposed module please keep it optional, cause on one of my devices (GT-I9295) XPOSED works flawlessly, but another (SM-T555) installing xposed reults in a bootloop... :(

Of course, xposed has a lots of issues, we won't require it.

Bluscream commented 7 years ago

I'd like to some kind of auto ssl unpinning except for some banking apps.

Bluscream commented 7 years ago

I'll close this now.