search

AdguardTeam / AdguardForMac

Open bug tracker for Mac version of AdGuard
https://adguard.com/
294 stars 15 forks source link

rootElement.removeChild(currentScript) rootElement is null #1411

Closed captain-xu closed 5 months ago

captain-xu commented 5 months ago

AdGuard version

2.14.0.1588 release

Browser version

No response

OS version

macOS 14.3 (23D56)

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Support ticket ID

No response

Issue Details

Steps to reproduce: 1. 2. 3.

Expected Behavior

No response

Actual Behavior

page crash

Screenshots

Screenshot 1:

Additional Information

No response

captain-xu commented 5 months ago

image

captain-xu commented 5 months ago

image

captain-xu commented 5 months ago

@Aydinv13 where is the code location，I can contribute a PR

PavelParkhomenko commented 5 months ago

Hello! Could you kindly provide a more detailed description of the issue and include steps to reproduce it? Specifically, what is not working or behaving differently than expected?

captain-xu commented 5 months ago

@PavelParkhomenko hello，when I render a child app in micro-frontend app with html entry，adguard will insert javascript to my html file like this image and then this inserted js run with this error image this will cause my page crash

Hello! Could you kindly provide a more detailed description of the issue and include steps to reproduce it? Specifically, what is not working or behaving differently than expected?

captain-xu commented 5 months ago

@PavelParkhomenko Is it necessary to judge whether the rootElement is null before rootElement.removeChild?

PavelParkhomenko commented 5 months ago

Thank you for clarifying! We've already addressed the issue and a fix will be included in the upcoming CoreLibs 1.15 update, which will be released shortly.