search

AdguardTeam / AdguardForMac

Open bug tracker for Mac version of AdGuard
https://adguard.com/
285 stars 15 forks source link

Quick battery reduction #1415

Closed axel-stoyn closed 1 month ago

axel-stoyn commented 2 months ago

AdGuard version

2.14.0.1592 release

Browser version

Safari 17.4.1 (17618.1.15.111.8, 17618)

OS version

macOs Monterey 12.7.4

What filters do you have enabled?

AdGuard Base filter, AdGuard Russian filter

What Stealth Mode options do you have enabled?

No response

Support ticket ID

No response

Issue Details

Steps to reproduce:

  1. Full battery charge
  2. Run AdGuard
  3. Remove plug in from socket (use only battery)
  4. Disable mac sleeping, e.g. watch any film or something like that

Expected Behavior

The battery won't be low for the 2-4 hours

Actual Behavior

The battery lows quickly, after ~2-4 hours you can see ~10%

Screenshots

Screenshot 1:

Additional Information

No response

axel-stoyn commented 2 months ago

Started to use 2.13 version and I don't see the same issue.

In addition, you can see "Activity monitor" -> "com.adguard.mac.adguard.network-extension" process name. In 2.13 version it is around 0.1-4%, in 2.14 version it was around 70% with the same activities

AlexandrPkhm commented 2 months ago

@axel-stoyn Hi,

Unfortunately, we are unable to reproduce this issue on our end. Could you please try to install AdGuard for Mac 2.14 again and if the issue persists please record the app logs for us? We will need them to diagnose and troubleshoot the issue.

Here's what we need you to do:

  1. Click AdGuard icon in the menu bar → Gear → Advanced → Logging → Logging level → Debug;
  2. Reproduce the issue and remember the exact time it happened;
  3. Menu → Advanced → Logging → Export Logs and System Info…;
  4. Send the archive to apple@adguard.com and mention this issue number in the subject.
Seadart76 commented 2 months ago

Same here....170% CPU usage by Adguard since the lates Update. Where can I download 2.13?

axel-stoyn commented 2 months ago

@Seadart76 I couldn't find on the official site old versions, and I used a torrent to download the 2.13 version. The subscription continues to work on older version too.

Seadart76 commented 2 months ago

Logs are forwarded to a development team and are removed from the issue for privacy reasons

Here is the Log

AlexandrPkhm commented 2 months ago

@Seadart76 Hi,

Thank you for the provided logs. If it is possible, could you please specify the approximate time of the issue? This is needed, so our development team can more precisely pinpoint the exact cause of the issue.

nikkikom commented 2 months ago

Possible duplicate of https://github.com/AdguardTeam/AdguardForMac/issues/1407

Seadart76 commented 2 months ago

@nikkikom Sorry, I'm also back to 2.13 now and i haven't checked when the issue started.

axel-stoyn commented 2 months ago

In additional, I can say that the issue is intermittent and sometimes difficult to reproduce. e.g. for now, I use 2.14 again with the same processes (due to work) and the issue is not present now

@nikkikom, almost the same :) I don't see anything about battery there. But generally, this issue related to #1407

axel-stoyn commented 2 months ago

@AlexandrPkhm I provided logs on email too. The time what was happened ~8.30 am (Minsk time zone)

Maybe it can help: I ran AdGuard yesterday and went to sleep, just closed laptop, after ~8-9 hours the laptop was opened, and I've started to feel a temperature near the keyboard, after opening "activity monitor" and I saw ~105% CPU usage for "com.adguard.mac.adguard.network-extension"

eshack94 commented 2 months ago

This is almost certainly the same issue reported in #1407.

I am experiencing the same problem. It also started after the latest releases for me. Based on multiple user reports, this should probably be higher priority.

AlexandrPkhm commented 2 months ago

@Seadart76 @axel-stoyn Hi,

Thank you for the logs you provided. We have already identified the cause of the problem and are preparing a fix. As a temporary solution, we recommend that you select any non-System DNS server in the DNS protection settings.

We will update this issue as soon as the fix is released.

eshack94 commented 2 months ago

@AlexandrPkhm Great news! Can you provide any details on the cause of the issue (high-level), just curious! :)

AlexandrPkhm commented 1 month ago

@Seadart76 @axel-stoyn @eshack94 Hi,

We have released a Nightly version of AdGuard for Mac with a fix for this issue. Could you please download the latest Nightly build via the following link and check if the issue still persists?

We would appreciate it if you could let us know of the results.

eshack94 commented 1 month ago

@AlexandrPkhm Will let you know, testing today. Thanks!

axel-stoyn commented 1 month ago

TO: @AlexandrPkhm Give us please several days, 'cause difficult to reproduce, need time.

CC: @eshack94, @Seadart76

BTW. What was the root cause? Previously (in < 2.13 version), I didn't remember that we needed to agree with DNS option, but now need it.

AlexandrPkhm commented 1 month ago

@axel-stoyn

The issue was caused by a bug in the DNSLibs component of the app, which caused a CPU spike whenever DNS queries were performed over TCP. This resulted in a quicker battery drain due to the high CPU usage.

eshack94 commented 1 month ago

Just reporting back:

The latest "Nightly" build seems to have fixed the issue for me. I haven't seen the problem happen again. Thank you!

cc @AlexandrPkhm

AlexandrPkhm commented 1 month ago

We appreciate you letting us know!

We are receiving similar reports from the previously affected users as well. In this case, we will close this issue. Should you encounter any issues in the future, please do not hesitate to contact us.

axel-stoyn commented 1 month ago

I stopped to see the issue too. I guess the fix works correctly, and you can release these changes in the base build.

Thank you so much for fixing.