AdguardTeam / AdguardForMac

Open bug tracker for Mac version of AdGuard
https://adguard.com/
294 stars 15 forks source link

Cannot sign in via social networks when certain settings are set in Safari #1418

Closed ghost closed 4 months ago

ghost commented 5 months ago

Issue Details

When using the Sign in with Apple method, it will not complete, continuing in an endless loop of opening the Sign in with Apple page, confirming the login, then back to the Sign in with Apple page.

macOS: 14.5 Beta (23F5064f) Safari: Version 17.5 (19618.2.10.11.4) AdGuard for Mac: Version 2.14.0.1594 nightly

Proposed solution

Complete the Sign in with Apple feature, then be taken back to the app.

Alternative solution

No response

Aydinv13 commented 5 months ago

@jslawler-gh

Could you please record a short video so we can see what it looks like?

ghost commented 5 months ago

@Aydinv13 - Emailed to apple@adguard.com.

Aydinv13 commented 5 months ago

@jslawler-gh can't find your message. Could you resend it please?

ghost commented 5 months ago

@Aydinv13 forwarded a second time to apple@adguard.com.

The subject is the same name as this issue.

Aydinv13 commented 5 months ago

@jslawler-gh e-mailed you personally.

ghost commented 5 months ago

@Aydinv13 I've replied with the attachment. Failing that I'm in both the AdGuard Telegram and AdGuard Slack.

Aydinv13 commented 5 months ago

Does a cache reset or reboot help? Does it happen only with Apple login? Could you also check it with different browser please.

oo-rbiiix commented 5 months ago

I have same issue. Adguard for mac app is sign out and impossible to activate. Login with apple ID is looped, Activation code enter is not reacting. Tried beta, nightly, previous versions. All the same. Probably it could be related with newest mac os beta. Maybe it blocks the activation process ? dont know Screenshot_2024-04-28 11 47 36_ZNf9hj CleanShot 2024-04-28 at 11 45 17@2x CleanShot 2024-04-28 at 11 44 37@2x CleanShot 2024-04-28 at 11 43 59@2x CleanShot 2024-04-28 at 11 43 31@2x

ghost commented 5 months ago

@Aydinv13 It works in Google Chrome. It seems that the social login does not finish its login, forwarding to the 2FA aspect of the AdGuard login on Safari.

Aydinv13 commented 5 months ago

@oo-rbiiix your problem is related to the recent bug in Sonoma beta 14.5 https://github.com/AdguardTeam/AdguardForMac/issues/1410#issuecomment-2089844512

Aydinv13 commented 5 months ago

@jslawler-gh

Can you check if authorization via Apple (with Safari) works in another app not related to AdGuard? It can be a website as well. What if you update to a new beta version of Sonoma?

ghost commented 5 months ago

@Aydinv13

I'm able to use "Login with Apple" with Cloudflare. I'm on the latest dev beta, and I can't login to AdGuard's website with "Login with Apple", or the app.

Aydinv13 commented 5 months ago

@jslawler-gh could you tell me which option is selected in your Settings for Safari browser in General -> Safari opens with?

Example up85_jkhuj
ghost commented 5 months ago

@Aydinv13

Screenshot 2024-05-03 at 11 41 12 AM
Aydinv13 commented 4 months ago

@jslawler-gh I can reproduce it only with incognito mode, are you not using it in some way?

ghost commented 4 months ago

@Aydinv13, that brings something to mind. The feature "Use advanced tracking and fingerprinting protection" by default is set to private windows only, but I use it for all browsing.

Screenshot 2024-05-06 at 23 33 57

It seems that this is preventing the sign-in with Apple feature, completing, then moving on to the 2FA auth AdGuard page, or completing the login.

The location for Apple's link tracking protection details can be found here: /private/var/folders/[random]/[random]/C/com.apple.WebPrivacy. I imagine something in there might be a giveaway as to why it's not completing.

Screenshot 2024-05-07 at 00 05 57
Aydinv13 commented 4 months ago

As further work will be done on the web's side, I am closing this issue. As a temporary solution, set the value to private windows only to Use advanced tracking and fingerprinting protection in Safari.