Please update Traditional Chinese translations for filters.

[lancelot-moon]

I don't have a macOS PC. I'm unable to check filters' translations in AG for macOS. But I guess that Simplified Chinese is used in Traditional Chinese language file for filters, such like AG for Windows. https://github.com/AdguardTeam/AdguardForWindows/issues/2245

1. Only use Traditional Chinese translations for filters in Traditional Chinese language file.

2. "English filter (英文過濾器)" was renamed to "AdGuard Base filter (AdGuard 基本過濾器)". You should also update the translations of filters from oneskyapp.

Please fix them.

Thanks.

[ameshkov]

@Stillness-2 could you please verify that the exact locale (zh-tw in this case) is used to get the filters translation?

[vityevato]

@ameshkov, I checked. All ok.

[lancelot-moon]

Hi, may you change to use Traditional Chinese (正體中文) in AG for macOS and then make a screenshot of filters?

Please upload that screenshot here.

I want to check its translations for filters. Sorry that I don't have Mac.

[lancelot-moon]

Hi, Those translations of filters in your screenshot are Simplified Chinese (zh or zh_CN), not Traditional Chinese (zh_TW). You have to apply my Traditional Chinese translations (zh_TW) for filters in Traditional Chinese language file from oneskyapp. You need to reopen the topic until you solve the issue. AG for Android & iOS already fixed the mistake. Maybe other AdGuard team members know how to do. https://github.com/AdguardTeam/AdguardForAndroid/issues/1762#issuecomment-371974105 https://github.com/AdguardTeam/AdguardForAndroid/issues/1762#issuecomment-373313051 https://github.com/AdguardTeam/AdguardForAndroid/issues/1762#issuecomment-373740042

Ex: English filter -> AdGuard Base filter You still don't update the translation of AdGuard Base filter. So it still shows the translation of English filter. In your screenshot, English filter (now it's AdGuard Base filter)= 英语过滤器 (Simplified Chinese, zh) = 英文過濾器 (Traditional Chinese, zh_TW) Spyware filter = 间谍软件过滤器 (Simplified Chinese, zh) = 間諜軟體過濾器 (Traditional Chinese, zh_TW) ...etc.

You can clearly know the differences of translations between Simplified Chinese and Traditional Chinese from my examples.

Thanks a lot!

[vityevato]

            "zh": {
                "name": "英语过滤器",
                "description": "基于 EasyList 开发的过滤器。过滤器可以移除以英语内容为主网站上的广告。"
            },
            "zh_TW": {
                "name": "英文過濾器",
                "description": "EasyList + AdGuard 英文過濾器。該過濾器對於優質的廣告封鎖是必要的。"
            }

@lancelot-moon

[lancelot-moon]

Yes, you got it. For filters, you should use "zh_TW" in the client side, not "zh".

And update the translations of "AdGuard Base filter" and its description. In all platforms' AdGuard apps, they still shows the translation of "English filter" now although you already modified it to "AdGuard Base filter". https://github.com/AdguardTeam/FiltersRegistry/issues/67

Thanks.

[vityevato]

@lancelot-moon First screenshot was made from wrong version (1.5.6). The current version of the app (1.5.8) contains correct processing for zh_TW.

[lancelot-moon]

Great, it's already solved in AG for macOS v1.5.8! Thanks for your reply! Sorry to bother you. m( )m

[lancelot-moon]

Hi, May you show the screenshot about the translation of Traditional Chinese title? In the past, AdGuard for Windows used "China tradition" as "Traditional Chinese", which is wrong. https://github.com/AdguardTeam/AdguardForWindows/issues/2190

I am not sure if AG for macOS has the same mistake.

Thanks.

[vityevato]

@lancelot-moon Adguard for Mac do not have language switcher, it is done from system preferences.