AdguardTeam / AdguardForWindows

AdGuard for Windows open bug tracker
https://adguard.com/
690 stars 72 forks source link

Faulty "+", "-", "X", "gear" signs and boxes for Filter editors #4317

Open gork7777 opened 2 years ago

gork7777 commented 2 years ago

The "+" sign next to Add a filter on the Ad Blocker tab is unequal pixels. I guess that equates to checkbox pixels? Also the "+" sign in add a custom DNS server on the DNS Protection tab is unequal pixels. Moreover, in the Filter editors (DNS Filter editor too) and Parental Control blocklist and allowlist, the boxes below and the "+", "-", "X" and "gear" signs pixels are unequal. When I calculate the pixels of the boxes from the inside, it turns out to be 29x30 pixels. If these boxes are square, I think the pixels should be 30x30 (Since double pixel will be used, it must be double pixel). I calculated the pixels of the signs in red and the edges in blue and wrote down the pixels. These signs and boxes should be equal and maybe checkbox too?

Ad Blocker add a filter "+" sign ![AdBlocker_sign](https://user-images.githubusercontent.com/35523759/177362871-5aabedb5-ad1d-438b-8705-6b002f9b84ce.png)
DNS Protection add a custom DNS server "+" sign ![Custom_DNS](https://user-images.githubusercontent.com/35523759/179034499-4c2efa0e-7743-4447-a500-9a1bd771b15c.png)
"+" sign equate with checkbox ![Checkbox](https://user-images.githubusercontent.com/35523759/177362927-d41f2cd9-8579-4dd7-aa12-45a8d7d56978.png)
Boxes pixels in filter editors ![Boxes_pixels](https://user-images.githubusercontent.com/35523759/177363038-ff1f3228-1a95-4b95-a82e-9df53985933a.png)
"+" and "-" signs in filter editors ![Signs](https://user-images.githubusercontent.com/35523759/177363003-42b28147-618a-40a9-809d-c0242bd2bba3.png)
"X" and "gear" signs in filter editors ![X](https://user-images.githubusercontent.com/35523759/179333359-2e53c52c-a198-4756-8f9b-694ae28a5fd3.png) ![gear](https://user-images.githubusercontent.com/35523759/179333394-30e5155e-8195-4246-8ff9-3ad9df90538a.png)
northis commented 2 years ago

@gork7777 What system scale do you use? These values can be slightly different on non-100% scale.

gork7777 commented 2 years ago

@northis I'm using %100 system scale.

northis commented 2 years ago

OK, thank you for this, we will change the UI there.