AdguardTeam / AdguardForWindows

AdGuard for Windows open bug tracker
https://adguard.com/
675 stars 72 forks source link

Identical comments are removed in the Filter editor after checking for updates #5118

Closed Alex-302 closed 2 months ago

Alex-302 commented 4 months ago

Please answer the following questions for yourself before submitting an issue

AdGuard version

7.17.n33

Browser version

Chrome 122

OS version

Windows 10 x64

Traffic filtering

Ad Blocking

AdGuard Base filter

Privacy

No response

Social

No response

Annoyances

No response

Security

No response

Other

No response

Language-specific

No response

Which DNS server do you use?

DNS protection disabled

DNS protocol

None

Custom DNS

No response

What Stealth Mode options do you have enabled?

No response

Support ticket ID

No response

Issue Details

! (or #) used as separator when creating rules. Now you have to make comments unique so they don't get deleted. This is an inconvenience when working with the editor.

Proposed solution: Don't apply duplicate checking for [short] comments.

Steps to reproduce:

  1. Add few lines with only !
  2. Check for filters update.

Expected Behavior

Duplicated lines are not removed.

Actual Behavior

Duplicated lines was removed.

Screenshots

Screenshot 1

Additional Information

No response

Alex-302 commented 4 months ago

Hm. Opened as a bug, but the label is not assigned.