AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.45k stars 203 forks source link

Show number of rules for each filter #113

Closed pietrodn closed 4 years ago

pietrodn commented 8 years ago

Hi, it would be useful to see in the filter properties the number of rules of each filter. In this way, if the user hits the maximum number of rules, they know which ones to remove.

ameshkov commented 8 years ago

The problem with this is that we don't know how many rules will be left after filters compilation process.

Example

Filter1:

###banner1
###banner2

Filter2:

###banner3
###banner4

Resulting content blocker will have only one rule:

[
    {
        "action":
        {
            "type": "css-display-none",
            "selector": "#banner1, #banner2, #banner3, #banner4"
        }
    }
]

Maybe instead of the in-app filters compilation we should do it on the server side. This will make this all much easier. @Stillness-2 what do you think about it?

ameshkov commented 4 years ago

available in v3.0 (content blockers screen)