search

AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.44k stars 202 forks source link

Constant crashing on reddit.com #1906

Open jimmysofat6864 opened 2 years ago

jimmysofat6864 commented 2 years ago

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

Issue Details

Reddit seems to crash on any article with AdGuard enabled. To reproduce, just open a reddit article with some filters and eventually the page will crash and you will get the message I get. If it doesn't happen, just refresh the page a few times or load comments or look at some articles and eventually, it will crash and display the message I got. If I enable all the filters in annoyances or privacy, it crashes much faster sometimes without even reloading. Oddly this doesn't seem to be an issue with my iPhone X on IOS 15 just on my 7 Plus on 14.8 and my iPhone 6 Plus on 12.5.5.

Expected Behavior

Reddit works just fine

Actual Behavior

Reddit constantly crashes

Screenshots

Screen Recording: https://user-images.githubusercontent.com/69532417/148837847-fee22b37-3064-45a8-aeac-8ed43521ba8b.MP4

Additional Information

Might be a memory issue or something.

Referred from this issue

https://github.com/AdguardTeam/AdguardFilters/issues/101155

jimmysofat6864 commented 2 years ago

And Yes I already did everything in this link but it didn't fix it. It is clearly and AdGuard problem because it is fixed when AdGuard is disabled. And the same behavior happens on multiple older IOS devices I have tested with. IOS 12,13,14 is affected but IOS 15 appears to be fine.

(https://browserhow.com/how-to-fix-safari-mac-problem-repeatedly-occurred-error/)

jimmysofat6864 commented 2 years ago

Issue URL (Incorrect Blocking)

https://www.reddit.com/r/ios/comments/r2e6qo/apple_should_focus_on_ios_and_user_experience/

Comment

Username: @jimmysofat6864

Reddit seems to crash on any article with AdGuard enabled. To reproduce, just open a reddit article with some filters and eventually the page will crash and you will get the message I get. If it doesn't happen, just refresh the page a few times or load comments or look at some articles and eventually, it will crash and display the message I got. If I enable all the filters in annoyances or privacy, it crashes much faster sometimes without even reloading. Oddly this doesn't seem to be an issue with my iPhone X on IOS 15 just on my 7 Plus on 14.8 and my iPhone 6 Plus on 12.5.5.

Screenshots

Screenshot 1 ![Screenshot 1](https://reports-img.adguard.com/LzOypPe.png)
Screenshot 2 ![Screenshot 2](https://reports-img.adguard.com/9Yom29X.png)
Screenshot 3 ![Screenshot 3](https://reports-img.adguard.com/3GM3TyS.jpg)

System configuration

Information value
AdGuard product: AdGuard/AdGuard Pro for iOS v4.2.2
Browser: Safari
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Annoyances:
AdGuard Annoyances

Originally posted by @adguard-bot in https://github.com/AdguardTeam/AdguardFilters/issues/101155#issuecomment-980504421

https://streamable.com/pnf6kb

jimmysofat6864 commented 2 years ago

And Yes I already did everything in this link but it didn't fix it. It is clearly and AdGuard problem because it is fixed when AdGuard is disabled. And the same behavior happens on multiple older IOS devices I have tested with. IOS 12,13,14 is affected but IOS 15 appears to be fine.

(https://browserhow.com/how-to-fix-safari-mac-problem-repeatedly-occurred-error/)

AleksandrShulgin commented 2 years ago

@jimmysofat6864 Send app logs to your email: devteam@adguard.com We'll see what the problem might be. Also please specify the time of occurrence.

jimmysofat6864 commented 2 years ago

@jimmysofat6864 Send app logs to your email: devteam@adguard.com We'll see what the problem might be. Also please specify the time of occurrence.

@AleksandrShulgin logs have been sent via email and through the app bug reporter.

AleksandrShulgin commented 2 years ago

@jimmysofat6864 Try adding a domain reddit.com to allowlist Safari and DNS protection. Then check if the problem is repeated.

jimmysofat6864 commented 2 years ago

@AleksandrShulgin I tried that and the page doesn't crash now albeit the ads show up.

AleksandrShulgin commented 2 years ago

@jimmysofat6864 What if you try adding a domain reddit.com only in the allowlist DNS protection. Will the problem be repeated?

jimmysofat6864 commented 2 years ago

@AleksandrShulgin I usually don't use DNS protection but adding reddit.com to the DNS allow list and removing it from the Safari protection causes it to crash. Adding it to Safari protection stops the page from crashing but ads are present.

jimmysofat6864 commented 2 years ago

@AleksandrShulgin To sum up adding it to both DNS protection and Safari Protection stop the crashing but ads leak through. Using only Safari Protection whitelist also yields the same result. But using only DNS protection whitelist and the page crashes.

Aydinv13 commented 2 years ago

I guess the problem is in Base filter. Reproduced the issue on iOS 12.4.8 having opened random post and scrolled comment section.

jimmysofat6864 commented 2 years ago

Any updates?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jimmysofat6864 commented 2 years ago

Any update on this?

On Wed, Apr 27, 2022 at 7:10 PM stale[bot] @.***> wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForiOS/issues/1906#issuecomment-1111662747, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSPWAOIJZM4DKTSUT43P43VHHXRZANCNFSM5LZUZ3MA . You are receiving this because you were mentioned.Message ID: @.***>

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jimmysofat6864 commented 2 years ago

Any updates? On Sat, Aug 13, 2022 at 12:27 PM stale[bot] @.***> wrote:

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

— Reply to this email directly, view it on GitHub https://github.com/AdguardTeam/AdguardForiOS/issues/1906#issuecomment-1214211069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSPWALYG6LWBYUA46WHDZDVY7ZLBANCNFSM5LZUZ3MA . You are receiving this because you were mentioned.Message ID: @.***>