AdguardTeam / AdguardForiOS

The most advanced ad blocker for iOS
https://adguard.com/
GNU General Public License v3.0
1.45k stars 203 forks source link

Persian translation pluralization broken in extension #1922

Closed Jeehut closed 2 years ago

Jeehut commented 2 years ago

The Persian Stringsdict translation file here has 2 problems:

  1. It's empty, while all other languages have some entries in there.
  2. It's invalid XML/Plist format, cause it has a </dict> end-tag but no opening <dict> start-tag.

Here's the Stringsdict files full content right now:

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
  <dict/>
</plist>
ameshkov commented 2 years ago

@Jeehut hi, does it break the app in some way?

edit: nvm, I see that it crashes the app.

These files are actually auto-generated when we import translations from Crowdin so we could accept your fix for now, but the ultimate solution would be to translate these strings:)

Jeehut commented 2 years ago

I don't actually use the app in that language, I'm just writing a translation tool and recognized it in my unit tests and thought I should report it. :)

ameshkov commented 2 years ago

@Jeehut thank you, helped a lot!